Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>
CC:     Yu Zhao <yuzhao@google.com>
Subject: [PATCH v12 46/69] acct: use VMA iterator instead of linked list
Thread-Topic: [PATCH v12 46/69] acct: use VMA iterator instead of linked list
Thread-Index: AQHYm97tBQNavi/qPUeVNysI9cHMUQ==
Date:   Wed, 20 Jul 2022 02:17:58 +0000
Message-ID: <20220720021727.17018-47-Liam.Howlett@oracle.com>
References: <20220720021727.17018-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220720021727.17018-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ps0LvIIbRM7q32jydNmiQzPcIBQkidlzJdowyqsVNzb1haF95Tiymlcgdf?=
 =?iso-8859-1?Q?AtFtTq7uP2Vm/yNF4Fjg1jgQoz8S9IAuc8r5hGHIATICil1kyN1E8jeNqj?=
 =?iso-8859-1?Q?x2aA5tTS/e5F4lJeKs7N15Y5DSf2/jmTF/1ABQQC0u7ukcrUWjkYJ2vPLj?=
 =?iso-8859-1?Q?EGQ6JaIPgJVz2DWGdQK4C+B0qgdeHQfiukt20GFqepLFISDvBz7n0wcsKE?=
 =?iso-8859-1?Q?5uE5M1AUgaeEMMuaCBG6mt1VyQ2j+YlLfsQuXTZwgEshL0OsakIw6q3f77?=
 =?iso-8859-1?Q?Kik6CgVtmIMos1Qg32SvVGLeKqgE3z44b7gnJ7xPqzsmllhSqx2kNNzPpp?=
 =?iso-8859-1?Q?s4KxYgQosdJahBIkW77gbMCLC1FxAj0Fhc3CUFTxpMsPKwqz2vZwPkYR8D?=
 =?iso-8859-1?Q?iopAaOxLbLQHxcMrvNwrVFOG6QDhtIcKGkA8qNNTI8RVWy3fkpHJkTPVVK?=
 =?iso-8859-1?Q?Lqd44IY3sLgXCTnvs8LPMs+xTHyPgRLT0OFtxpiZQJUOdai13ItcX5JhM5?=
 =?iso-8859-1?Q?Rih8IblgieAWMKUq999Jm4dC+UJ+wSaObgS907+VdpPK1E9n/Hvn6mcGfT?=
 =?iso-8859-1?Q?6XHRQZqevd1DxfmfE/poymc34kPmjcZcLMsd9g6kHXTd3ma8YnwxGyrALj?=
 =?iso-8859-1?Q?Kyw5/oRUTTYKEKVRbmNnoP6dL1Jt+bLL4jOkx2REpATPmHy0hdHXpc+4vJ?=
 =?iso-8859-1?Q?TATMWTECmkCUXETSS6HNsSOH3Ptu5hOqm3toH8FYaOTryMgOd7BwB6AHvs?=
 =?iso-8859-1?Q?auq6S56P3d+L9d2n/RdIVfGJ4a+g9pNcROJfOWY6uwZkWaEy8DsiF9mAGm?=
 =?iso-8859-1?Q?RvhImlNFB7IfZn7p2q01PFdeBupXbcDKx89U79ihcpCgnQuD8nupr8/j3M?=
 =?iso-8859-1?Q?3oVLPF2ulDy1a/CGuCyIfDGJTaXxdhW5DwlPYyeji5JSIEnA+UEqMAcszO?=
 =?iso-8859-1?Q?4oeT0GbDOkKZkgCmLcMdckQsANrwX0Pj9stjqZocLWq648lamtW350y1L5?=
 =?iso-8859-1?Q?LcfeO2EibpjDdzBnYNvrDd+aNJaXnBQ0jsXOFyWI4YXUfBBZeOYGmwwKFH?=
 =?iso-8859-1?Q?aKkh1Ji2U9TmNecpnMA8DFEvz7rAde/4CxuQHQm74339X/1W36t0XUbpoK?=
 =?iso-8859-1?Q?Ge3xwJdWvW+XYtS/ZHLTLV5lP4myW5hnSlkzOb1y+SKdZOUB1sMmKSMRMf?=
 =?iso-8859-1?Q?DlN8QriJhvvEnjJjBUNv45YaDRCkv4mlnF9HQ2gsRryIqctPA5A8beMkde?=
 =?iso-8859-1?Q?O9i2qD5VW7gLcarDUzHFjIj7pxsocpAhMhO0gWTPOAJxTw9zGOMkzB6zaW?=
 =?iso-8859-1?Q?FO1LXHM2W+Pf/oUzqY/2/j8O4GaRTtqGQB1obR/fUUNHe+eK8GcxiJzQeI?=
 =?iso-8859-1?Q?Yf96wBgfCPuCZGIy5GNV/mqp83pksb8f7JL8BHdCihB/T4mYjj0Q2V2Dug?=
 =?iso-8859-1?Q?Pi3bwpVipjbr0HXdU2HvR9oWrdTxRdD/zbEa95Iqav3hTIUYxukYKXrmvt?=
 =?iso-8859-1?Q?o3TgsfXJWQD8OFq3wg4ZP+8FmkDnHWl51ubZDCWjIgJ3brgJPO07prB3Oi?=
 =?iso-8859-1?Q?+SQjYYKbDPzYRjl+kj4Ju7VXZ1ezLK+idoiEEOghbqvdVbTmtMenhNa8A1?=
 =?iso-8859-1?Q?exiWU4SigWXx7sGF8teVtvH2+gxmSV9DAogbBfqzwS8qEmfaR/lUp6bQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ac9c446-13d9-4c70-a6a2-08da69f6274b
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 02:17:58.5397
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OO8YhXRmkSKA3qp4HcH6FsDgIFVKsZASNANvZs+3ftM7l003iSvvCTadpEmwT5AJKsfFmtbcyXcKfHQM0Rjp9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3797
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-19_10,2022-07-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207200008
X-Proofpoint-GUID: RLeBMJ4De0RCsD0ZP-PfckzNsXD8ntTU
X-Proofpoint-ORIG-GUID: RLeBMJ4De0RCsD0ZP-PfckzNsXD8ntTU
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list.

Link: https://lkml.kernel.org/r/20220504011345.662299-31-Liam.Howlett@oracl=
e.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-47-Liam.Howlett@orac=
le.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 kernel/acct.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kernel/acct.c b/kernel/acct.c
index 13706356ec54..62200d799b9b 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -555,15 +555,14 @@ void acct_collect(long exitcode, int group_dead)
 	unsigned long vsize =3D 0;
=20
 	if (group_dead && current->mm) {
+		struct mm_struct *mm =3D current->mm;
+		VMA_ITERATOR(vmi, mm, 0);
 		struct vm_area_struct *vma;
=20
-		mmap_read_lock(current->mm);
-		vma =3D current->mm->mmap;
-		while (vma) {
+		mmap_read_lock(mm);
+		for_each_vma(vmi, vma)
 			vsize +=3D vma->vm_end - vma->vm_start;
-			vma =3D vma->vm_next;
-		}
-		mmap_read_unlock(current->mm);
+		mmap_read_unlock(mm);
 	}
=20
 	spin_lock_irq(&current->sighand->siglock);
--=20
2.35.1