Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>
CC:     Yu Zhao <yuzhao@google.com>
Subject: [PATCH v12 47/69] perf: use VMA iterator
Thread-Topic: [PATCH v12 47/69] perf: use VMA iterator
Thread-Index: AQHYm97uMC1XskqOqUeUyXxzns4sdA==
Date:   Wed, 20 Jul 2022 02:17:58 +0000
Message-ID: <20220720021727.17018-48-Liam.Howlett@oracle.com>
References: <20220720021727.17018-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220720021727.17018-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?0wjP1+vmE0igAa4mgY70afq+rt2OCdfNJ+vLVuvBv+Br4Xapaup69xvEMp?=
 =?iso-8859-1?Q?v+5F68DnBzx/+UGaryYu0kT8WTmeC7d95EB6QNVqPPYr9KODuP0xEFgXSv?=
 =?iso-8859-1?Q?dxmskmvllHtV8RqGjsuokcQLyMJuku4jckbIHZ3YZQcc2JlSWb5PVJDpNt?=
 =?iso-8859-1?Q?YGueEt07bXzxfpXoDoUNpr0JGUaYf49b0YNEthqsuR2Wx9fszqVLB8/JOv?=
 =?iso-8859-1?Q?HPA0y0k8Xie1ryfyO6BXiKS/2Ed+uikzTx/qLTU5VBkHf7VhHz6Vvpdu6e?=
 =?iso-8859-1?Q?Ut62Qjq/mQZeuLzuTxEep+3tNvIkXC+6gA4evkkeVrNl+nuyccWAE9ex/A?=
 =?iso-8859-1?Q?XPjmtkdKlLatBKaLLbYFDO7hgOKJ8xYGBnzHbYRlUYPDFBgk9F+jQkHAYy?=
 =?iso-8859-1?Q?VF72Z+aZWAq3ylmGbQwjm2HydSrzrUu/F7qzvJvuSrv4jG2rp4HsbcORk2?=
 =?iso-8859-1?Q?xYAxNE/E6CUmd8dnmfiNuhjUzDpMXGfJ3L9SPFvZDPvYUDWM34JAX9X+np?=
 =?iso-8859-1?Q?gjiMqcY8xZdzPq3PS7TIwTZ2k4wyVvXWc1H3nVaR4quJJQwoJSqaqUD3Pu?=
 =?iso-8859-1?Q?fF8VgaAc0gL99GRFyy6ApgVy7Pku0meEkS7iBhUfaXzHBH6QBavetBTFr6?=
 =?iso-8859-1?Q?AAerY1m7oudanrHtYfnXiqF4SlPaAmQtPoaTWqUStCX8R7t/kJXUDvL35X?=
 =?iso-8859-1?Q?7BnUH2ZxALT/Ikw4078tld55+ZMFYlfTQM35FD7mJ+CDoASTAghhBMPPJj?=
 =?iso-8859-1?Q?gH7DLTGGLh4JJbLegSEupGDGVsVCH/PwZeczLiZWUnaQxMyQwycIlqajBN?=
 =?iso-8859-1?Q?TW+9DcXGgYy8Be4wZ0mZwfi20bJQzY5Tnsn5G4QMFADllbzukdevQo7/DI?=
 =?iso-8859-1?Q?Vi3CnEHZ8bBA463WMsBMLbqGfHuV6lndTyy+UHAnzvuzj0nqvNGrLi613l?=
 =?iso-8859-1?Q?ehkY/ZHMGUkrDrN7mz+Ctmv0ZxbQ+FPxcgkftqTrIL1yZ0n7Sil7YjV9AE?=
 =?iso-8859-1?Q?DRiAGrYQvhlQ1KmWvLMel1rWgVLwmM7+jBkAlpkKDqnv5qOYg54u18Tjou?=
 =?iso-8859-1?Q?4nRedLxv1vmb0Zv2qBntc+li4tLzmETqAKVJiay6rDnZq3RBrPsUm22Nvi?=
 =?iso-8859-1?Q?ciXLA4T/2K0Li3F97kw6/otOIlX/zMtspeKqqOryRLJlvMFVAbRAsVxmeL?=
 =?iso-8859-1?Q?7PCi1Ln71gumB7o72w1x6q8VaRDErBvlP3d1ImasMdfN8NpMfFwwxoXvWc?=
 =?iso-8859-1?Q?lpkzMzbFSzw2K8dhVs+Or7whZ2qUIU8BNNn5qZxB9G8Yld+IKyccj6pbAQ?=
 =?iso-8859-1?Q?KHhkRQhyY68c5+NbYPP/4tazERw3KTlSxJoiE1hEUd7nottmA6jRPhIRxR?=
 =?iso-8859-1?Q?cDjDXnXT9G2Hl01SVMGpZm3X8tLoUbx8OlG09m+JT1s+11sh90Yz9nXhXB?=
 =?iso-8859-1?Q?Zgig5SfJ/3GEV63mvPRR163EMQeKPpHAfG2iM+61dUnOFRtrpaxFkvP2ZX?=
 =?iso-8859-1?Q?h3s9YJwF5xdKZ1DuChEpzuGPTfvJNTKjwzNV5ZSHclPG2c1ZwxA7jq4Kvy?=
 =?iso-8859-1?Q?JyF3kJgVKlnfcV7ez4AkNNS73dQKrC+0dCQOJbEsqPgHwJdEXYfc9nrNpm?=
 =?iso-8859-1?Q?LlB0YyTpP+28f0ZE38nrBWSpil22l/WLtu5EJ+m1I2vwg2z+BBNzfe6w?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25b2c81b-1240-4cb4-c936-08da69f62790
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 02:17:58.8365
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jf+OPhiJeAxrfdeYYaJg5aqocdLVqhFFmMFDLl8GsDRpiQxx0RZrAJf3zg2LwoLBaeW1l7R1rR4EuG2zykCRgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3797
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-19_10,2022-07-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207200008
X-Proofpoint-GUID: ibix5kPhnUyqj9TFpZHLQJDvLNNJzzlt
X-Proofpoint-ORIG-GUID: ibix5kPhnUyqj9TFpZHLQJDvLNNJzzlt
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list and removing the linked
list will shrink the vm_area_struct.

Link: https://lkml.kernel.org/r/20220504011345.662299-32-Liam.Howlett@oracl=
e.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-48-Liam.Howlett@orac=
le.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 kernel/events/core.c    | 3 ++-
 kernel/events/uprobes.c | 9 ++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 80782cddb1da..61ad10862c21 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -10210,8 +10210,9 @@ static void perf_addr_filter_apply(struct perf_addr=
_filter *filter,
 				   struct perf_addr_filter_range *fr)
 {
 	struct vm_area_struct *vma;
+	VMA_ITERATOR(vmi, mm, 0);
=20
-	for (vma =3D mm->mmap; vma; vma =3D vma->vm_next) {
+	for_each_vma(vmi, vma) {
 		if (!vma->vm_file)
 			continue;
=20
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 2eaa327f8158..401bc2d24ce0 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -349,9 +349,10 @@ static bool valid_ref_ctr_vma(struct uprobe *uprobe,
 static struct vm_area_struct *
 find_ref_ctr_vma(struct uprobe *uprobe, struct mm_struct *mm)
 {
+	VMA_ITERATOR(vmi, mm, 0);
 	struct vm_area_struct *tmp;
=20
-	for (tmp =3D mm->mmap; tmp; tmp =3D tmp->vm_next)
+	for_each_vma(vmi, tmp)
 		if (valid_ref_ctr_vma(uprobe, tmp))
 			return tmp;
=20
@@ -1231,11 +1232,12 @@ int uprobe_apply(struct inode *inode, loff_t offset=
,
=20
 static int unapply_uprobe(struct uprobe *uprobe, struct mm_struct *mm)
 {
+	VMA_ITERATOR(vmi, mm, 0);
 	struct vm_area_struct *vma;
 	int err =3D 0;
=20
 	mmap_read_lock(mm);
-	for (vma =3D mm->mmap; vma; vma =3D vma->vm_next) {
+	for_each_vma(vmi, vma) {
 		unsigned long vaddr;
 		loff_t offset;
=20
@@ -1983,9 +1985,10 @@ bool uprobe_deny_signal(void)
=20
 static void mmf_recalc_uprobes(struct mm_struct *mm)
 {
+	VMA_ITERATOR(vmi, mm, 0);
 	struct vm_area_struct *vma;
=20
-	for (vma =3D mm->mmap; vma; vma =3D vma->vm_next) {
+	for_each_vma(vmi, vma) {
 		if (!valid_vma(vma, false))
 			continue;
 		/*
--=20
2.35.1