Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>
CC:     Yu Zhao <yuzhao@google.com>
Subject: [PATCH v12 50/69] bpf: remove VMA linked list
Thread-Topic: [PATCH v12 50/69] bpf: remove VMA linked list
Thread-Index: AQHYm97u7uoeB1ISQ0qKMURxiqXmPQ==
Date:   Wed, 20 Jul 2022 02:17:59 +0000
Message-ID: <20220720021727.17018-51-Liam.Howlett@oracle.com>
References: <20220720021727.17018-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220720021727.17018-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?8/nTGjxFh/1pBDMt1zU09tvXghhNGOCfMNvV+zG1XYoYgSkswFhMKr6LXn?=
 =?iso-8859-1?Q?PHNkXouLUj0nI2i3/cr6wKfZyDASq6GhU5LtADoZQI73+TfH8bO7VT6Q1+?=
 =?iso-8859-1?Q?5MYgH43R7GdF5hpl7dmHHJ31E2C+q0xUkiZtGkKkoOBwYIC+60Llgl+v/A?=
 =?iso-8859-1?Q?/ey2pAT8qkf20pKHQIMK5ekq/28EEUh0KZlCka65pbtF+nlzhAK0rGkGK4?=
 =?iso-8859-1?Q?er8ZvcYqQNKdlEtEcRPLHrMFHYIij5LJtVtxUJ30Edw0bxS3SosFMu+iXm?=
 =?iso-8859-1?Q?NVlIvSLPfeicNg5t42+KTtQt+CwGC4Xg5IOe9vHMSZ7uNPBwLYw0llDsSO?=
 =?iso-8859-1?Q?nrmqVilukz6i3jQ1w3aHFR900/u/3GHj3/2PP9kDemas9HOBnj4MvQoPC/?=
 =?iso-8859-1?Q?b4cKUl++0uZvRp3sKjXfPs5Dl+isowKQ4the5Yd0KPSvl+v5tYsgohOd+4?=
 =?iso-8859-1?Q?Lbt9SfsHrUg7j1ohB8knKa53gXfVumaB5NLIuPCxN1Xvks04uHHUeRlxES?=
 =?iso-8859-1?Q?5m8vM7Vtfggxm3ad3igr+SBUUNs5p0Ol5wMe2LTVKue9jSsJw3WRgu9RRX?=
 =?iso-8859-1?Q?RvpCGOePk5eA+Z7fRwyHohcFXF+/Ts7z6ZzAXL6XW7ul900XpwRM7EukEb?=
 =?iso-8859-1?Q?MlxQCuYGdMsoeG5gql9xgebenSZ5Xbj7qkgzRH9yz71A87HVehuz0lMtKv?=
 =?iso-8859-1?Q?XtsBUM+OgQX2FqDdxOnhOF5+EEWZlz+nxEUo2cluo5cadb4r9MMamnCkku?=
 =?iso-8859-1?Q?39I9ClxgSiAj9OR4wFEHaFnaSvuGFXMJ7qrW+KpInQtt/HS/+V9gou6bJL?=
 =?iso-8859-1?Q?/LaCEmKn+3UdOOGAqB7/uw0tsOurskvAigFfYlhjeuH+1wZrLK1YAZBGtF?=
 =?iso-8859-1?Q?cnYq1grIL8cAv8lJlq8vtjwdXW+ORUJ3eBVwEGoKpez8Q4/gh9YS6cYXJF?=
 =?iso-8859-1?Q?rV63015UQLZ5fsF6sQUWsV1u6jL05EUeyrnLzhq9EZbJitRvFGOgJYfIoA?=
 =?iso-8859-1?Q?xvDmLh1fnIFnLTO5qagFZys4cSlC53LGwNSzKkECQtsecToCTuBxDCS87y?=
 =?iso-8859-1?Q?bTwfgRN7iUDq1aMHiSr+RIHxeTwNxPhIVb9N+BfQpzFzGedZkXCN/mFh/Y?=
 =?iso-8859-1?Q?k+nnf3BcgpK2Jf3+Ga8H56wwJ1KdBLoAcWmxcXUaI+wI/4/Yz6VJcGxaCI?=
 =?iso-8859-1?Q?IL6G0Vcng1V/e3nj2ReB8jfzwUNZ0GNujh+f3dX8cVP89VQlFJAVq2vbIN?=
 =?iso-8859-1?Q?NfGhmawnQ/dIjySKyns6ZCu73LTJ1tTxEG2GB4MMUEu+of4LaPMBmlNuOx?=
 =?iso-8859-1?Q?u5ekZPpNCqb2oFFEQs/WSITGB7Futbl5I3RdVE01huNCto4zs6OmIr5sTW?=
 =?iso-8859-1?Q?TygwPSfq+naOlfPG22Sbz3/utraJ/x2Bhoh9E68+Gm0Gt4gINI4Dlx8p+q?=
 =?iso-8859-1?Q?vpChJOvz3yQG8ujq5dMVxVvr7F+fck9G2FBCxU++B9CytZNLllXwZ5WAHG?=
 =?iso-8859-1?Q?lj6BH5XxysrzwDcp/9aXEoThYZFBJD34H/W7PSDhIUhapbn8gC9b6cMPez?=
 =?iso-8859-1?Q?i3UcJNH/pVHHBAw8IWVypMpJaq1lRpfvonsws9CuZGhSOAG9MEyIzZYgAZ?=
 =?iso-8859-1?Q?kBQnBDILaPwm8wTlGkVW7dYqS2asH9EpDwoLuXuJ/WQE5+jxZySRFKGw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e6d0b37-8c10-42ec-1842-08da69f628aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 02:17:59.6645
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LfYofAMKzOjJE29TZxHs5Ec5i0C0SzYe6wJp2FEAz4AKaJXxO//rzFFWGCP61l0fbioyz/Nh9dEI23hfASPdIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3797
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-19_10,2022-07-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207200008
X-Proofpoint-GUID: XEzjk0H61lG_3krEyp75tAWdgV6jnxu5
X-Proofpoint-ORIG-GUID: XEzjk0H61lG_3krEyp75tAWdgV6jnxu5
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Use vma_next() and remove reference to the start of the linked list

Link: https://lkml.kernel.org/r/20220504011345.662299-35-Liam.Howlett@oracl=
e.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-51-Liam.Howlett@orac=
le.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 kernel/bpf/task_iter.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/bpf/task_iter.c b/kernel/bpf/task_iter.c
index 8c921799def4..1c8debd42dc9 100644
--- a/kernel/bpf/task_iter.c
+++ b/kernel/bpf/task_iter.c
@@ -299,8 +299,8 @@ struct bpf_iter_seq_task_vma_info {
 };
=20
 enum bpf_task_vma_iter_find_op {
-	task_vma_iter_first_vma,   /* use mm->mmap */
-	task_vma_iter_next_vma,    /* use curr_vma->vm_next */
+	task_vma_iter_first_vma,   /* use find_vma() with addr 0 */
+	task_vma_iter_next_vma,    /* use vma_next() with curr_vma */
 	task_vma_iter_find_vma,    /* use find_vma() to find next vma */
 };
=20
@@ -400,10 +400,10 @@ task_vma_seq_get_next(struct bpf_iter_seq_task_vma_in=
fo *info)
=20
 	switch (op) {
 	case task_vma_iter_first_vma:
-		curr_vma =3D curr_task->mm->mmap;
+		curr_vma =3D find_vma(curr_task->mm, 0);
 		break;
 	case task_vma_iter_next_vma:
-		curr_vma =3D curr_vma->vm_next;
+		curr_vma =3D find_vma(curr_task->mm, curr_vma->vm_end);
 		break;
 	case task_vma_iter_find_vma:
 		/* We dropped mmap_lock so it is necessary to use find_vma
@@ -417,7 +417,7 @@ task_vma_seq_get_next(struct bpf_iter_seq_task_vma_info=
 *info)
 		if (curr_vma &&
 		    curr_vma->vm_start =3D=3D info->prev_vm_start &&
 		    curr_vma->vm_end =3D=3D info->prev_vm_end)
-			curr_vma =3D curr_vma->vm_next;
+			curr_vma =3D find_vma(curr_task->mm, curr_vma->vm_end);
 		break;
 	}
 	if (!curr_vma) {
--=20
2.35.1