Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <110d78bc-d1f4-0b69-9562-c6758b39279d@canonical.com>
Date:   Tue, 19 Jul 2022 19:29:07 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] apparmor: Mark alloc_unconfined() as static
Content-Language: en-US
To:     Souptick Joarder <jrdr.linux@gmail.com>, paul@paul-moore.com,
        jmorris@namei.org, serge@hallyn.com
Cc:     apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
References: <20220719021218.6807-1-jrdr.linux@gmail.com>
From:   John Johansen <john.johansen@canonical.com>
Organization: Canonical
In-Reply-To: <20220719021218.6807-1-jrdr.linux@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/18/22 19:12, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
> 
> Kernel test robot throws below warning ->
> security/apparmor/policy_ns.c:83:20: warning: no previous prototype
> for function 'alloc_unconfined' [-Wmissing-prototypes]
> 
> Mark it as static.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>

Thanks, I have pulled this into apparmor-next

Acked-by: John Johansen <john.johansen@canonical.com>


> ---
>   security/apparmor/policy_ns.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/policy_ns.c b/security/apparmor/policy_ns.c
> index 300953a02a24..4f6e9b3c24e6 100644
> --- a/security/apparmor/policy_ns.c
> +++ b/security/apparmor/policy_ns.c
> @@ -80,7 +80,7 @@ const char *aa_ns_name(struct aa_ns *curr, struct aa_ns *view, bool subns)
>   	return aa_hidden_ns_name;
>   }
>   
> -struct aa_profile *alloc_unconfined(const char *name)
> +static struct aa_profile *alloc_unconfined(const char *name)
>   {
>   	struct aa_profile *profile;
>