Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>
CC:     Yu Zhao <yuzhao@google.com>
Subject: [PATCH v12 35/69] x86: remove vma linked list walks
Thread-Topic: [PATCH v12 35/69] x86: remove vma linked list walks
Thread-Index: AQHYm97sFCn8keb6BEuCXyMIjt9bLA==
Date:   Wed, 20 Jul 2022 02:17:55 +0000
Message-ID: <20220720021727.17018-36-Liam.Howlett@oracle.com>
References: <20220720021727.17018-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220720021727.17018-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?d4f2fsdbdJh5hXptHq6JiF4FNFxCm5SaYLanhUsWPiAme0JOzV3iQmkGDm?=
 =?iso-8859-1?Q?KwiCvC6zD2lUk3qQ9in+oGRsZjM2qbbbsLdriCBagsrvLQYUwRLERx7+bX?=
 =?iso-8859-1?Q?tdUkSrH5U+D+QHIFbcx8/kHAKK4MaPVSDEJXvbWP8C688auw11B7EhCfZb?=
 =?iso-8859-1?Q?YGNebgNzPzH5OUfeB2HugELNGrk0046zCkP1647/FkdIbhjhcibt0Bmmlz?=
 =?iso-8859-1?Q?Y0OmZpBnp0NS+UMNA+j9CuuP4fA94Y4AXtbnB/MRDGpHlvN79uzb+MOO12?=
 =?iso-8859-1?Q?5mTHsN3+H7iUDII8WgJ90rWqjBpgYd6vjNN8f956APWGRFDH1HUtYEXwgo?=
 =?iso-8859-1?Q?7wm7o+staMs/B8axmMmp8HQw2VX6OcFZ0UlbDT98ch3sJPWVAxBcoxidri?=
 =?iso-8859-1?Q?L9u3CmPoPSvtdUUY9wD28kcb4FC/pYY65Ng2jm4QCz4zAov6EFwgpsuXuZ?=
 =?iso-8859-1?Q?GowoDaDkWRgrKL1xLuk0T4UGgrW2gjsJx6o08AGtL4bvhGWBpvjXfTUAj0?=
 =?iso-8859-1?Q?31am2T92G2qCdq+cMgfQOCJf/PFBLQcBze51dOs6r9x9Dit0pYIDwGuPbx?=
 =?iso-8859-1?Q?8ybnXgWFcp9KXwsgrm0fV/bFQQf4zrtqk7/+cUEnLtjdaQZtYzegtudmJJ?=
 =?iso-8859-1?Q?5bV0m6xT/UPx+2Wr7T1nbsIFeDwxvLIOtzu2uxdgXQXDLmfThetyki8Y9m?=
 =?iso-8859-1?Q?Nlw6J9B01Jl8V7XZZwW9YB/NFpyOZdbb2nfsHvM7V9gjQFq7y9n5V25ocR?=
 =?iso-8859-1?Q?jF14l90Vt6vvHoEbyllOHgKwzuOx6iNlxdeQfc4Gr51AIDrvKIinVLIQVs?=
 =?iso-8859-1?Q?SyR9o/kzFG6PsSkOibmBcELt/8xLh5chEIM+OA6YNJi85yZ5ePV+wbr6mQ?=
 =?iso-8859-1?Q?dohBiwEJbNVjSaOcDAkoJGqhdXiRQNOVn2gBJK7bk0hloudnzRPpvPQ8F2?=
 =?iso-8859-1?Q?tTImznIj/RaS0tRpPeerK6D5VxriVR1FNYhMBzRfcDDHoY2DGH+bhXxnPC?=
 =?iso-8859-1?Q?q6pKeLC1Kp0sba183IAVHYaBICqbt6srn6LSDZH0eALo6Gp3P4gj9KeOeb?=
 =?iso-8859-1?Q?JgW1UWUKbXLzfuGtRBawzYe6Qny4daXocgHWMcs6QZqZPOiIP8G5KH4hlZ?=
 =?iso-8859-1?Q?4tlHHPYKj+Ye1cIm0PWELWo75c58+ZG/LUYsk5fIQvFJQRj5cUuR2ClW1f?=
 =?iso-8859-1?Q?lXsoiNbzqosqwambTvF0ipizAGzSS2WdAhPR2hrgkL+SwlQdtz3wOoSZ8T?=
 =?iso-8859-1?Q?DOBSHC+dpGhnxqTrTxesfhzHJdDaXnJQPtyQ92uONQlXWfrzaQN+pJ2AeL?=
 =?iso-8859-1?Q?U2Yg93mb6zVWZ4qbM5T5iLPlXG9BX4JXXhBwOnQl/s5DcAZ1vywBEPv4k4?=
 =?iso-8859-1?Q?3IQLcqVwacV3K9oi6RnovHhKNs/f6pKLjUl2WkZC0gr+JIi43kr2aXqYbL?=
 =?iso-8859-1?Q?hXsENd1fOvdoM8/FRlqdQjZ2P/AxCam6BztwbgtyoCiBk/Yb9O1IZG3UWt?=
 =?iso-8859-1?Q?fgRfwDM/wjtpuURhR3uyRohzw2/YaNCITimTaoYh/rdQ5KhMeHlBIXZuAC?=
 =?iso-8859-1?Q?1WyW3dfA7fiLR/tWdryIEvwa13iRPS7cNiFm3768fMryvPHxNN3bnHJfB6?=
 =?iso-8859-1?Q?FBY7rdIePysP5LsqAtTdMRP5MUSYPvT2tzGGEs1/RvWReQzLOqC+dUYw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62edf9c4-0ffc-4d30-cbeb-08da69f62412
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 02:17:55.4774
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Tv+af70oPz1/SauLCEBSXufd8W/gNo9hoqrpjX17o4fNtQR/PUd2htaf1NPnh64ca8lqkllTHDWWPB0sUboI2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6316
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-19_10,2022-07-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207200008
X-Proofpoint-GUID: 5JghqJnK17_gQZjEPFSSyK8wboWtg0uw
X-Proofpoint-ORIG-GUID: 5JghqJnK17_gQZjEPFSSyK8wboWtg0uw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

Use the VMA iterator instead.

Link: https://lkml.kernel.org/r/20220504011345.662299-20-Liam.Howlett@oracl=
e.com
Link: https://lkml.kernel.org/r/20220621204632.3370049-36-Liam.Howlett@orac=
le.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
 arch/x86/entry/vdso/vma.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c
index 1000d457c332..6292b960037b 100644
--- a/arch/x86/entry/vdso/vma.c
+++ b/arch/x86/entry/vdso/vma.c
@@ -127,17 +127,17 @@ int vdso_join_timens(struct task_struct *task, struct=
 time_namespace *ns)
 {
 	struct mm_struct *mm =3D task->mm;
 	struct vm_area_struct *vma;
+	VMA_ITERATOR(vmi, mm, 0);
=20
 	mmap_read_lock(mm);
-
-	for (vma =3D mm->mmap; vma; vma =3D vma->vm_next) {
+	for_each_vma(vmi, vma) {
 		unsigned long size =3D vma->vm_end - vma->vm_start;
=20
 		if (vma_is_special_mapping(vma, &vvar_mapping))
 			zap_page_range(vma, vma->vm_start, size);
 	}
-
 	mmap_read_unlock(mm);
+
 	return 0;
 }
 #else
@@ -354,6 +354,7 @@ int map_vdso_once(const struct vdso_image *image, unsig=
ned long addr)
 {
 	struct mm_struct *mm =3D current->mm;
 	struct vm_area_struct *vma;
+	VMA_ITERATOR(vmi, mm, 0);
=20
 	mmap_write_lock(mm);
 	/*
@@ -363,7 +364,7 @@ int map_vdso_once(const struct vdso_image *image, unsig=
ned long addr)
 	 * We could search vma near context.vdso, but it's a slowpath,
 	 * so let's explicitly check all VMAs to be completely sure.
 	 */
-	for (vma =3D mm->mmap; vma; vma =3D vma->vm_next) {
+	for_each_vma(vmi, vma) {
 		if (vma_is_special_mapping(vma, &vdso_mapping) ||
 				vma_is_special_mapping(vma, &vvar_mapping)) {
 			mmap_write_unlock(mm);
--=20
2.35.1