Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Jul 2022 03:22:30 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Helge Deller <deller@gmx.de>
Cc:     Hillf Danton <hdanton@sina.com>, linux-kernel@vger.kernel.org,
        linux-parisc@vger.kernel.org
Subject: Re: WARNING: CPU: 1 PID: 14735 at fs/dcache.c:365
 dentry_free+0x100/0x128
Message-ID: <Ytdm5gk0zvU0pBaG@ZenIV>
References: <20220709090756.2384-1-hdanton@sina.com>
 <20220715133300.1297-1-hdanton@sina.com>
 <cff76e00-3561-4069-f5c7-26d3de4da3c4@gmx.de>
 <20220717113634.1552-1-hdanton@sina.com>
 <0aa365ca-a9f0-8d15-b515-adb8823f5d28@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0aa365ca-a9f0-8d15-b515-adb8823f5d28@gmx.de>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Tue, Jul 19, 2022 at 06:32:04PM +0200, Helge Deller wrote:
> > --- a/fs/dcache.c
> > +++ b/fs/dcache.c
> > @@ -605,8 +605,12 @@ static void __dentry_kill(struct dentry
> >  		spin_unlock(&parent->d_lock);
> >  	if (dentry->d_inode)
> >  		dentry_unlink_inode(dentry);
> > -	else
> > +	else {
> > +		if (unlikely(d_in_lookup(dentry))) {
> > +			__d_lookup_done(dentry);
> > +		}
> >  		spin_unlock(&dentry->d_lock);
> > +	}

Ugh...  If that triggers, we really have a problem.  I don't see any
way for that to happen (well, short of generally fucked refcounting -
stray dput() on wrong address and all bets are off)