Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp5177476imw; Tue, 19 Jul 2022 23:50:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t4VMAGYC7D+tJtYRHUDJW4OQX/wxUfwHF7mLOiRA+EfvQ/NYyD9V/nCzKGG4Y6J1CnNipS X-Received: by 2002:a17:90b:164a:b0:1ee:dd88:f38c with SMTP id il10-20020a17090b164a00b001eedd88f38cmr3713870pjb.62.1658299855584; Tue, 19 Jul 2022 23:50:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658299855; cv=none; d=google.com; s=arc-20160816; b=i4Qq8902jsK/iGg1gyEPA6aO2lBJano3JZj0MOLCMvlcjnPKkNZkpAjsaIMXFS7pdU HhkAMfgOGf3zmSgQzk4RrBTSyNyFXLLt5tJC7GsCHQFoT0LzN2DcqD1opqLoODvpO2rl w/YpRSHCZpZskrV18tQ7IYUTLQmg9To4mP6QMED8R77ZQTOdy3Bpf99JU/z4bY8iAbqN q4EP4iBbG/slzgT/9UL8cHwD3TthRdjxyIUWq4R/8vFBLV7xpqeNrWXanrH5msq5dVP8 gvN67DWSd3OdcHbr0mmTxWMiC876mraA7jlnFOVerfzemin6khv2aFA8hRdQoQ5xwaZN E/XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7IqeYuiLu6+Xuav08/swOcov34IkuSOZgPxCRgHgF1A=; b=o8EcG591F62a0cjBmJHaStXjSQiGr7dbmi0hP5sPWZljB51oxoAEfW+N03odPXBvIs PC59dptg7bL9T9FXU11YVyD4dMlTY5MlirnUluIcsgYSY/CZWRfCA7BX0KAssKhKwFUb Lb/DnfCnx4qKVgOQ8r52znm9HHgQQxHFQhrad0cWYIf71NLTeszzqg4o6pKK2gc9Bc6t 19MNl6X+3f/vCawVj+qJjB2TTwlthimAQG7WLeo3Xk+nvQHqHhewvbX2Gy20B1rKKmit lmWcP3KexthiaZ42CnuzWbQBemu3gZFajVLU3R3VsXwMPkK1wFk5atIyaN0Q27TfYS91 ZklA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=FxNyee6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r190-20020a632bc7000000b0041a4be147b9si5328967pgr.631.2022.07.19.23.50.38; Tue, 19 Jul 2022 23:50:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=FxNyee6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230125AbiGTGsG (ORCPT + 99 others); Wed, 20 Jul 2022 02:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbiGTGsF (ORCPT ); Wed, 20 Jul 2022 02:48:05 -0400 Received: from mail-m974.mail.163.com (mail-m974.mail.163.com [123.126.97.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CF8D62A45; Tue, 19 Jul 2022 23:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=7IqeY uiLu6+Xuav08/swOcov34IkuSOZgPxCRgHgF1A=; b=FxNyee6WML4OsTzd9/Bav YkF2XGxxYGMO20FVE4+wovbolVsO4ZtLsynzzatF2CQ2KYpDKx3RltZ5TQhV/G+w 1FOQjWwP4WkP+v0Mvb8oYA5/JTDf9a3C9flBdh0mw+Nr8PBUZIswoFrI/gKm7sKx y5LMJvjx+/A0XrkMacC3u4= Received: from localhost.localdomain (unknown [112.95.163.118]) by smtp4 (Coremail) with SMTP id HNxpCgCHFb7wpNdiB5iyPg--.76S2; Wed, 20 Jul 2022 14:47:33 +0800 (CST) From: LemmyHuang To: kuba@kernel.org Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, hlm3280@163.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH net-next] tcp: fix condition for increasing pingpong count Date: Wed, 20 Jul 2022 14:47:11 +0800 Message-Id: <20220720064711.16037-1-hlm3280@163.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220719174915.48f830b4@kernel.org> References: <20220719174915.48f830b4@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: HNxpCgCHFb7wpNdiB5iyPg--.76S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjTRvtC7DUUUU X-Originating-IP: [112.95.163.118] X-CM-SenderInfo: pkopjjiyq6il2tof0z/1tbiSAVE+V+Fe-UYrwAAsT X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At 2022-07-20 08:49:15, "Jakub Kicinski" wrote: > On Tue, 19 Jul 2022 21:01:37 +0800 LemmyHuang wrote: >> - if (before(tp->lsndtime, icsk->icsk_ack.lrcvtime) && >> + if ((tp->lsndtime <= icsk->icsk_ack.lrcvtime) && > > Are you sure you don't need to take care of the values wrapping? > before() does that. You may want !after() if you want to allow equal. Yeap, I will switch to that in v2. Thank you!