Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   zengjx95@gmail.com
To:     vitaly.wool@konsulko.com, linmiaohe@huawei.com,
        akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Zeng Jingxiang <linuszeng@tencent.com>
Subject: [PATCH] mm/z3fold: do not unlock in z3fold_page_putback()
Date:   Wed, 20 Jul 2022 14:57:44 +0800
Message-Id: <20220720065744.1006305-1-zengjx95@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: Zeng Jingxiang <linuszeng@tencent.com>

z3fold_page_lock() will lock zhdr->page_lock
1630	z3fold_page_lock(zhdr);

return without unlocking zhdr->page_lock
1634	if (kref_put(&zhdr->refcount, release_z3fold_page_locked))
1635		return;

Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
---
 mm/z3fold.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/z3fold.c b/mm/z3fold.c
index f41f8b0d9e9a..03785832ad47 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -1632,13 +1632,14 @@ static void z3fold_page_putback(struct page *page)
 		list_del_init(&zhdr->buddy);
 	INIT_LIST_HEAD(&page->lru);
 	if (kref_put(&zhdr->refcount, release_z3fold_page_locked))
-		return;
+		goto ret;
 	spin_lock(&pool->lock);
 	list_add(&page->lru, &pool->lru);
 	spin_unlock(&pool->lock);
 	if (list_empty(&zhdr->buddy))
 		add_to_unbuddied(pool, zhdr);
 	clear_bit(PAGE_CLAIMED, &page->private);
+ret:
 	z3fold_page_unlock(zhdr);
 }
 
-- 
2.27.0