Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220705123705.764-1-xuewen.yan@unisoc.com> <20220711174629.uehfmqegcwn2lqzu@wubuntu>
 <YsyO9GM9mCydaybo@slm.duckdns.org> <c1426573-92a7-9f0d-a6b8-aa612248b9a9@redhat.com>
 <Ys41ZF5TmSnLLNRB@slm.duckdns.org>
In-Reply-To: <Ys41ZF5TmSnLLNRB@slm.duckdns.org>
From:   Xuewen Yan <xuewen.yan94@gmail.com>
Date:   Wed, 20 Jul 2022 15:45:27 +0800
Message-ID: <CAB8ipk-8cbur-m733py-cw4bXCt7gkd8gAOXtKO+-fV1B2EeZw@mail.gmail.com>
Subject: Re: [PATCH] sched/schedutil: Fix deadlock between cpuset and cpu
 hotplug when using schedutil
To:     Tejun Heo <tj@kernel.org>
Cc:     Waiman Long <longman@redhat.com>,
        Qais Yousef <qais.yousef@arm.com>,
        Xuewen Yan <xuewen.yan@unisoc.com>, rafael@kernel.org,
        viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org,
        ke.wang@unisoc.com, xuewyan@foxmail.com, linux-pm@vger.kernel.org,
        Lukasz Luba <Lukasz.Luba@arm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dear all

On Wed, Jul 13, 2022 at 11:20 AM Tejun Heo <tj@kernel.org> wrote:
>
> On Tue, Jul 12, 2022 at 10:49:57PM -0400, Waiman Long wrote:
> > > Well, the only thing I can think of is always grabbing cpus_read_lock()
> > > before grabbing threadgroup_rwsem. Waiman, what do you think?
> >
> > That is a possible solution as cpus_read_lock() is rather lightweight. It is
> > a good practice to acquire it first.
>
> On a similar note, I think we probably should re-enable percpu operations on
> threadgroup_rwsem too by default and allow users who are affected by slower
> write path operations to opt-in. After the new CLONE_INTO_CGROUP which
> doesn't need the rwsem, we have far fewer write lockers after all.
>

 If there's any patch for me to try? I would be very grateful.

Thanks!

---
xw.yan