Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220720072346.33511-1-dzm91@hust.edu.cn> <604f2d3f-659c-3312-d69f-c133aec275ca@wanadoo.fr>
In-Reply-To: <604f2d3f-659c-3312-d69f-c133aec275ca@wanadoo.fr>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Wed, 20 Jul 2022 15:56:16 +0800
Message-ID: <CAD-N9QUKWsRHWme+fQ8KtBXKFB=cU8spa0eu3u4iVXuOE3x5cw@mail.gmail.com>
Subject: Re: [PATCH] usb: trancevibrator: simplify tv_probe
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     =?UTF-8?B?5oWV5Yas5Lqu?= <dzm91@hust.edu.cn>,
        Greg KH <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 20, 2022 at 3:46 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 20/07/2022 =C3=A0 09:23, Dongliang Mu a =C3=A9crit :
> > From: Dongliang Mu <mudongliangabcd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane=
.org>
> >
> > The function tv_probe does not need to invoke kfree when the
> > allocation fails. So let's simplify the code of tv_probe.
> > Another change is to remove a redundant space.
> >
> > Signed-off-by: Dongliang Mu <mudongliangabcd-Re5JQEeQqe8AvxtiuMwx3w@pub=
lic.gmane.org>
> > ---
> >   drivers/usb/misc/trancevibrator.c | 13 +++----------
> >   1 file changed, 3 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/tranc=
evibrator.c
> > index 26baba3ab7d7..30d4d774d448 100644
> > --- a/drivers/usb/misc/trancevibrator.c
> > +++ b/drivers/usb/misc/trancevibrator.c
> > @@ -84,29 +84,22 @@ static int tv_probe(struct usb_interface *interface=
,
> >   {
> >       struct usb_device *udev =3D interface_to_usbdev(interface);
> >       struct trancevibrator *dev;
> > -     int retval;
> >
> >       dev =3D kzalloc(sizeof(struct trancevibrator), GFP_KERNEL);
> > -     if (!dev) {
> > -             retval =3D -ENOMEM;
> > -             goto error;
> > -     }
> > +     if (!dev)
> > +             return -ENOMEM;
> >
> >       dev->udev =3D usb_get_dev(udev);
> >       usb_set_intfdata(interface, dev);
> >
> >       return 0;
>
> Hi,
>
> looks like:
>
> error:
>         kfree(dev);
>         return retval;
>
> at the end of the function can be removed as-well.
>

My patch actually removes them.

> Just my 2c.
>
> CJ