Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3bd9817d-1959-c081-e5d0-8b0e70b3f41e@huawei.com>
Date:   Wed, 20 Jul 2022 09:39:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: faddr2line issue
To:     Josh Poimboeuf <jpoimboe@kernel.org>
CC:     <keescook@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <09df26a9-27af-1276-34c6-820bf7e27da8@huawei.com>
 <3492d341-a681-f344-f5cd-5b1ea3725f31@huawei.com>
 <20220714164136.n2ycc5axt7vtctgs@treble>
 <64da0019-4816-a409-be93-b1cf7021c584@huawei.com>
 <20220720000654.yospyvbrfliy3lrn@treble>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <20220720000654.yospyvbrfliy3lrn@treble>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/07/2022 01:06, Josh Poimboeuf wrote:
>> So adding config DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT to v5.19-rc2 got it
>> working again for me on arm64. However commit dcea997beed6 ("faddr2line: Fix
>> overlapping text section failures, the sequel") seems to be broken for me,
>> below - this first appeared in rc3. Any idea what the issue could be?
>>
>> $./faddr.sh hisi_sas_sata_done+0x8/0x38
>> hisi_sas_sata_done+0x8/0x38:
>> fs mm ??:0
> Hm, what does faddr.sh do? 

ah, it's just a wrapper to call scripts/faddr2line with vmlinux and $1 
(being hisi_sas_sata_done+0x8/0x38, above) args

> Does addr2line also fail?

faddr2line fails, as below.

> 
> Can you run
> 
>    bash -x scripts/faddr2line <vmlinux or .ko file> hisi_sas_sata_done+0x8/0x38
> 
> and share the output?

on rc3 we get:

https://raw.githubusercontent.com/hisilicon/kernel-dev/private-topic-sas-5.19-faddr2line-linux-rc3/before2

With dcea997beed6 reverted on rc3:

https://raw.githubusercontent.com/hisilicon/kernel-dev/private-topic-sas-5.19-faddr2line-linux-rc3/after2

This is my branch is you want to see what I have:
https://github.com/hisilicon/kernel-dev/commits/private-topic-sas-5.19-faddr2line-linux-rc3

Thanks,
John