Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220720072152.3894559-1-maobibo@loongson.cn>
In-Reply-To: <20220720072152.3894559-1-maobibo@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Wed, 20 Jul 2022 17:00:54 +0800
Message-ID: <CAAhV-H6tdimtT4P6LTaR7iMbL9ChF5_RDEFZPZvm-gQrtTotMA@mail.gmail.com>
Subject: Re: [PATCH 1/2] LoongArch: Remove clock setting during cpu hotplug stage
To:     Bibo Mao <maobibo@loongson.cn>
Cc:     WANG Xuerui <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        loongarch@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Bibo,

This series looks good to me, but I want to wait for some time to see
if others have comments. Thanks.

Huacai

On Wed, Jul 20, 2022 at 3:22 PM Bibo Mao <maobibo@loongson.cn> wrote:
>
> On physical machine we can save power by disabling clock of hot removed cpu.
> However there will be problem, since different platforms have different clock
> setting methods, the code is platform relative. Also it can be in firmware/pmu
> compoments or cpu regulator driver, rather than general loongarch cpu booting
> flow.
>
> Also on qemu virt machine, device clock/freq setting is not
> emulated, there is no such registers.
>
> This patch removes hard-coded register accessing in generic
> loongarch cpu boot flow.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>  arch/loongarch/kernel/smp.c | 29 -----------------------------
>  include/linux/cpuhotplug.h  |  1 -
>  2 files changed, 30 deletions(-)
>
> diff --git a/arch/loongarch/kernel/smp.c b/arch/loongarch/kernel/smp.c
> index 73cec62504fb..98b3e059d344 100644
> --- a/arch/loongarch/kernel/smp.c
> +++ b/arch/loongarch/kernel/smp.c
> @@ -359,35 +359,6 @@ void play_dead(void)
>         play_dead_uncached(state_addr);
>  }
>
> -static int loongson3_enable_clock(unsigned int cpu)
> -{
> -       uint64_t core_id = cpu_data[cpu].core;
> -       uint64_t package_id = cpu_data[cpu].package;
> -
> -       LOONGSON_FREQCTRL(package_id) |= 1 << (core_id * 4 + 3);
> -
> -       return 0;
> -}
> -
> -static int loongson3_disable_clock(unsigned int cpu)
> -{
> -       uint64_t core_id = cpu_data[cpu].core;
> -       uint64_t package_id = cpu_data[cpu].package;
> -
> -       LOONGSON_FREQCTRL(package_id) &= ~(1 << (core_id * 4 + 3));
> -
> -       return 0;
> -}
> -
> -static int register_loongson3_notifier(void)
> -{
> -       return cpuhp_setup_state_nocalls(CPUHP_LOONGARCH_SOC_PREPARE,
> -                                        "loongarch/loongson:prepare",
> -                                        loongson3_enable_clock,
> -                                        loongson3_disable_clock);
> -}
> -early_initcall(register_loongson3_notifier);
> -
>  #endif
>
>  /*
> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> index 19f0dbfdd7fe..b66c5f389159 100644
> --- a/include/linux/cpuhotplug.h
> +++ b/include/linux/cpuhotplug.h
> @@ -130,7 +130,6 @@ enum cpuhp_state {
>         CPUHP_ZCOMP_PREPARE,
>         CPUHP_TIMERS_PREPARE,
>         CPUHP_MIPS_SOC_PREPARE,
> -       CPUHP_LOONGARCH_SOC_PREPARE,
>         CPUHP_BP_PREPARE_DYN,
>         CPUHP_BP_PREPARE_DYN_END                = CPUHP_BP_PREPARE_DYN + 20,
>         CPUHP_BRINGUP_CPU,
> --
> 2.31.1
>
>