Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Jul 2022 13:33:28 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     zengjx95@gmail.com
Cc:     mingo@redhat.com, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org,
        Zeng Jingxiang <linuszeng@tencent.com>
Subject: Re: [PATCH] kernel/sched/cputime: Fix unused value in
 cputime_adjust()
Message-ID: <YtfoCAKfV8PXQz5h@worktop.programming.kicks-ass.net>
References: <20220720102956.1141634-1-zengjx95@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220720102956.1141634-1-zengjx95@gmail.com>
Precedence: bulk

On Wed, Jul 20, 2022 at 06:29:56PM +0800, zengjx95@gmail.com wrote:
> From: Zeng Jingxiang <linuszeng@tencent.com>
> 
> Coverity warns uf an unused value:
> 
> assigned_value: Assign the value of the variable rtime to utime here,
> but that stored value is overwritten before it can be used.
> 568	if (stime == 0) {
> 569		utime = rtime;
> 570		goto update;
> 571	}
> 
> value_overwrite: Overwriting previous write to utime with
> the value of expression rtime - stime.
> 592	utime = rtime - stime;

Coverity is being daft, the compiler has a dead-store-elimination pass.

This way the code is more consistent / easier to ready.