Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp5386649imw; Wed, 20 Jul 2022 04:55:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uIu81SrERci4mqaljUJPGvHR+ZC2wmHOU08q9BAjk3j18kfi4sCtwiafC8iR8jBOY99VDX X-Received: by 2002:a17:90b:4c8c:b0:1ef:bff6:c964 with SMTP id my12-20020a17090b4c8c00b001efbff6c964mr4964358pjb.36.1658318110669; Wed, 20 Jul 2022 04:55:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658318110; cv=none; d=google.com; s=arc-20160816; b=qnSMlROU2EjV2mUGZ/WFyimhc1c77hD22MebY+gQt/OsZT4CIvkdVED/kNlD22RhdA ze6EGy665B1dZrqvt0DgyV0kr/mnflZe+tKuK6cgQGrCEkIljPQXgSBZcPvM8M3zLqzU w6DyzJgtp1rmWtPyNyadC4kEpSIm8zmdFL7es3WzL0Ce145hXyByMY9WEhPabDVaFZnm epUHXl/ziCcofDKPd5vnGZpA3izFjhF1iSIebU0a/lUPKEs3EJEkECJYoHZTcJOYktNn kcrf1z32bzxPFbC6vO432EyoFeydF8tOr3E/8M/Cg4i0keqL8Qgwh2ZrN93RL84NeQgt m7eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=G5tDrsT2sWzYk3Hji+KyAgj0z5FZBjNVpsVxlTCfyRU=; b=AD80O4McsYA6CFJ+4TVAUB9zKYRppoR/Ern1YwL6GZ+O5BH+5j0kf+8/3w9zvhHVuG 8/EOgL0Bgp3PXIIsd2yUMt445r7mw0neNOzGCuSm9TXrgXVP+vx0TlNjlXIj2sk8QMVb UTca4RAwdcf33lqzlSUlKbOvUz0ZBd9Yes1zHkp1m25ipeAcmKCE730YIpq46RIKNB9K oPf0MaedkIfok+oM1ES5HzLeFvAuHy2XE6GRJLU7J6Z1pTp/V8a9Hd6AdjG69VsuUh2d Un4LyrFoyxU+jRwTQGTsnek4py4thKROVxXSh91t13tEw8bW4sHl4x2Z6/3srj0TwKVP 9m2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=o8Ka6MQe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r27-20020a635d1b000000b0040d5dc5b896si2240033pgb.519.2022.07.20.04.54.56; Wed, 20 Jul 2022 04:55:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=o8Ka6MQe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232294AbiGTLvf (ORCPT + 99 others); Wed, 20 Jul 2022 07:51:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbiGTLve (ORCPT ); Wed, 20 Jul 2022 07:51:34 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBC5357206; Wed, 20 Jul 2022 04:51:31 -0700 (PDT) Received: from zn.tnic (p200300ea97297623329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9729:7623:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 426401EC04D6; Wed, 20 Jul 2022 13:51:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1658317886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=G5tDrsT2sWzYk3Hji+KyAgj0z5FZBjNVpsVxlTCfyRU=; b=o8Ka6MQersjBulW1eATTQ3ok9Y+q3VT63ez33EzV6yUOr4O4rAcqxO3cZOCXqMPFNzE4pg +Ne2jrxAoKgxFcPKjWLNiZ6c+hxxz0aCvTF0kuCddVJTLfexDj0VzZ4T8vXaTCu8iYXd/t arsTveHiAJ212DDda3ZyxOGleUbwJ7Y= Date: Wed, 20 Jul 2022 13:51:21 +0200 From: Borislav Petkov To: Toshi Kani Cc: rrichter@marvell.com, mchehab@kernel.org, elliott@hpe.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Subject: Re: [PATCH] EDAC/ghes: Fix buffer overflow in ghes_edac_register() Message-ID: References: <20220719220124.760359-1-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220719220124.760359-1-toshi.kani@hpe.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 04:01:24PM -0600, Toshi Kani wrote: > The following buffer overflow BUG was observed on an HPE system. > ghes_edac_register() called strlen() on an uninitialized label, > which had non-zero values from krealloc_array(). > Change dimm_setup_label() to always initialize the label. Do we also know why dmi_memdev_name() doesn't give bank and/or device? SMBIOS handle wrong? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette