Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp5457509imw; Wed, 20 Jul 2022 06:13:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vtTBxhJEanrfdhG+pYsAV+dX/MxLdrx7l4dNNieQQH2eyYlfmf7ibxFQ2uDC8tSlKuXMe1 X-Received: by 2002:a92:8748:0:b0:2d9:3f81:d0b7 with SMTP id d8-20020a928748000000b002d93f81d0b7mr18009879ilm.310.1658322826157; Wed, 20 Jul 2022 06:13:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658322826; cv=none; d=google.com; s=arc-20160816; b=grRAn03/ksqKiNwVqltNLs/oEVD1cvV0vMUG0ch2vKy6hHIcHJR9dnRh/3w2gzeN4M 7+7XbR1vKSvRPQHVm4u6P0izuNVviRuBK/eL79uBtu9n6JfgDsCT5lsdTkCzmOyE7srJ gkDhKOGA32JEqZL3hc+Yp3zR2Th/olTIymWWH+gwVK1Esnze5/jb1O+x5cPWvURaG4lK 5ms4S1E0ENU+SZkoWDixnkttk+2+83bxHOUP9BW7b0Ya6yC6SWR2nItucb/F2QGpCPMC hONg/k1b8qHwrqL3XDMzWtfk2NSdSIKNOcSliv9/6yoLtwIrYzPRCuDjIGCZoW4/CDpz zD2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=uIYaOKnGTI6IaoJhWifZ4SiRGVTMle5OSaSjE78z0Pg=; b=l2M+NTSo5ARNAGRYjSrg+CtioJb96Y6WChy0YUiKoZOb54woj3Po0rTn+3WFnB4qgn RE+NoA+VdwK0NFvK6Stz2FuyLI1DSNq1k62cVq4fQ95oTZCr636GPn0yEr5LqhewNwsE B17hufMFot7hq5q/L/Qf6g/ob4LFhfjppd45ZmUC97dC2YnkUcbmSwYnWkVTaL0L1LbH Tm/GDWtUECKWPEJ5ygstFDzD6BZKCskqO2Mn78Q7DYx1Hb2hNn1CrW+g0iDVADgtJ1Wv xR3f3s4JBnrzBu7fPjzrubanA5NXZVo4au+ZVRwr6v0Xd/DdGoXH0M5UYINe5kGEpd4T Qvhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=wvdTKSub; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a8-20020a5d9588000000b0067badd50ba4si15444112ioo.33.2022.07.20.06.13.32; Wed, 20 Jul 2022 06:13:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=wvdTKSub; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240561AbiGTMe0 (ORCPT + 99 others); Wed, 20 Jul 2022 08:34:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240392AbiGTMeX (ORCPT ); Wed, 20 Jul 2022 08:34:23 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A2EB4C604 for ; Wed, 20 Jul 2022 05:34:21 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id m16so23540380edb.11 for ; Wed, 20 Jul 2022 05:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uIYaOKnGTI6IaoJhWifZ4SiRGVTMle5OSaSjE78z0Pg=; b=wvdTKSubSEHMIv5MXsfGa0LD1H1qK+hEz5plUx6Hma+J7WYlLzVf3zAgymt+yt/oOV SbgmpahLzVtQjxqC2A+GK+L+KrBqoCPvW5HLxLIwBQ0aMKBzl/07sYbwp72mC7jYP9og HFGvNobDRVc0cAT3KXcb8yhOsVwbBS/nouHsPTWnM4wR6evw0cTryoNlr3tbrwP93u7R iQSnYWDQkFsXhTMBihJbOSXJezhsz1hv4QH/U/xiDJOpv8VJ/fUEkKGui1J4jR4DLC0J xHFXhGFnRWapPf4ceBZ1qL3Tb8KJgksIbzJtibds1veIzbDKZPYSUembLDemmtI8duXd /uRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uIYaOKnGTI6IaoJhWifZ4SiRGVTMle5OSaSjE78z0Pg=; b=JFgfuHlnGexzqH/WycXva9UbKNl/LJ0qHhTq9vClOe2aHlFpQl87/X4Uo6N3QIB0l+ vbIHM21vOP+sotEQamHbwVzepnkjEmUjJTXOODJrGdxQoSElaKf6IEPvuG/Udg4dmVJo YH+ivDNrCdlug1ND9NcYXbSYo1+WuLU1h8lfNtnMkeVPDg1Cb98sReQW9TOZn0O/AukF O606WyNuxrI3PWfWPb8eCB+5gAZWBACy3mMlggQ3Hm20c1ALwQvhEIvKbzndxVV3xfvD SF7jlgsA5YAT8p6sO/1JL3Ys9sLtg3M6dbjKJQbbjhhR7NzQ90nTHL5CFeVtMG815P4S 6BbQ== X-Gm-Message-State: AJIora9j6hLA2Bd6RmGu27BmP91UnYdlPVSoDuaINxXBE/TBHnvS2j1I p64KW8J5K7D/jEXyFhA+wWjFD1M1rC0iWqZPT8gJFQ== X-Received: by 2002:a05:6402:26d6:b0:43a:daa5:9f12 with SMTP id x22-20020a05640226d600b0043adaa59f12mr49599534edd.408.1658320460114; Wed, 20 Jul 2022 05:34:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bartosz Golaszewski Date: Wed, 20 Jul 2022 14:34:09 +0200 Message-ID: Subject: Re: [PATCH v4 5/6] gpio: 104-idi-48: Implement and utilize register structures To: William Breathitt Gray Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , John Hentges , Jay Dolan Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 5:14 PM William Breathitt Gray wrote: > > Reduce magic numbers and improve code readability by implementing and > utilizing named register data structures. The 104-IDI-48 device features > an Intel 8255 compatible GPIO interface, so the i8255 GPIO module is > selected and utilized as well. > > Reviewed-by: Linus Walleij > Cc: John Hentges > Cc: Jay Dolan > Signed-off-by: William Breathitt Gray > --- William, This patch doesn't apply to my gpio/for-next branch. Would you mind rebasing your series on top of it? Thanks! Bart