Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Charl Liu <charl.liu@bayhubtech.com>
To:     adrian.hunter@intel.com, ulf.hansson@linaro.org,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     shaper.liu@bayhubtech.com, chevron.li@bayhubtech.com,
        thomas.hu@bayhubtech.com, xiaoguang.yu@bayhubtech.com,
        shirley.her@bayhubtech.com
Subject: [PATCH V1 1/1] mmc:sdhci:Fix the SD tuning CMD parameter issue that the SDHCI_TRANSFER_MODE is cleared from read direction to write direction incorrectly
Date:   Wed, 20 Jul 2022 05:37:37 -0700
Message-Id: <20220720123737.117-1-charl.liu@bayhubtech.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?//k45XTWJd8t9MbjTBQTSjo66WwXg1Q0S9Kgz6hxk/syd4hLcGQlUmRAAiHN?=
 =?us-ascii?Q?w+5Y35CJ13U27pakKINC1zEpfWdsXe/bmB+HjZPkPKWkmeRAHzocknmMxTAS?=
 =?us-ascii?Q?bwXBteNfx5iAf1rStoW9ymXkVFT8LMAAVVEg9DocAiAikeKvD+BKVMWYP0cv?=
 =?us-ascii?Q?BaFb40Ad/Lih7WFg4R/yzG4f9UavkWdP2RbQkJCiVNCGaSI4JO5QC+vSpKfH?=
 =?us-ascii?Q?CGYHhA3nhK/bcs9g6Kq6AHweSHpEi5nGXsHpN/hwmPFZBpgwKl6PT4ov3Ocv?=
 =?us-ascii?Q?ek8jGR+Qi4an6+DonKVEySuqHgwwPAv9DtZuDy75O6vGZnktl1fk6bNVhVlQ?=
 =?us-ascii?Q?MLOOiR8Gn0MXlDUcCCy05DGHvMHBeTR8isP/7lLF4nBiyph2GhmNN5c9xUCr?=
 =?us-ascii?Q?h6ZDvaOb8zMvO2R6wFfTHiXJmnsnkZK4wrMgj4RjbVOyavB1ICsaWEGDIqiy?=
 =?us-ascii?Q?ILEMkKYkrxnEBjq+agahE8A2hnKUAW0xcajPiBxxWS4xtqeyQP7azkSzzSAO?=
 =?us-ascii?Q?7VyXQztZvkP6U0TAYhuy4aPAKwsLWMBdvX9C8xkKH92v26krULtWPbCWqwg1?=
 =?us-ascii?Q?mLDEd+BTRjGD3ltssZ4Gzq5/XBdjeM6XyNaYO3gN4plUxX+KVAtYi9D52Qp0?=
 =?us-ascii?Q?eWAhktjgivohJbLq+FNEpkrk4lYLfSipIzSauObUNqgx2dGlV8qbOxSbjov1?=
 =?us-ascii?Q?VTeeZhY2t1hFEatkwgKh7n8Ca1wk+jLjIJCkSc+JC6/gzeCLNMoy8L040OkS?=
 =?us-ascii?Q?7KSoufLnWM1M9Bj/yFoX90YJVKRk4iT0W+1EPyCvUijBNTRg5IAGyhovtA2C?=
 =?us-ascii?Q?JFDcCouZPN+uMW67+eNg/EqFhAm0UPnCnNk6aADnEL3vS0WwJMM45/IdasoP?=
 =?us-ascii?Q?ve6qC7aSj7b+xKec8IiWjVUH4qYui822jlX3JgQ0Sdv0G9fqsZJUx7/ISXFM?=
 =?us-ascii?Q?ugXnNZsQNFAPuU/aixbRyQnIL2y+mMQGv0m02cMX66xhK/SyHzfJoc4yMAmR?=
 =?us-ascii?Q?+7iU8tEnr87Y2TvrjnvVXInDixjQ1RnaOjNPoTus95rlRwsvI4uBb7bmpm4x?=
 =?us-ascii?Q?t6f2UEhB4j5SDYIHMtgX2J33kbFj6PO2BnA4VBz6u1ZC+5G7jhAJiTP9Q3+s?=
 =?us-ascii?Q?o8OhjOsMP7P50OyiHnv3HQ3lisq8zdwJw0msDwp9Xi+qfe4z+p5UmqUjRYzr?=
 =?us-ascii?Q?AGQ7m8t15bQZVpz7VW532A/d+MjKLFTMdGw7UkfEqiD5hMWZBMF6drG5nPQC?=
 =?us-ascii?Q?+im3HfWUh3ob5fIQ1T77kkFxh50lT2R/E8QglzYa3kpZZJVkRFcQFLaIHjY3?=
 =?us-ascii?Q?gZUrUldcrTUsELheIbtKm9KYFBMLRjczH3UNeDdXtR2gcW7MbBNo1qUL0wLC?=
 =?us-ascii?Q?5dTud8tLpDurPmUnq8OANH/bCl4MehbAlaVaRpeX9DQQGn1JAVg9qtbpfD8B?=
 =?us-ascii?Q?T7gOwbQ91XhLTSiTbsYGxAap4MGj+4Bk2kkXkxbjtNfQI7HoLQf4bsW5q6z8?=
 =?us-ascii?Q?Y9XwE0SqMHcHOBgdAHQjQTbdESUdEXBsMacwwI96dhUXOIeCJB7d38pjtM72?=
 =?us-ascii?Q?UpJ80EzUcEXgoqemftj48+OUN9kLlHNBgxTz+/TbFgW4QI2foESQOoYRCJTf?=
 =?us-ascii?Q?IgU4e8Rp8niuRSpLWjXqUj8Ag2+z1+L7mTtLp0bd1o+D1MIG3BDsChD6Tjmu?=
 =?us-ascii?Q?C6FVkQ=3D=3D?=
X-OriginatorOrg: bayhubtech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4ba0dfa-bfda-4a62-545c-08da6a4ca99b
X-MS-Exchange-CrossTenant-AuthSource: MN2PR16MB2781.namprd16.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 12:37:52.5371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0a7aae2b-8f2e-44df-ba2f-42de7f93c642
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TMtwsd4KfLnVGdk5WLjrDoVSZkp05ZOQRHv6p9IDid+zV8EhYmTb4OZp6bmxTLzhPQlvfZoQLf5VNoTjFQuGIQjJ2M1K+qCYpMqi+C/dsr0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1601MB1273
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When cmd->opcode == MMC_SEND_TUNING_BLOCK, the SDHCI_TRANSFER_MODE
should also be kept

Signed-off-by: Charl Liu <charl.liu@bayhubtech.com>
---
Change in V1:
Keeping the SDHCI_TRANSFER_MODE when cmd->opcode == MMC_END_TUNING_
BLOCK
---
 drivers/mmc/host/sdhci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 22152029e14c..6a0f6725dadb 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1430,7 +1430,8 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host,
 		if (host->quirks2 &
 			SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD) {
 			/* must not clear SDHCI_TRANSFER_MODE when tuning */
-			if (cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200)
+			if ((cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200) &&
+			(cmd->opcode != MMC_SEND_TUNING_BLOCK))
 				sdhci_writew(host, 0x0, SDHCI_TRANSFER_MODE);
 		} else {
 		/* clear Auto CMD settings for no data CMDs */
-- 
2.32.0