Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1658324498.git.william.gray@linaro.org>
In-Reply-To: <cover.1658324498.git.william.gray@linaro.org>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Wed, 20 Jul 2022 17:47:35 +0200
Message-ID: <CAMRc=MfSap-FNM0zXEcRBD6KJRTE-yqYnjJ+X_MuKuKma=FSFQ@mail.gmail.com>
Subject: Re: [RESEND PATCH v4 0/6] gpio: Implement and utilize register
 structures for ISA drivers
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        John Hentges <jhentges@accesio.com>,
        Jay Dolan <jay.dolan@accesio.com>,
        Fred Eckert <Frede@cmslaser.com>,
        Paul Demetrotion <pdemetrotion@winsystems.com>,
        techsupport@winsystems.com,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 20, 2022 at 3:46 PM William Breathitt Gray
<william.gray@linaro.org> wrote:
>
> Rebased onto the gpio/for-next branch.
>
> Changes in v4:
>  - Cleanup superfluous header includes from drivers
>  - Add note to CONFIG_GPIO_I8255 Kconfig that if built as a module the
>    name will be 'gpio-i8255'
>  - Remove 'const' from '__iomem' pointers
>  - Replace ambiguous 'group' terminology with more understandable 'bank'
>  - Use more natural '>= 4' expression to represent upper nibble
>  - Refactor i8255_set_port() to take more common pattern of mask and
>    bits
>
> The PC104/ISA drivers were updated to use I/O memory accessor calls such
> as ioread8()/iowrite8() in a previous patch series [0]. This
> patchset is a continuation of the effort to improve the code readability
> and reduce magic numbers by implementing and utilizing named register
> data structures.
>
> One of the benefits is that we can now observe more easily similarities
> in devices that share similar interfaces; such as the i8255 interfaces
> used by the 104-DIO-48E, 104-IDI-48, and GPIO-MM drivers -- as well as
> the similar interface used by the 104-IDIO-16 and PCI-IDIO-16 drivers.
>
> A new module supporting the Intel 8255 interface is introduced to
> consolidate the common code found among the 104-DIO-48E, 104-IDI-48, and
> GPIO-MM drivers.
>
> [0] https://lore.kernel.org/all/cover.1652201921.git.william.gray@linaro.org/
>

Series applied, thanks!

Bart