Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbXFCViR (ORCPT ); Sun, 3 Jun 2007 17:38:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750827AbXFCViI (ORCPT ); Sun, 3 Jun 2007 17:38:08 -0400 Received: from smtp-out.google.com ([216.239.45.13]:63245 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbXFCViH (ORCPT ); Sun, 3 Jun 2007 17:38:07 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:message-id:date:from:to:subject:cc:in-reply-to: mime-version:content-type:content-transfer-encoding: content-disposition:references; b=phuBk4tdBjeHeKdtrQIdUn3PL6WlTFFfSk+Un0wbmayJDusvNBtc0zE/7blMEqOZz aJWjMkQTAx2/8C/2MyPuw== Message-ID: Date: Sun, 3 Jun 2007 14:38:00 -0700 From: "Tim Hockin" To: "Robert P. J. Day" Subject: Re: Kconfig variable "COBALT" is not defined anywhere Cc: "Roland Dreier" , "Randy Dunlap" , "Linux Kernel Mailing List" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070603132309.508738b7.randy.dunlap@oracle.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2490 Lines: 59 I think the nvram is the only place left that uses CONFIG_COBALT On 6/3/07, Robert P. J. Day wrote: > On Sun, 3 Jun 2007, Tim Hockin wrote: > > > There were other patches which added more COBALT support, but they > > were dropped or lost or whatever. > > > > I would not balk at having that code yanked. I never got around to > > doing proper Cobalt support for modern kernels. :( > > > > On 6/3/07, Roland Dreier wrote: > > > > > > there is no Kconfig file which defines the selectable option > > > > > > "COBALT", which means that this snippet from drivers/char/nvram.c: > > > > > > > > > > > > # if defined(CONFIG_COBALT) > > > > > > # include > > > > > > # define MACH COBALT > > > > > > # else > > > > > > # define MACH PC > > > > > > # endif > > > > > > never evaluates to true, therefore making > > > > > > fairly useless, at least under the circumstances. > > > > > > > > Maybe it should be MIPS_COBALT ? > > > > > > > that's the first thing that occurred to me, but that header file is > > > > copyright sun microsystems and says nothing about MIPS, so that didn't > > > > really settle the issue. that's why i'd rather someone else resolve > > > > this one way or the other. > > > > > > Actually, looking through the old kernel history, it looks like this > > > was added by Tim Hockin's (CCed) patch "Add Cobalt Networks support to > > > nvram driver". Which added this to drivers/cobalt: > > > > > > +bool 'Support for Cobalt Networks x86 servers' CONFIG_COBALT > > > > > > I guess Tim can clear up what's intended... > > ok, that sounds like it might be a bigger issue than just a dead > CONFIG variable. if that's all it is, i can submit a patch. if it's > more than that, i'll leave it to someone higher up the food chain to > figure out what cobalt-related stuff should be yanked. > > rday > -- > ======================================================================== > Robert P. J. Day > Linux Consulting, Training and Annoying Kernel Pedantry > Waterloo, Ontario, CANADA > > http://fsdev.net/wiki/index.php?title=Main_Page > ======================================================================== > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/