Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eric Snowberg <eric.snowberg@oracle.com>
To:     torvalds@linux-foundation.org
Cc:     linux-integrity@vger.kernel.org, zohar@linux.ibm.com,
        dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, john.haxby@oracle.com,
        eric.snowberg@oracle.com
Subject: [PATCH v2 1/1] lockdown: Fix kexec lockdown bypass with ima policy
Date:   Wed, 20 Jul 2022 12:40:27 -0400
Message-Id: <20220720164027.3697950-2-eric.snowberg@oracle.com>
In-Reply-To: <20220720164027.3697950-1-eric.snowberg@oracle.com>
References: <20220720164027.3697950-1-eric.snowberg@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EPH/npc3un43ucUHbUMNe9TQpkOSmOUrhmJuJsF4V6sD1Nxk7j+CPWh4m+w7?=
 =?us-ascii?Q?fLxYmP5b4pEMASl7PA2XDN+LCRcSlsT5xhy8pNuNfEgNDxM/i2zSjAOC88uQ?=
 =?us-ascii?Q?FPq+08Ns7Z4370HjKQdMZExFjoXQiM/B4dHPFwVVXKyD6XovdEUQ3QkfXEx+?=
 =?us-ascii?Q?L3uK9+S7K9E4NZuJBC/rrz8jr0x+FzII2delhmE45PKavc4q6sxzCW61nuXd?=
 =?us-ascii?Q?nfZmMoCaDhgDLZdTja84I0Q44+ZevR2VqkHFe3W2f0TNBmohU4cpG6fkfk0S?=
 =?us-ascii?Q?xf0rmfI4UmrGKXifNiQe+wc9T35DX/GdU8JtTTfKeBQC2dXw3VYyF2257Bkj?=
 =?us-ascii?Q?Wtkg5DbnJGsdQY4ngySD+WWk31hnGpNXZeU8EecNME17Lw3oq8ynYAiwfeLp?=
 =?us-ascii?Q?jmABvXc2SARAFf2wI5dy10rZCSwCSNQxliAkEyiOxe5lXjz5+qGOv+iyaaDz?=
 =?us-ascii?Q?ssOjpINM+unGL9cxLlYLaWCQYcqFfq0oe6yGC0+344H+wQgAKOxXlSoCWF1U?=
 =?us-ascii?Q?RyQkh599r5vtZHEyui0Q8LmuAYkc62DuavSq8FEHj+FPQGFMsR/poyrdur8x?=
 =?us-ascii?Q?bsnGzszXUdN47OcHesvjpopKJZhHOB+CaAQ9BmolnugYipx3BKq5Zl0iI4Zb?=
 =?us-ascii?Q?mZdWHsZ6OUTfO5mjtkYT7XN7maXUyH/rH6dJejJu862etwqsvo4UsRyFTi1k?=
 =?us-ascii?Q?51mJrXALjk4bqQHFgcXKw1gDeq5zdE/7o/niv4TCcbq0DjrwUl8zdoeJXJtC?=
 =?us-ascii?Q?hq3yiX8YsD2u050y3oxxp19L0YqNCczOyrbABK5KwHAC3xL03soUG0rKlr4J?=
 =?us-ascii?Q?PmfJHnK5H7L7L+UQ7XQFnOo2fnw7gAJZVV3nT+lsomIAfWTyxFYrGL8ejl/w?=
 =?us-ascii?Q?18H6kQ1J9XDbti5Uqeo1lv7gy16cWIbA8orcXWeOtPqUJ/nraDVbW12pG9xP?=
 =?us-ascii?Q?pwnncLVu2qcbqWlSOsXcShQn1PeTFV9Y6Q5zbf8WrBCNoIpVKiPzDcRC7TRg?=
 =?us-ascii?Q?iOrqoy36JguzIWOTOIGe7oKv0NYkft8Z7CckMa4uUTW5Re8TUZLb9P++NFpK?=
 =?us-ascii?Q?+NJMnUtSrVUpzB7CIQQjZ6IOkjiBkDsEGp36ErSWZj1dDNFLOMr+0XDkiH4w?=
 =?us-ascii?Q?DTwDhoxOMefcJpKjR8kt3PfHFMtVP/OzXqUcFyfEoWlF0zEhUhuf1ph4ohgg?=
 =?us-ascii?Q?fez0uuRnNCNjWeZl8YEhQ9x/mrZnUbJpydLy75XqSVodZ7DacAg1JWvOMUpi?=
 =?us-ascii?Q?1qpUxzcPGfm2ClE6Nf2KlkJanNOx/wLsLC2nXPWJHbi6Vk7nDPAzu1Ew69Dh?=
 =?us-ascii?Q?H8rGK0amnDIPb9pLumpWOwArubJogHkA1lyctAN3xOB7HvYLL+9zBHGN2bAE?=
 =?us-ascii?Q?2AZ285zWYBC0aK7jYfaaxfXRpKmyd8denKvrsFVKqOlCHOtAFK3IFec9GEgY?=
 =?us-ascii?Q?jCmv5/1RItvAR/XSA0ui27G+XbeAPdpBDswVkG55cgSLyz8P4Ipzg/BM5nn/?=
 =?us-ascii?Q?OyPPeZTHC4980o/z7gD+T39ySuzUCEIEGIP5YwHbcOZWUJrHlppqWSHoavhk?=
 =?us-ascii?Q?ifkN8cEV87isP8z5qXadE0VfjYObQVPNur9bj5dQ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 621d7545-00b4-4fe1-3352-08da6a6e9437
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4150.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 16:40:39.3825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: omuO+wkDaeK35o8C8hi5+XCHBf+FYTsYBpm/PMLGCDsHHw88B/oDGuczB9PdjLvJUWwePGNbMyFhUvDha0BXCH4jjjQP2XBhJC0d1QjillE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5169
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-20_10,2022-07-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207200068
X-Proofpoint-GUID: sAR9DCMggMz7I5bBdejwaBwmm0w4eyy1
X-Proofpoint-ORIG-GUID: sAR9DCMggMz7I5bBdejwaBwmm0w4eyy1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The lockdown LSM is primarily used in conjunction with UEFI Secure Boot.
This LSM may also be used on machines without UEFI.  It can also be enabled
when UEFI Secure Boot is disabled. One of lockdown's features is to prevent
kexec from loading untrusted kernels. Lockdown can be enabled through a
bootparam or after the kernel has booted through securityfs.

If IMA appraisal is used with the "ima_appraise=log" boot param,
lockdown can be defeated with kexec on any machine when Secure Boot is
disabled or unavailable. IMA prevents setting "ima_appraise=log"
from the boot param when Secure Boot is enabled, but this does not cover
cases where lockdown is used without Secure Boot.

To defeat lockdown, boot without Secure Boot and add ima_appraise=log
to the kernel command line; then:

$ echo "integrity" > /sys/kernel/security/lockdown
$ echo "appraise func=KEXEC_KERNEL_CHECK appraise_type=imasig" > \
  /sys/kernel/security/ima/policy
$ kexec -ls unsigned-kernel

Add a call to verify ima appraisal is set to "enforce" whenever lockdown
is enabled. This fixes CVE-2022-21505.

Cc: stable@vger.kernel.org
Fixes: 29d3c1c8dfe7 ("kexec: Allow kexec_file() with appropriate IMA policy when locked down")
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Acked-by: Mimi Zohar <zohar@linux.ibm.com>
Reviewed-by: John Haxby <john.haxby@oracle.com>
---
 security/integrity/ima/ima_policy.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
index 73917413365b..a8802b8da946 100644
--- a/security/integrity/ima/ima_policy.c
+++ b/security/integrity/ima/ima_policy.c
@@ -2247,6 +2247,10 @@ bool ima_appraise_signature(enum kernel_read_file_id id)
 	if (id >= READING_MAX_ID)
 		return false;
 
+	if (id == READING_KEXEC_IMAGE && !(ima_appraise & IMA_APPRAISE_ENFORCE)
+	    && security_locked_down(LOCKDOWN_KEXEC))
+		return false;
+
 	func = read_idmap[id] ?: FILE_CHECK;
 
 	rcu_read_lock();
-- 
2.27.0