Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Jul 2022 17:06:07 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Kechen Lu <kechenl@nvidia.com>
Cc:     kvm@vger.kernel.org, pbonzini@redhat.com, chao.gao@intel.com,
        vkuznets@redhat.com, somduttar@nvidia.com,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 6/7] KVM: x86: Add a new guest_debug flag forcing
 exit to userspace
Message-ID: <Ytg1/zdSPYQ2lYS/@google.com>
References: <20220622004924.155191-1-kechenl@nvidia.com>
 <20220622004924.155191-7-kechenl@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220622004924.155191-7-kechenl@nvidia.com>
Precedence: bulk

On Tue, Jun 21, 2022, Kechen Lu wrote:
> For debug and test purposes, there are needs to explicitly make
> instruction triggered exits could be trapped to userspace. Simply
> add a new flag for guest_debug interface could achieve this.
> 
> This patch also fills the userspace accessible field
> vcpu->run->hw.hardware_exit_reason for userspace to determine the
> original triggered VM-exits.

This patch belongs in a different series, AFAICT there are no dependencies between
this and allowing per-vCPU disabling of exits.  Allowing userspace to exit on
"every" instruction exit is going to be much more controversial, largely because
it will be difficult for KVM to provide a consistent, robust ABI.  E.g. should
KVM exit to userspace if an intercepted instruction is encountered by the emualtor?

TL;DR: drop this patch from the next version.