Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp5720247imw; Wed, 20 Jul 2022 11:04:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tGqRc0qrOYOHAGk6qz3O4xpfBZFq6Q9Ku5Zt6KB/CLPxA1OscrwxOxdBrDEtGl4ApYiy8G X-Received: by 2002:a17:903:3011:b0:16c:3dba:37e4 with SMTP id o17-20020a170903301100b0016c3dba37e4mr39439970pla.122.1658340267420; Wed, 20 Jul 2022 11:04:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658340267; cv=none; d=google.com; s=arc-20160816; b=iaokjV6jYfkHCX7jvQt/RNPOKYTdH8gYKM3fRnVSo/zXl855zkUdr+hHZe0wCbtzI/ K83P8nvfU+JP6xyvUxQ0L06VTouj+JHD4zWvLjVynyAeYvD7iUvz8LtnjLtN/ZcfKm5W zlaawUybW0US299e06PhPGAMcGu8CZaWsnutqmC98X+TJJ0sI7k5hnx8FjqEilG+oBW6 BsoRsQ7UB6IYYf1yS5H0EGjmXaYbtqSlDBZ62OXLygJe+wFOi0D9FVaSwkWY0KeCdvYx a5mzC6ftUDSOkCPMNCDMhG7E0M/5CyZGDu25pKnZBnc/a0Iqh4Xx9FjP17+IlBky6vLE R0Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=KoYN6t2ojX51eMCu42S4f7m7B8qXBwHa6ASD9qlPSh8=; b=EUN9y5iQCwEipo83QrBoRW25QL4h5+esINXWz1v9yYC1iAFv5xTggak3lCVIfjweSY WN36ZuisO8W2arIp2zfkDv+XfE2LS7E1AQCZhKBvwxOG/CV8gVX7z6xCMqii6GDKU07w zJUpCgTnRQp9Jy1aYZ3YFjOJIcqVa9ADfB3KHVRml1KAvPkBzv2EHT7uosW6B8a1spSy R4ejnpRYaKli6dLkA4s4maGAgqQf1wXx/+8XPWbML8TMrqKgzn3pqZZBU8crdEIbZbXq zEzitzwzoqITB3/40nXyrcnfHG1sIzIqs51CR8c4XNqRKAbT8Dv/LyWDzLijabkUjrRX kZGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iSPu9XFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a16-20020aa795b0000000b0052acb294d94si22390745pfk.100.2022.07.20.11.04.12; Wed, 20 Jul 2022 11:04:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iSPu9XFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241088AbiGTRgv (ORCPT + 99 others); Wed, 20 Jul 2022 13:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241136AbiGTRgr (ORCPT ); Wed, 20 Jul 2022 13:36:47 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55D256052C; Wed, 20 Jul 2022 10:36:46 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26KGlQDi031128; Wed, 20 Jul 2022 17:36:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=KoYN6t2ojX51eMCu42S4f7m7B8qXBwHa6ASD9qlPSh8=; b=iSPu9XFZSMAkgoAiQqlXoC5Dsbqjs6VsDvJCpE90kZlaw6zOGmqkCgBq/sSjEUENCK4X kal8ASE4/Os9Hz8VhHYBNm8chLMGb/j66P8faTMGMqRvaTzHHpGQwnJdLx6RD06g4/fq 6f3ePZBcGfwxNBTHyz9lDkMR+KkGdTI6/X2Mmn+BMUmQ+qJSNOR77RjeAB+I7C9U2Vsj /o14bV5SHQp2KCr9pVpXOxnNUP1PmIKP2O6uv35SHmf5P3/qwPA9n0/dbvkpszNMGwQP fz34xTW+q4SpGB9zwj6mpnAzq4vZdLiI1/jqrpjnl6b9paDSD5TJefuKK3lU45fyn92n zg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3he90k23dc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 17:36:34 +0000 Received: from nasanex01a.na.qualcomm.com ([10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 26KHaXsu015729 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 17:36:33 GMT Received: from [10.46.161.58] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 20 Jul 2022 10:36:32 -0700 Message-ID: Date: Wed, 20 Jul 2022 10:34:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.1 Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support To: Bart Van Assche , Can Guo , , , , , , , , , CC: "James E.J. Bottomley" , "Martin K. Petersen" , Daejun Park , Jinyoung Choi , Kiwoong Kim , open list References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com> <1658214120-22772-2-git-send-email-quic_cang@quicinc.com> <574ad23b-45c9-1bc3-0a86-c7cb73ea07bf@acm.org> From: "Asutosh Das (asd)" In-Reply-To: <574ad23b-45c9-1bc3-0a86-c7cb73ea07bf@acm.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: BITM_wsmMmEOn15-5vKT8R9JTdDi_tRK X-Proofpoint-GUID: BITM_wsmMmEOn15-5vKT8R9JTdDi_tRK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-20_10,2022-07-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 impostorscore=0 phishscore=0 clxscore=1011 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207200071 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bart, On 7/19/2022 4:07 PM, Bart Van Assche wrote: > On 7/19/22 00:01, Can Guo wrote: >> Adds MCQ support to UFS driver. > > The description of this patch is too short. It should be explained how > the UFSHCI queues are made visible to the block layer. It should also be > explained which roles are assigned to queues and how (HCTX_TYPE_*). How > the MAXQ configuration register is handled should also be explained. > > The host lock is obtained in multiple UFSHCI 3.0 code paths. Information > about the role of the host lock in MCQ code should be provided. > > Thanks, > > Bart. Thanks for having taken a look. I'll check the comments and upload a next version. -asd