Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220720065211.369241-1-jhpark1013@gmail.com> <3feb6514-de2c-4b95-b203-74362b3cc002@6wind.com>
In-Reply-To: <3feb6514-de2c-4b95-b203-74362b3cc002@6wind.com>
From:   Jaehee <jhpark1013@gmail.com>
Date:   Wed, 20 Jul 2022 14:37:58 -0400
Message-ID: <CAA1TwFCr3XryLzPTa-4V1MidusBbJf9kzL5T5zVD+Fy6iqTM_g@mail.gmail.com>
Subject: Re: [PATCH net-next] net: ipv6: avoid accepting values greater than 2
 for accept_untracked_na
To:     nicolas.dichtel@6wind.com
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        yoshfuji@linux-ipv6.org, dsahern@kernel.org,
        David Ahern <dsahern@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, shuah@kernel.org,
        linux-kernel@vger.kernel.org, Arun Ajith S <aajith@arista.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Roopa Prabhu <roopa.prabhu@gmail.com>,
        Andy Roulin <aroulin@nvidia.com>,
        Stefano Brivio <sbrivio@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 20, 2022 at 4:26 AM Nicolas Dichtel
<nicolas.dichtel@6wind.com> wrote:
>
>
> Le 20/07/2022 =C3=A0 08:52, Jaehee Park a =C3=A9crit :
> > The accept_untracked_na sysctl changed from a boolean to an integer
> > when a new knob '2' was added. This patch provides a safeguard to avoid
> > accepting values that are not defined in the sysctl. When setting a
> > value greater than 2, the user will get an 'invalid argument' warning.
> >
> > Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
> > Suggested-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> > Suggested-by: Roopa Prabhu <roopa@nvidia.com>
> > ---
> >  net/ipv6/addrconf.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> > index 6ed807b6c647..d3e77ea24f05 100644
> > --- a/net/ipv6/addrconf.c
> > +++ b/net/ipv6/addrconf.c
> > @@ -7042,9 +7042,9 @@ static const struct ctl_table addrconf_sysctl[] =
=3D {
> >               .data           =3D &ipv6_devconf.accept_untracked_na,
> >               .maxlen         =3D sizeof(int),
> >               .mode           =3D 0644,
> > -             .proc_handler   =3D proc_dointvec,
> > +             .proc_handler   =3D proc_dointvec_minmax,
> >               .extra1         =3D (void *)SYSCTL_ZERO,
> > -             .extra2         =3D (void *)SYSCTL_ONE,
> > +             .extra2         =3D (void *)SYSCTL_TWO,
> Nit: the cast is useless:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/i=
nclude/linux/sysctl.h#n40
>

O yes thank you for pointing that out! I just sent a v2 for your review.

>
> Regards,
> Nicolas

Thanks,
Jaehee