Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220716230344.239749011@linutronix.de> <20220720125736.48164a14@gandalf.local.home>
 <CAHk-=wh=Yjy=DmGzzGj-ivyx_w45AHh35eDkpGtajaiO+TX38A@mail.gmail.com>
 <Ytg6UD+0F6zv981o@worktop.programming.kicks-ass.net> <20220720135016.3178ffc6@gandalf.local.home>
 <CAHk-=wjdQbdQGKkQxxEcWoUp4SRmBWm=3bS20SbaVe8cLgKLgg@mail.gmail.com> <20220720143147.4d8a2f8d@gandalf.local.home>
In-Reply-To: <20220720143147.4d8a2f8d@gandalf.local.home>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 20 Jul 2022 11:43:37 -0700
Message-ID: <CAHk-=wjinvfNvp9kQBgiaON1HJtmnfmytruRGR5WmkM4m+ZRVg@mail.gmail.com>
Subject: Re: [patch 00/38] x86/retbleed: Call depth tracking mitigation
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Johannes Wikner <kwikner@ethz.ch>,
        Alyssa Milburn <alyssa.milburn@linux.intel.com>,
        Jann Horn <jannh@google.com>, "H.J. Lu" <hjl.tools@gmail.com>,
        Joao Moreira <joao.moreira@intel.com>,
        Joseph Nuzman <joseph.nuzman@intel.com>,
        Juergen Gross <jgross@suse.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
Content-Type: multipart/mixed; boundary="0000000000009ba6a405e440fbd1"
Precedence: bulk

--0000000000009ba6a405e440fbd1
Content-Type: text/plain; charset="UTF-8"

On Wed, Jul 20, 2022 at 11:31 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Thus, is there a way to keep this file from being entered into the
> return_sites section?

I think the whole concept is broken.

Testing known-broken code on the expectation that "this won't work
anyway, so we can jump off to code that is broken" is not acceptable.

*If* the test were to fail, it would start executing random code that
hasn't been relocated or fixed up properly.

So I think the whole concept is broken. It relies on the compiler
generating code that can work in a read-only data section, and it's
not clear that that is even physically possible (ie the data section
might be far enough away from a code section that any relocation just
fundamentally cannot happen).

I think it worked purely by mistake, because the code was simple
enough that it didn't need any relocation at all before. But even
without RETHUNK, that was never guaranteed, because any random tracing
or debug code or whatever could have made even that empty function
have code in it that just fundamentally wouldn't work in a non-text
section.

So honestly, I think that test should be removed as a "we used this,
it happened to work almost by mistake, but it doesn't work any more
and it is unfixably broken".

Maybe somebody can come up with an entirely different way to do that
test that isn't so broken, but if so, I think it's going to be using
some other machinery (eg bpf and explicitly marking it read-only and
non-executable), and removing this broken model is the right thing
regardless.

So unless somebody has some one-liner workaround, I really suspect the
fix is to remove all this. The amount of hackery to make it work in
the first place is kind of disgusting anyway.

Since this was a WARN_ONCE(), can you make sure that with this case
removed, nothing else triggers?

                Linus

--0000000000009ba6a405e440fbd1
Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_l5tyd4vd0>
X-Attachment-Id: f_l5tyd4vd0

IGRyaXZlcnMvbWlzYy9sa2R0bS9NYWtlZmlsZSB8IDExIC0tLS0tLS0tLS0tCiBkcml2ZXJzL21p
c2MvbGtkdG0vbGtkdG0uaCAgfCAgMyAtLS0KIGRyaXZlcnMvbWlzYy9sa2R0bS9wZXJtcy5jICB8
ICA3IC0tLS0tLS0KIGRyaXZlcnMvbWlzYy9sa2R0bS9yb2RhdGEuYyB8IDExIC0tLS0tLS0tLS0t
CiA0IGZpbGVzIGNoYW5nZWQsIDMyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMv
bWlzYy9sa2R0bS9NYWtlZmlsZSBiL2RyaXZlcnMvbWlzYy9sa2R0bS9NYWtlZmlsZQppbmRleCAy
ZTBhYTc0YWMxODUuLjRmMTA1OWYwY2FlOSAxMDA2NDQKLS0tIGEvZHJpdmVycy9taXNjL2xrZHRt
L01ha2VmaWxlCisrKyBiL2RyaXZlcnMvbWlzYy9sa2R0bS9NYWtlZmlsZQpAQCAtNiwyMSArNiwx
MCBAQCBsa2R0bS0kKENPTkZJR19MS0RUTSkJCSs9IGJ1Z3MubwogbGtkdG0tJChDT05GSUdfTEtE
VE0pCQkrPSBoZWFwLm8KIGxrZHRtLSQoQ09ORklHX0xLRFRNKQkJKz0gcGVybXMubwogbGtkdG0t
JChDT05GSUdfTEtEVE0pCQkrPSByZWZjb3VudC5vCi1sa2R0bS0kKENPTkZJR19MS0RUTSkJCSs9
IHJvZGF0YV9vYmpjb3B5Lm8KIGxrZHRtLSQoQ09ORklHX0xLRFRNKQkJKz0gdXNlcmNvcHkubwog
bGtkdG0tJChDT05GSUdfTEtEVE0pCQkrPSBzdGFja2xlYWsubwogbGtkdG0tJChDT05GSUdfTEtE
VE0pCQkrPSBjZmkubwogbGtkdG0tJChDT05GSUdfTEtEVE0pCQkrPSBmb3J0aWZ5Lm8KIGxrZHRt
LSQoQ09ORklHX1BQQ182NFNfSEFTSF9NTVUpCSs9IHBvd2VycGMubwogCi1LQVNBTl9TQU5JVEla
RV9yb2RhdGEubwkJOj0gbgogS0FTQU5fU0FOSVRJWkVfc3RhY2tsZWFrLm8JOj0gbgotS0NPVl9J
TlNUUlVNRU5UX3JvZGF0YS5vCTo9IG4KLUNGTEFHU19SRU1PVkVfcm9kYXRhLm8JCSs9ICQoQ0Nf
RkxBR1NfTFRPKQotCi1PQkpDT1BZRkxBR1MgOj0KLU9CSkNPUFlGTEFHU19yb2RhdGFfb2JqY29w
eS5vCTo9IFwKLQkJCS0tcmVuYW1lLXNlY3Rpb24gLm5vaW5zdHIudGV4dD0ucm9kYXRhLGFsbG9j
LHJlYWRvbmx5LGxvYWQsY29udGVudHMKLXRhcmdldHMgKz0gcm9kYXRhLm8gcm9kYXRhX29iamNv
cHkubwotJChvYmopL3JvZGF0YV9vYmpjb3B5Lm86ICQob2JqKS9yb2RhdGEubyBGT1JDRQotCSQo
Y2FsbCBpZl9jaGFuZ2VkLG9iamNvcHkpCmRpZmYgLS1naXQgYS9kcml2ZXJzL21pc2MvbGtkdG0v
bGtkdG0uaCBiL2RyaXZlcnMvbWlzYy9sa2R0bS9sa2R0bS5oCmluZGV4IDAxNWUwNDg0MDI2Yi4u
ZTU4ZjY5MDc3ZmNkIDEwMDY0NAotLS0gYS9kcml2ZXJzL21pc2MvbGtkdG0vbGtkdG0uaAorKysg
Yi9kcml2ZXJzL21pc2MvbGtkdG0vbGtkdG0uaApAQCAtOTQsNyArOTQsNCBAQCB2b2lkIF9faW5p
dCBsa2R0bV9wZXJtc19pbml0KHZvaWQpOwogdm9pZCBfX2luaXQgbGtkdG1fdXNlcmNvcHlfaW5p
dCh2b2lkKTsKIHZvaWQgX19leGl0IGxrZHRtX3VzZXJjb3B5X2V4aXQodm9pZCk7CiAKLS8qIFNw
ZWNpYWwgZGVjbGFyYXRpb24gZm9yIGZ1bmN0aW9uLWluLXJvZGF0YS4gKi8KLXZvaWQgbGtkdG1f
cm9kYXRhX2RvX25vdGhpbmcodm9pZCk7Ci0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9t
aXNjL2xrZHRtL3Blcm1zLmMgYi9kcml2ZXJzL21pc2MvbGtkdG0vcGVybXMuYwppbmRleCBiOTM0
MDRkNjU2NTAuLmQxYTY5ZWY4NjVjMiAxMDA2NDQKLS0tIGEvZHJpdmVycy9taXNjL2xrZHRtL3Bl
cm1zLmMKKysrIGIvZHJpdmVycy9taXNjL2xrZHRtL3Blcm1zLmMKQEAgLTE5MSwxMiArMTkxLDYg
QEAgc3RhdGljIHZvaWQgbGtkdG1fRVhFQ19WTUFMTE9DKHZvaWQpCiAJdmZyZWUodm1hbGxvY19h
cmVhKTsKIH0KIAotc3RhdGljIHZvaWQgbGtkdG1fRVhFQ19ST0RBVEEodm9pZCkKLXsKLQlleGVj
dXRlX2xvY2F0aW9uKGRlcmVmZXJlbmNlX2Z1bmN0aW9uX2Rlc2NyaXB0b3IobGtkdG1fcm9kYXRh
X2RvX25vdGhpbmcpLAotCQkJIENPREVfQVNfSVMpOwotfQotCiBzdGF0aWMgdm9pZCBsa2R0bV9F
WEVDX1VTRVJTUEFDRSh2b2lkKQogewogCXVuc2lnbmVkIGxvbmcgdXNlcl9hZGRyOwpAQCAtMjgw
LDcgKzI3NCw2IEBAIHN0YXRpYyBzdHJ1Y3QgY3Jhc2h0eXBlIGNyYXNodHlwZXNbXSA9IHsKIAlD
UkFTSFRZUEUoRVhFQ19TVEFDSyksCiAJQ1JBU0hUWVBFKEVYRUNfS01BTExPQyksCiAJQ1JBU0hU
WVBFKEVYRUNfVk1BTExPQyksCi0JQ1JBU0hUWVBFKEVYRUNfUk9EQVRBKSwKIAlDUkFTSFRZUEUo
RVhFQ19VU0VSU1BBQ0UpLAogCUNSQVNIVFlQRShFWEVDX05VTEwpLAogCUNSQVNIVFlQRShBQ0NF
U1NfVVNFUlNQQUNFKSwKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWlzYy9sa2R0bS9yb2RhdGEuYyBi
L2RyaXZlcnMvbWlzYy9sa2R0bS9yb2RhdGEuYwpkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5k
ZXggYmFhY2I4NzZkMWQ5Li4wMDAwMDAwMDAwMDAKLS0tIGEvZHJpdmVycy9taXNjL2xrZHRtL3Jv
ZGF0YS5jCisrKyAvZGV2L251bGwKQEAgLTEsMTEgKzAsMCBAQAotLy8gU1BEWC1MaWNlbnNlLUlk
ZW50aWZpZXI6IEdQTC0yLjAKLS8qCi0gKiBUaGlzIGluY2x1ZGVzIGZ1bmN0aW9ucyB0aGF0IGFy
ZSBtZWFudCB0byBsaXZlIGVudGlyZWx5IGluIC5yb2RhdGEKLSAqICh2aWEgb2JqY29weSB0cmlj
a3MpLCB0byB2YWxpZGF0ZSB0aGUgbm9uLWV4ZWN1dGFiaWxpdHkgb2YgLnJvZGF0YS4KLSAqLwot
I2luY2x1ZGUgImxrZHRtLmgiCi0KLXZvaWQgbm9pbnN0ciBsa2R0bV9yb2RhdGFfZG9fbm90aGlu
Zyh2b2lkKQotewotCS8qIERvZXMgbm90aGluZy4gV2UganVzdCB3YW50IGFuIGFyY2hpdGVjdHVy
ZSBhZ25vc3RpYyAicmV0dXJuIi4gKi8KLX0K
--0000000000009ba6a405e440fbd1--