Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71f92970-1e76-ed47-e878-d66f747aec86@intel.com>
Date:   Wed, 20 Jul 2022 22:09:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] ASoC:do not initialise statics to 0.
Content-Language: en-US
To:     Xin Gao <gaoxin@cdjrlc.com>, <perex@perex.cz>, <tiwai@suse.com>
CC:     <fred.oh@linux.intel.com>, <akihiko.odaki@gmail.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
References: <20220720195809.9470-1-gaoxin@cdjrlc.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20220720195809.9470-1-gaoxin@cdjrlc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1Jzd01BTitob2UzMjdENHFSa20yd2hqR0x2cVNFRnFrL0h0YkNZbUFwN2tE?=
 =?utf-8?B?TjQzOUZBb2RKRkptVURVMDZ1RnJOOHRYRzVpN2lPUzVzZGZJdnF1VisvY3pi?=
 =?utf-8?B?ejJldHZkc0Q0MTRiZ3dTd2hGOUtMeGs5QnNmNng2Sml2ekhrdjUwWkxnV2ZF?=
 =?utf-8?B?aGxFSzBsM2RrSGxadlBRczRqOHZkeHpBQmZTOGYvTDZDVnY1VCt0L2E3am9S?=
 =?utf-8?B?RWhjVGZzbWk0cWdGblhxeVRCWkRoc01vNityanhWalh0WjVnV05Vd0tKNzR2?=
 =?utf-8?B?eHprTHVLT3NmdWNlZzRQVTJlR2NNb2k2d2NyaXVoZS8yMkJJOVhZZ2JpNG1O?=
 =?utf-8?B?ZTZPTVRYYXJESFdRaUFvSThHMlV6K2JPek9ZcmpSMTNNVkNsVXVzckdQZ0cx?=
 =?utf-8?B?Vmx3ZCtLWXlGZEU2bDd1RWNVaFZzQXFBTGNEMDNVZ3NsMmpmZUZIZHpDT2xw?=
 =?utf-8?B?eFBad3V0alhMRUovbTZhUUtnRjgya3RZaHZHTytrRnBoUlZ3WEdvd0VGWjQy?=
 =?utf-8?B?VUtOdEF3TUh4MEZpK2NrdW5UWGdMWFY0RmlWMkN4aXJyb1lvT3JkSDdDZnds?=
 =?utf-8?B?a3JZaWhCZUk1d0RhYWYrRW56bnVkelhTSUduYWFYcHcvZTdvNjR4NHZ1enp2?=
 =?utf-8?B?UUVENDRLdEJXQU1aaVRuUGRuVFpKOERrTTRMVXFMRDZPeUZKQjA5dXhpUGpm?=
 =?utf-8?B?UVU0cG02VWxQU3BJWGJYKzg2cGhLbC9zUEtrdlUyL3FjT0g2dWlqaklhR095?=
 =?utf-8?B?S2oyUzNRUGFBNExLVG1zbG1Kc2dpZjQvM3RtNWhQR1lrNG1odzBPeVd3UmNU?=
 =?utf-8?B?ZnFhZmNiNDVKOXdMbDRkc2VJb3JPWlBuTW9iK25uZnBmOVpSbkRuOVpyNDZv?=
 =?utf-8?B?cnJveUFYNStqSFNoaGh5L2xjcjRSY2UzS3VuNXdjNDRnL0ZtOGlxWmF3TlBZ?=
 =?utf-8?B?eGZVOVNVM2hPZVY5cWhibTZqczlHSEFQRlp6b0ljZ3Bnd2s0VHhvZUs0R2tL?=
 =?utf-8?B?U2V0bFBDVUpCazlOOUtiSkJsNjZCTkk1elIyMXZxYnM5bXRRcitFUW9ZQjFu?=
 =?utf-8?B?TFZ2L0kwWGw2RGo2TGhoTFlFT3hRWHNpcXg5ZW92YzRHMTZETzY4UkxjNUg3?=
 =?utf-8?B?QXRHaGlDcUJyR2VKUVYySEFXYUtSQ3QvTVFqbkhVNUkvSnlRRURheVFzbHdQ?=
 =?utf-8?B?dUIzSWd3VXNlbzBTU0hLUGwzU0p6TElmcmxWUGFhUi9GUi9jRFU3VzBNSmcw?=
 =?utf-8?B?eFlKU042eXBzVDByMGRoMVg3aTFJTk9WTnBYRUxuTDBlcUo3cUg0aUJHS08x?=
 =?utf-8?B?ODZsOVRCL1N3a0U3Qmxzc2FqWGkvYjRIbWZVMDhjYktIUTNVWGUyV1pFUmg2?=
 =?utf-8?B?cExmb0l0SmZscUZjZGdXeEsrdG1wU1hBY0JyOGk1cVRaUlJFOFpibC8wZnUx?=
 =?utf-8?B?ODgxUDlQbXBreHFkSE5RUDk2YVpGUUU4VG10dFJQL2N0ZWZpT1BTV0pLNTRV?=
 =?utf-8?B?dlkzTUN1WnAyWS9zTHRtRFEzU1dKaXFHNE5RejltNXVHdzR0bjlhcTFlbzE3?=
 =?utf-8?B?SFZFUk96R3lPTVN5T0hYZi9WNkZxTGt6OUR2Nk9lbWwrdGxqazVUdVRWTWcr?=
 =?utf-8?B?SmJ6ZXFldC9ia2RtK3RHbUhxaWRVWWpNUE1Fa1JUbjVMdVRFL29IQ0czYVFy?=
 =?utf-8?B?dHB2Z0hXQ2R2QXpHM05WbTVleW9mKzFKMXZaamhZZm1MOUZLQTIwN0lEdmdQ?=
 =?utf-8?B?MEEvYTdXNkxqQlJza1oxMDdyUUJ6cXl1cHJYUy81d1IrVUhKNUdiRXRMeWhI?=
 =?utf-8?B?ODlsL0NDeHBOc2tZM3J0Sk9reUo0Rm5SOVcwbUt5VkprZGRjSEJYTytqaDNE?=
 =?utf-8?B?aHM0b0NSd3QyNmJhT1VkL0dsNStiU2tCeEJLb2RaSnd5bnhJNnN4MzhaUXUx?=
 =?utf-8?B?ekEweUVvVmdjOXI5cDFkNjBYcXBZeHZkbGkxVUtZV1pEV0VNRU1JT0ZqdDNF?=
 =?utf-8?B?STFxY1hzUTZHU3gzRmZiUzg2MUdtNDlEYll5SkhSc1FnT0xYTVQxQ203aXY2?=
 =?utf-8?B?UzVPVXF4eE5TZnkxN2NHMkZnRDVjNzEzOEIxV1FPaGllMm0xSHNoSlZKSWw2?=
 =?utf-8?B?b0JDTXpXRWxVVE1xd2M3N0wwVTlmZEo1bjJyenZ6OXNDR3FPNUZTa2lUaUw5?=
 =?utf-8?B?L2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f4c48d6-af68-4e24-46e5-08da6a8bc383
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 20:09:34.1683
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ed7oE8lib/iLhOFp6apEPRZIeHY8zNZVOERAhsVZFrbmPEujK6lgbUDZm+MoY9T6V78zDkSnpN902uYj4MckvQbbHeZsFb+IBR51gv0xmEw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB2036
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-07-20 9:58 PM, Xin Gao wrote:
> do not initialise statics to 0.

Hello,

Please do not repeat the title in the commit message - brings no value.
Also, the spelling isn't correct - s/initialise/initialize/.

I'd suggest to adhere to title formatting common to given subsystem. git 
log should help you understand which scopes should be part of commit 
title for changes targeting Intel code in ASoC domain. Last but not 
least, title is not a sentence - drop the full stop at the end of it.


Regards,
Czarek

> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>   sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c
> index 45c301ea5e00..8a8b25589c55 100644
> --- a/sound/soc/intel/boards/cht_bsw_rt5645.c
> +++ b/sound/soc/intel/boards/cht_bsw_rt5645.c
> @@ -50,7 +50,7 @@ struct cht_mc_private {
>   #define CHT_RT5645_SSP0_AIF2     BIT(18)
>   #define CHT_RT5645_PMC_PLT_CLK_0 BIT(19)
>   
> -static unsigned long cht_rt5645_quirk = 0;
> +static unsigned long cht_rt5645_quirk;
>   
>   static void log_quirks(struct device *dev)
>   {