Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp36845imi; Wed, 20 Jul 2022 16:30:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uHUiWcbRPhUr6yrRIoHM1/rJD5XTNxaBtwdQqqRXjFvKqhiJosfI2AccLPdG8MLVAA5u8Y X-Received: by 2002:a17:907:d8d:b0:72f:75:9bbd with SMTP id go13-20020a1709070d8d00b0072f00759bbdmr27264451ejc.148.1658359810540; Wed, 20 Jul 2022 16:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658359810; cv=none; d=google.com; s=arc-20160816; b=EzoHtEzAMA/tBhp0ECU9dd2vDdh6x2FXG8Wv14Lr1KY6HuPZFL88KKrpdtzMNewEGv nBKJsZQNufifrpY5KqvTvXzEN42MKm+kdPLYu9sDnK/nQnddZEoH2QsMoUl33UTGc4Z5 nJlycPKSsYhydimWWo7WaMHwtGaH/D75LldZM+0OCwoTmB/4zw0gbLenjQhnSzdU4B6e ZCMWRnGFPyWO0EqeUCE02/8WPmXdf6FKUh1yx/2CErg+c8+ZUP2KPJIWB6ILtN4C017O +OzomwVNrjhXTF770C+7bLLRWXZ64Mm7okp7lmylKwY03tDMAdxKZaRYc/qdiXr/k2t0 /OMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=O60CXwG50CMNbFlPYhSbwiVpECXcVQR97MrNWudYYbU=; b=ZIkk7/8wrZy/MGn9WmRiDCkZ4Xy3ZgXNdqtqzH5T3mjjR6AbfQ7Q2GiBdXhruxktXh DGK2/PDibTAPG6ifeDP/1yOx5Nx+fSucx+OczPVJBaPLyX12KHcLeZ2Nrlbqhin+nVMj rrQtlxzC85kcfxwDc6NlKsDdsKjbegSnaxrOrtE2yjW6toRrwoA+OmCwQQfpvAYFx8iJ v28z4xAtHCkQQjyOpUBETVnReHS0XEZqtMuKwSHyTitCN7WL3DnCBqe+rtl40Mf/ZtIV 2N0CDRpC5YhpI3JKp1z0VQvFNHEGxOyPLX46kb/vJFBIAlDMWz7si/TWWKif8cmBW2uK z1+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GV87zx+h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a21-20020a1709065f9500b00722e6c16c85si422153eju.969.2022.07.20.16.29.44; Wed, 20 Jul 2022 16:30:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GV87zx+h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbiGTXAS (ORCPT + 99 others); Wed, 20 Jul 2022 19:00:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbiGTXAQ (ORCPT ); Wed, 20 Jul 2022 19:00:16 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6342919C2E; Wed, 20 Jul 2022 16:00:14 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id v21so210861plo.0; Wed, 20 Jul 2022 16:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O60CXwG50CMNbFlPYhSbwiVpECXcVQR97MrNWudYYbU=; b=GV87zx+h1LsYC4vg5VgjnB9AbrOjX45i+veof+k4QSYkZQ54zna7rGlFeOH4O/Dx5u z32IGlZuePn4MH5P8UWLmLjFd1EmmjYN/+DWNoTMO1N3xjx7JwR59cN+qeQRNBnO7LKu IYZVMZFPCneCJ5lua2KLUs5BT//OUWtxsAgN51D6jfGjhFyN24iIzFoUUi4zYB7uwE3z B9GmsZUveR8gWujcMGePBGnnw4oU/rapQuenZ8yPATDmDwQxRoAnAd7Qc/We7bvqp5HS 695RMT5n0WYh1A6MVbKKIcrv4wRyKEBDHHZi5y5Tm8rXNUOiPb+zL08D3wU/GXas45Rt sBzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O60CXwG50CMNbFlPYhSbwiVpECXcVQR97MrNWudYYbU=; b=NWcuyDTaXFeMC7Igk82MwwqPt8qCdKxJsrmpzQYy6stxPZ4SYARxXmvDDRepk5P5/z Y+b9ITC7/vKSJrS4bVasavAYnr2cuu5cIdXlG+eS/tarRPhNKqZd7hXNP8FJI3bbdi/f PP4+X5U7nW6PwgP9ts6Jq2X6L4iFy5e9pWspIRNSOD6JehE4vLZiG2XWmtNorLfnbkOa j5pYgrv3h/q830eUUCdfVW+ZPvpi9doZXwEgyfE713E+pJn5LPxhtDW/GADrZkMLYqrC JYhmZDWeanSJBc9KXmglK0NIwh6xqgp9KxUuNzumCVPUlUb1kiWxPCan45tejS9JmwEP QdMQ== X-Gm-Message-State: AJIora/iYkL04lmZtd49pjnwyJT91IygelgOpIUksjSTQFGCyvt3tJPF vlm9oB5BoiE1J00ZJIKgXGw= X-Received: by 2002:a17:902:aa0b:b0:16b:c4a6:1dc9 with SMTP id be11-20020a170902aa0b00b0016bc4a61dc9mr41133063plb.83.1658358013694; Wed, 20 Jul 2022 16:00:13 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z2-20020aa79f82000000b005252ab25363sm149366pfr.206.2022.07.20.16.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 16:00:13 -0700 (PDT) From: Florian Fainelli To: bcm-kernel-feedback-list@broadcom.com, "Guilherme G. Piccoli" , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Brian Norris , Doug Berger , Justin Chen , Lee Jones , Markus Mayer Subject: Re: [PATCH v2 04/13] soc: bcm: brcmstb: Document panic notifier action and remove useless header Date: Wed, 20 Jul 2022 16:00:09 -0700 Message-Id: <20220720230009.2478166-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719195325.402745-5-gpiccoli@igalia.com> References: <20220719195325.402745-1-gpiccoli@igalia.com> <20220719195325.402745-5-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jul 2022 16:53:17 -0300, "Guilherme G. Piccoli" wrote: > The panic notifier of this driver is very simple code-wise, just a > memory write to a special position with some numeric code. But this > is not clear from the semantic point-of-view, and there is no public > documentation about that either. > > After discussing this in the mailing-lists [0] and having Florian > explained it very well, document that in the code for the future > generations asking the same questions. Also, while at it, remove > a useless header. > > [0] https://lore.kernel.org/lkml/781cafb0-8d06-8b56-907a-5175c2da196a@gmail.com > > Cc: Brian Norris > Cc: Doug Berger > Cc: Justin Chen > Cc: Lee Jones > Cc: Markus Mayer > Acked-by: Florian Fainelli > Signed-off-by: Guilherme G. Piccoli > > --- Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks! -- Florian