Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Jul 2022 17:39:06 -0600
From:   Rob Herring <robh@kernel.org>
To:     Jerome Neanne <jneanne@baylibre.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, nm@ti.com,
        kristo@kernel.org, khilman@baylibre.com, narmstrong@baylibre.com,
        msp@baylibre.com, j-keerthy@ti.c, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 04/14] regulator: dt-bindings: tps65219: Add
 power-button property
Message-ID: <20220720233906.GB4187584-robh@kernel.org>
References: <20220719091742.3221-1-jneanne@baylibre.com>
 <20220719091742.3221-5-jneanne@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220719091742.3221-5-jneanne@baylibre.com>
Precedence: bulk

On Tue, Jul 19, 2022 at 11:17:32AM +0200, Jerome Neanne wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
> 
> Add a power-button property to configure the EN/PB/VSENSE pin as a
> powerbutton.

Belongs in the first binding patch.

> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
> ---
>  Documentation/devicetree/bindings/regulator/ti,tps65219.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> index 6a60e62a313c..3f7f4c0280c3 100644
> --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> @@ -36,6 +36,11 @@ properties:
>        include/dt-bindings/interrupt-controller/irq.h
>      const: 1
>  
> +  power-button:

ti,power-button

Though doesn't 'system-power-controller' imply this?

> +    type: boolean
> +    description: Optional property that sets the EN/PB/VSENSE pin to be a
> +      power-button.
> +
>  patternProperties:
>    "^buck[1-3]-supply$":
>      description: Input supply phandle of one regulator.
> -- 
> 2.17.1
> 
>