Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp75023imi; Wed, 20 Jul 2022 17:29:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tAaBuin8xmUF3StI0z5pESbmlppiFp8io4oh6bOWw4UAqYdinzSlw0du019TCQgv95TLJl X-Received: by 2002:a17:907:2d0e:b0:72b:4af7:7ccd with SMTP id gs14-20020a1709072d0e00b0072b4af77ccdmr37394258ejc.209.1658363346205; Wed, 20 Jul 2022 17:29:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658363346; cv=none; d=google.com; s=arc-20160816; b=vAOH+ASKtycMZbRqapsIu9L9OYwyjnJr+PeSQYldPKgQjdvHvjNfz7MtbPBiR/P4RJ EhK1YhP+jPRI+p5ebSruKP09L3ifm5r4T0I8V/YFSIIzT1tklXyGOkclKsO7MKehUPMy BHIS/xRk3LOm7zaGw6bbwbECy4ZP4m17riiDnKmpb7nxQfqVXjS+qs/6OsdeEXVhvekg IMoMq+6q1p/BmnWR+QSNMVrGnIafINh5Ek8XUD4hIbRDcvYkvFzIdDnXKTeREYPphNUN LygnoYo69G6gTX88dwU0ieewj8uKJKdtgwD6fgxYYJsp7i3axnkjb7oztzU+a0wyC4A2 HTjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JTN7ZVeOnWslme/nIGUbcXBER65BIf1xxrYu80x7ubE=; b=ZwDd3S3EiBcfcCuU0pAPhxNaaqAq1RaRLxdrDby+1AhuNxbIUsVR6qncWm84XI5FNt Clvnqis+I4JTCkcuzCNRbzO3cBhgil/ZmowRc/TsmgSzYMRPhOotUfvJwNFZG/97CRS2 1c43Mgou3zA0VJDA9Q1RpB5xunIN76o0zDqubolQvWRwIKj8JRPobB+ehjheAjVPbuKD 4SUyjlwMbleyKtk8mDbY6ibC0QY9ESpyELceBnUsfiVyUXJgu7C9dpOnSCSLCnCmf5/b lpw7g3Ij+2ZK3zfrZaCKTJhz87Un63saakp6LcnniJtapsknDc2dl+5XvGEmD8P3QmFd 0mTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="Yfh0pa/N"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r20-20020a170906549400b00726294f089fsi760791ejo.229.2022.07.20.17.28.41; Wed, 20 Jul 2022 17:29:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="Yfh0pa/N"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231430AbiGTXmr (ORCPT + 99 others); Wed, 20 Jul 2022 19:42:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231414AbiGTXmo (ORCPT ); Wed, 20 Jul 2022 19:42:44 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF5616B247 for ; Wed, 20 Jul 2022 16:42:43 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id x11so159538qts.13 for ; Wed, 20 Jul 2022 16:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JTN7ZVeOnWslme/nIGUbcXBER65BIf1xxrYu80x7ubE=; b=Yfh0pa/N7ehhSiwja7yJnnJMyukG0R/vB6XStRTqHrVpbF+3YITqkrmgNGVAeyIMGe ECCKcMWPzGH94J46v4Zv5zmkDtzgkxPqtcbtauAt8m2HhBsbPVVOQ9PWhC8SiUCiEygV CjeJgfsLTnQvyntGlsqBwFQm3dt+A06+rvTlsVzv81Fwc8emJK+8O1ztUbcR4Wyloga3 nlXWCqeSPqW9DCEgBgJe4uRHr5uIqf2tB4Nnqsaw1w6DrEWgQ265/dLzKj3VFHvCVZ6o lYijgD1NFWnkBE4CFyOajvvykfqM8JGHkLP0lkqm67EduJV3QxXnvW8R4EHFWwNZ30gx 6GGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JTN7ZVeOnWslme/nIGUbcXBER65BIf1xxrYu80x7ubE=; b=WqmrLnLQ/rDIiXHO3J3vvEWKx2WRv93HlSrqesJE86JwkMbGBb4jy2z1IrEU4eAPEP fWm5iy2suBXNKjlBfY210KodnBa+Zcw4kK8NAN/FsAFyQxBhZVJ2LmoakmW2IpHkRd56 D9ZiAH1uIqzqmO0ZxFLZJSngo55v3/oAN3PpPl/VybLZHvrnQi6K/FUPheyeHGlmFAyE MEx08RVBSAWW//ICnfkKZuZXyjy0Dz5d9KkFw9IrKNbQpBFLtXPZH8JL64MhNaksSQn7 gxpiHhIYmtVVEwD/2awggLvGEj97SvRAc796nA1i6ocsQgbypygHH32emixBM6wCcenS yqNQ== X-Gm-Message-State: AJIora+q69nV1Vsu1msqDW+ebgFWoMtj05YefJrnyZnN2RvMA98eIljt KW5zwfuxJMXmt/PIUXmu1U84Hg== X-Received: by 2002:a05:622a:d5:b0:31e:eb65:e832 with SMTP id p21-20020a05622a00d500b0031eeb65e832mr15441277qtw.92.1658360562890; Wed, 20 Jul 2022 16:42:42 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id f5-20020ac859c5000000b0031eef540614sm354168qtf.51.2022.07.20.16.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 16:42:42 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1oEJKz-001hjm-Q7; Wed, 20 Jul 2022 20:42:41 -0300 Date: Wed, 20 Jul 2022 20:42:41 -0300 From: Jason Gunthorpe To: Dexuan Cui Cc: Long Li , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Leon Romanovsky , "edumazet@google.com" , "shiraz.saleem@intel.com" , Ajay Sharma , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA Message-ID: <20220720234241.GQ5049@ziepe.ca> References: <1655345240-26411-1-git-send-email-longli@linuxonhyperv.com> <1655345240-26411-5-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2022 at 01:13:50AM +0000, Dexuan Cui wrote: > > From: longli@linuxonhyperv.com > > Sent: Wednesday, June 15, 2022 7:07 PM > > ... > > +EXPORT_SYMBOL(mana_gd_destroy_doorbell_page); > Can this be EXPORT_SYMBOL_GPL? > > > +EXPORT_SYMBOL(mana_gd_allocate_doorbell_page); > EXPORT_SYMBOL_GPL? Can you think about using the symbol namespaces here? Nobody else has done it yet, but I think we should be... Jason