Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sungjong Seo" <sj1557.seo@samsung.com>
To:     "'linkinjeon'" <linkinjeon@kernel.org>
Cc:     "'linux-fsdevel'" <linux-fsdevel@vger.kernel.org>,
        "'linux-kernel'" <linux-kernel@vger.kernel.org>
In-Reply-To: <SG2PR04MB3899752B10CFB6CF93A6127C81879@SG2PR04MB3899.apcprd04.prod.outlook.com>
Subject: RE: [PATCH v2 0/3] exfat: remove duplicate write directory entries
Date:   Thu, 21 Jul 2022 09:36:42 +0900
Message-ID: <011d01d89c99$f2b1fd70$d815f850$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFemAJYJOoyOYeQemHeqAgjsZ9DnAHKuyhHrm2tVkA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20220711093004epcas1p4b7f4a4426c8d4f950631731156d95aa3@epcas1p4.samsung.com>
        <SG2PR04MB3899752B10CFB6CF93A6127C81879@SG2PR04MB3899.apcprd04.prod.outlook.com>
Precedence: bulk

> Changes for v2:
>   - =5B1/3=5D: Fix timing of calling __exfat_write_inode()
>     - __exfat_write_inode() should be called after updating inode.
>     - This call will be removed in =5B3/3=5D, so the patch series is
>       no code changes between v1 and v2.
>=20
>=20
> These patches simplifie the code, and removes unnecessary writes for the
> following operations.

Looks good. Thanks.

Reviewed-by: Sungjong Seo <sj1557.seo=40samsung.com>

>=20
> 1. Write data to an empty file
>   * Preparation
>     =60=60=60
>     mkdir /mnt/dir;touch /mnt/dir/file;sync
>     =60=60=60
>   * Capture the blktrace log of the following command
>     =60=60=60
>     dd if=3D/dev/zero of=3D/mnt/dir/file bs=3D=24=7Bcluster_size=7D count=
=3D1
> oflag=3Dappend conv=3Dnotrunc
>     =60=60=60
>   * blktrace log
>     * Before
>       =60=60=60
>       179,3    0        1     0.000000000    84  C  WS 2623488 + 1 =5B0=
=5D
> BootArea
>       179,3    2        1    30.259435003   189  C   W 2628864 + 256 =5B0=
=5D
> /dir/file
>       179,3    0        2    30.264066003    84  C   W 2627584 + 1 =5B0=
=5D
> BitMap
>       179,3    2        2    30.261749337   189  C   W 2628608 + 1 =5B0=
=5D        /dir/
>       179,3    0        3    60.479159007    84  C   W 2628608 + 1 =5B0=
=5D        /dir/
>       =60=60=60
>     * After
>       =60=60=60
>       179,3    0        1     0.000000000    84  C  WS 2623488 + 1 =5B0=
=5D
> BootArea
>       179,3    3        1    30.185383337    87  C   W 2629888 + 256 =5B0=
=5D
> /dir/file
>       179,3    0        2    30.246422004    84  C   W 2627584 + 1 =5B0=
=5D
> BitMap
>       179,3    0        3    60.466497674    84  C   W 2628352 + 1 =5B0=
=5D        /dir/
>       =60=60=60
>=20
> 2. Allocate a new cluster for a directory
>   * Preparation
>     =60=60=60
>     mkdir /mnt/dir
>     for ((i=3D1; i<cluster_size/96; i++)); do > /mnt/dir/file=24i; done
>     mkdir /mnt/dir/dir1; sync
>     =60=60=60
>   * Capture the blktrace log of the following command
>     =60=60=60
>     > /mnt/dir/file
>     =60=60=60
>   * blktrace log
>     - Before
>       =60=60=60
>       179,3    0        1     0.000000000    84  C  WS 2623488 + 1 =5B0=
=5D
> BootArea
>       179,3    2        1    30.263762003   189  C   W 2629504 + 128 =5B0=
=5D      /dir/
>       179,3    2        2    30.275596670   189  C   W 2629376 + 128 =5B0=
=5D      /dir/
>       179,3    2        3    30.290174003   189  C   W 2629119 + 1 =5B0=
=5D        /dir/
>       179,3    2        4    30.292362670   189  C   W 2628096 + 1 =5B0=
=5D        /
>       179,3    2        5    30.294547337   189  C   W 2627584 + 1 =5B0=
=5D
> BitMap
>       179,3    0        2    30.296661337    84  C   W 2625536 + 1 =5B0=
=5D
> FatArea
>       179,3    0        3    60.478775007    84  C   W 2628096 + 1 =5B0=
=5D        /
>       =60=60=60
>     - After
>       =60=60=60
>       179,3    0        1     0.000000000    84  C  WS 2623488 + 1 =5B0=
=5D
> BootArea
>       179,3    3        1    30.288114670    87  C   W 2631552 + 128 =5B0=
=5D      /dir/
>       179,3    3        2    30.303518003    87  C   W 2631424 + 128 =5B0=
=5D      /dir/
>       179,3    3        3    30.324212337    87  C   W 2631167 + 1 =5B0=
=5D        /dir/
>       179,3    3        4    30.326579003    87  C   W 2627584 + 1 =5B0=
=5D
> BitMap
>       179,3    0        2    30.328892670    84  C   W 2625536 + 1 =5B0=
=5D
> FatArea
>       179,3    0        3    60.503128674    84  C   W 2628096 + 1 =5B0=
=5D        /
>       =60=60=60
>=20
> 3. Truncate and release cluster from the file
>   * Preparation
>     =60=60=60
>     mkdir /mnt/dir
>     dd if=3D/dev/zero of=3D/mnt/dir/file bs=3D=24=7Bcluster_size=7D count=
=3D2
>     sync
>     =60=60=60
>   * Capture the blktrace log of the following command
>     =60=60=60
>     truncate -s =24=7Bcluster_size=7D /mnt/dir/file
>     =60=60=60
>=20
>   * blktrace log
>     * Before
>       =60=60=60
>       179,3    0        1     0.000000000    84  C  WS 2623488 + 1 =5B0=
=5D
> BootArea
>       179,3    1        1     5.048452334    49  C   W 2629120 + 1 =5B0=
=5D        /dir/
>       179,3    0        2     5.062994334    84  C   W 2627584 + 1 =5B0=
=5D        BitMap
>       179,3    0        3    10.031253002    84  C   W 2629120 + 1 =5B0=
=5D        /dir/
>       =60=60=60
>=20
>      * After
>       =60=60=60
>       179,3    0        1     0.000000000  9143  C  WS 2623488 + 1 =5B0=
=5D
> BootArea
>       179,3    0        2    14.839244001  9143  C   W 2629888 + 1 =5B0=
=5D        /dir/
>       179,3    0        3    14.841562335  9143  C   W 2627584 + 1 =5B0=
=5D
> BitMap
>       =60=60=60
>=20
> Yuezhang Mo (3):
>   exfat: reuse __exfat_write_inode() to update directory entry
>   exfat: remove duplicate write inode for truncating file
>   exfat: remove duplicate write inode for extending dir/file
>=20
>  fs/exfat/exfat_fs.h =7C  1 +
>  fs/exfat/file.c     =7C 82 ++++++++++++++-------------------------------
>  fs/exfat/inode.c    =7C 41 ++++++-----------------
>  fs/exfat/namei.c    =7C 20 -----------
>  4 files changed, 37 insertions(+), 107 deletions(-)
>=20
> --
> 2.25.1