Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp151697imi; Wed, 20 Jul 2022 19:47:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uuymFH5oyqx4XiGNLjGkMhaDm03P1Wh5F0v5cvJl1LPRXRB00WQW5sL3WaGbg3JSLGh2gS X-Received: by 2002:a17:907:67b0:b0:72b:7792:5e0a with SMTP id qu48-20020a17090767b000b0072b77925e0amr38276751ejc.400.1658371644607; Wed, 20 Jul 2022 19:47:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658371644; cv=none; d=google.com; s=arc-20160816; b=iWFxRgtNxoxercNUPFIK2889FYa+ClTqx2k+jWmNEQnjCF7NL1fvrnbEq+pTV+VKDs uRpGtfcPXgRl/JT3SepBScE+6P8Y/CwmPcA7IoYwtcs4drWQdIrheKgTl3ttB9PQwryF sC9neP3LEJc4VzQx0/4xGzkfDx5TBJEhXBrZagbphC4zmIYYMqOJNOuzDiSLm2RKw/HZ IxDfHbCCC2oZ3oacZCwHo68BBd18ABbUWNRa7ZqdlSctvtFQyuOAVOK+ZmTBhshxkDWW A2+pMt1VhbpakEqDfIDRGlv3/GM+BxThDocx8YhXwlO1gmuG8XQu1dvPZ/EL7k1TVagP LEmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=LoJhNHCwqGziaoim7n9+IevRzHMd2QR1Ud6pjKhhc/0=; b=d5L6+8fqX7hmuO+nnU+eHBo4LmnIKasyisXP6L1XvImWD8LPTEwJcWs8KUazbZl7jZ BGJ8sMneF16soHFeLGtGX0b5guuAA++PjcyPQ/JWTgVL0jQZbiQpN/9eaf67d++cwmJh rDjfwiJ5DxPkpsmK7bQBaQbP+Zf99HXfeWyAiKlRqFvMPVetGl0VR822KKm0kT7uYTlK a5un3Eozs3bxS07kQm4Ug8J+EdoMpwZV7IaBQ0kO+rit7DfaHBK+TTsF3slUK8WkwIei B1xWwX8yKyy3bnPbhhC2hyxJusS78xHYaQsDzxaf+ZnbInF1VQifG9SGlpSPc+pbvaMp Xq0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mb20-20020a170906eb1400b0072ed0d06c0csi962324ejb.411.2022.07.20.19.46.59; Wed, 20 Jul 2022 19:47:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231344AbiGUBxZ (ORCPT + 99 others); Wed, 20 Jul 2022 21:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbiGUBxY (ORCPT ); Wed, 20 Jul 2022 21:53:24 -0400 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E61CC13F05; Wed, 20 Jul 2022 18:53:22 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R731e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VJzMVEo_1658368398; Received: from 30.227.74.51(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0VJzMVEo_1658368398) by smtp.aliyun-inc.com; Thu, 21 Jul 2022 09:53:19 +0800 Message-ID: <20aa3fe4-0ad1-80b6-ca64-b0bcba884b49@linux.alibaba.com> Date: Thu, 21 Jul 2022 09:53:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/3] ocfs2: Remove a useless spinlock Content-Language: en-US To: Christophe JAILLET Cc: David.Laight@ACULAB.COM, jlbec@evilplan.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, mark@fasheh.com, ocfs2-devel@oss.oracle.com References: <8ba7004d330cbe5f626539a8a3bff696d0c4285e.1658224839.git.christophe.jaillet@wanadoo.fr> <7b644e5d32d74d3d90dfc5b1786ae5b9@AcuMS.aculab.com> <29c3fbdd-7695-46c5-bb75-fe358c574ab3@wanadoo.fr> <07c924de-78bf-c993-ce73-635af71f4edd@linux.alibaba.com> <65e6bbcb-2c33-2e43-1826-a62387572310@linux.alibaba.com> From: Joseph Qi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/22 9:32 PM, Christophe JAILLET wrote: > Le 20/07/2022 à 11:48, Joseph Qi a écrit : >> >> These code are introduced long time ago... >> Refer to commit b4df6ed8db0c "[PATCH] ocfs2: fix orphan recovery >> deadlock", I guess it plays a role 'barrier' and make sure test node map >> is executed prior than signal orphan recovery thread. In other words, to >> serialize evict inode and orphan recovery. >> >> Thanks, >> Joseph >> > > Ok, so just leave it as-is. > > Should I resend the serie without this patch, or can 1/3 and 3/3 be applied as-is? > If you don't mind, please resend with my rvb and involve akpm as well. Thanks, Joseph