Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33cc6a12-ccd7-c2ef-5dfc-0434105c50a8@linux.intel.com>
Date:   Thu, 21 Jul 2022 14:44:56 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 0/5] Add perf stat default events for hybrid machines
Content-Language: en-US
From:   Xing Zhengjun <zhengjun.xing@linux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, alexander.shishkin@intel.com,
        Jiri Olsa <jolsa@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>
References: <20220610025449.2089232-1-zhengjun.xing@linux.intel.com>
 <CAM9d7cjSynKt+CfoPqHQHNJt=to3LmdQqh_x6rKJSUcx6qFbsA@mail.gmail.com>
 <1d0e29b9-aa14-4cf5-9692-21244f7ddef5@linux.intel.com>
In-Reply-To: <1d0e29b9-aa14-4cf5-9692-21244f7ddef5@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Arnaldo,

On 7/4/2022 5:05 PM, Xing Zhengjun wrote:
> Hi,
> 
> On 6/15/2022 1:59 AM, Namhyung Kim wrote:
>> Hello,
>>
>> On Thu, Jun 9, 2022 at 7:55 PM <zhengjun.xing@linux.intel.com> wrote:
>>>
>>> From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>>>
>>> The patch series is to clean up the existing perf stat default and 
>>> support
>>> the perf metrics Topdown for the p-core PMU in the perf stat default. 
>>> The
>>> first 4 patches are the clean-up patch and fixing the "--detailed" 
>>> issue.
>>> The last patch adds support for the perf metrics Topdown, the perf 
>>> metrics
>>> Topdown support for e-core PMU will be implemented later separately.
>>>
>>> Kan Liang (4):
>>>    perf stat: Revert "perf stat: Add default hybrid events"
>>>    perf evsel: Add arch_evsel__hw_name()
>>>    perf evlist: Always use arch_evlist__add_default_attrs()
>>>    perf x86 evlist: Add default hybrid events for perf stat
>>>
>>> Zhengjun Xing (1):
>>>    perf stat: Add topdown metrics in the default perf stat on the hybrid
>>>      machine
>>
>> Acked-by: Namhyung Kim <namhyung@kernel.org>
>>
> 
> Thanks Namhyung.
> 
> Hi Arnaldo,
> 
> Can this patch series go in?
> Thanks.

This patch series has been a long time, patch2(perf evsel: Add 
arch_evsel__hw_name() ) need rebase to the latest perf/core branch,
I will send a v4 version for it.
> 
>> Thanks,
>> Namhyung
>>
>>
>>>
>>>   tools/perf/arch/x86/util/evlist.c  | 64 +++++++++++++++++++++++++-----
>>>   tools/perf/arch/x86/util/evsel.c   | 20 ++++++++++
>>>   tools/perf/arch/x86/util/topdown.c | 51 ++++++++++++++++++++++++
>>>   tools/perf/arch/x86/util/topdown.h |  1 +
>>>   tools/perf/builtin-stat.c          | 50 ++++-------------------
>>>   tools/perf/util/evlist.c           | 11 +++--
>>>   tools/perf/util/evlist.h           |  9 ++++-
>>>   tools/perf/util/evsel.c            |  7 +++-
>>>   tools/perf/util/evsel.h            |  1 +
>>>   tools/perf/util/stat-display.c     |  2 +-
>>>   tools/perf/util/topdown.c          |  7 ++++
>>>   tools/perf/util/topdown.h          |  3 +-
>>>   12 files changed, 166 insertions(+), 60 deletions(-)
>>>
>>> -- 
>>> 2.25.1
>>>
> 

-- 
Zhengjun Xing