Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8489a831-1785-fa8d-183e-22fd841b65d0@nvidia.com>
Date:   Thu, 21 Jul 2022 08:29:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH bpf-next v9 3/4] bpf, arm64: Implement
 bpf_arch_text_poke() for arm64
Content-Language: en-US
To:     Xu Kuohai <xukuohai@huawei.com>, bpf@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Will Deacon <will@kernel.org>, KP Singh <kpsingh@kernel.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Zi Shen Lim <zlim.lnx@gmail.com>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        James Morse <james.morse@arm.com>,
        Hou Tao <houtao1@huawei.com>,
        Jason Wang <wangborong@cdjrlc.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <20220711150823.2128542-1-xukuohai@huawei.com>
 <20220711150823.2128542-4-xukuohai@huawei.com>
 <8de014c1-aa63-5783-e5fd-53b7fdece805@nvidia.com>
 <b0e740c4-9630-c539-e811-a4ad93fcca5c@huawei.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <b0e740c4-9630-c539-e811-a4ad93fcca5c@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1czWWIxWUQyL1hHM3A4V2lnRGlncWFuWWNEY0pWMXZqNkttMlpURXRQMzhh?=
 =?utf-8?B?alNtMW1JQnU0cXNrWW1JRjl0RHgzMFlOQkx5WHI2ZFh3amlQOXB2QXBQZklY?=
 =?utf-8?B?eGdjcFBJWGxFeG03STJ2dzhXNysxR3orK0FYakgzTUtKMCtUQTl6dk5WSXdW?=
 =?utf-8?B?cEcwS0cvYkdRUDNRZXJTQTVpNk1rbWl2WDlrRXp1bGNZcFhZNnZFdk0wTmdh?=
 =?utf-8?B?UjFzRG81ZERVMmlValEwSS9VUkQ4KzhHMW8rNTMyVEJsaE1XS0k5NTY3S09s?=
 =?utf-8?B?MGYwUEl6aWRRZDZoMDdzcm0wMFZQUUlwWW53d1ZieEE2K3ZMd0lsTFRiVTU5?=
 =?utf-8?B?eE0xZkY1K0txbzQ0MWk3a00yMWdFUmFMdWRLdk1FdGJSbUVYVnJSTWp0Q1E2?=
 =?utf-8?B?VCs2SUYzWlArMjJvbWV1MTFtdUV4QlNOaWVma3pwRUtmcWFSbzFPM0FTYjIy?=
 =?utf-8?B?a2o5S0xkMFp2U2NLNFR3bFpMaHB3UlptSlI2eXBvcU4xQ3hEblg2NGpZbW9Z?=
 =?utf-8?B?a3owdU9HaXp6ZlA0anBUbzV3cCs4WGRtRnRTLy9ObEUwOW9VSFdMMWJYK0pl?=
 =?utf-8?B?aFNpSXV0UkJFR21iOTU3UmFUc29Nei9tUU9aUDVaUFZDNTllZEttZlRNV0RH?=
 =?utf-8?B?cE4xZWM0encvN3k0QWcxTlQ3a25rTVBMVWlLMzkyQWk3TnJYRUJqSDdKRzZy?=
 =?utf-8?B?MWwrVEkwLzk3NGU4UXduYWxRcmNzdGZhZzg5eWw5cXl3eXBkYjBLRVRGaWcw?=
 =?utf-8?B?L3BQaW5pcUdqZ1JsMEJvLzNzOWd5OE9mTzJVV2I5WThKRkRhVkxiVDVkUW0w?=
 =?utf-8?B?bThXVU14bHozNlpIM01DSDFKRXFkS05wWStUQlZUYkVJenZPREtjeVhpWVRT?=
 =?utf-8?B?NXdmb3dvd3Vtb1JndzNTYnRlRUE0and1WWZRWTRUSStQUlVRY0F2b1ZwWWZX?=
 =?utf-8?B?L2FNaTA2cEtOZ3duVlhvMGFIWXJtdDBoTmNxVksvT1I2S2MvUFZLenRUYnVo?=
 =?utf-8?B?TUNCSDRYRGZaRmNlRWNOMlZ2Ykk2bEYyRHhEaE9UTjBVUVRuKytmM0h0dTcr?=
 =?utf-8?B?MnliT2JSRlA2MjNUQm5DVWJhQVBxdkZTY1FNRUx1eVFOdTZ2RXUxeWRmYlFw?=
 =?utf-8?B?OU9GM0gwa3N1WjZqZnlUVUp2WjhEVWhlUmMrOCtEdE5IdC9qME5yU0hsendM?=
 =?utf-8?B?NnFCYXhsT2gwZktGcFprTFBwS3Q0T2tmVmY3RzRBOXYvNE5EYVVJQTVvVDc3?=
 =?utf-8?B?QmZmSjVTdHhza0g5RWdwQmxlNkhhWFo0VHFMT3JZaXBDYnlrTFYweWpQWWUx?=
 =?utf-8?B?WXBVNTVpUURObGpyVXVHVDl4NlNoVC8zL3A2REV3djA3WFlwQUJtWjg4US9i?=
 =?utf-8?B?OGZod1FnSnhCK1VTSXlXSWtDNXBpVDRRSGRsVzdVQzNCVWNnRFFRNVNKZXor?=
 =?utf-8?B?RERlbW8vejlPU1BYS0IwbzVBdVp3am5wUDdreEtiS2pxVGM1eW5La0NHUFJV?=
 =?utf-8?B?RnRVZEFNWVVER3dtN2x2czBxZ244elZ1ZG8xRFJYSkdDekwyZEdqekZpbHha?=
 =?utf-8?B?c1FPU3VhVlkzcTBtSUJZT0dOM1AwbmZXb2FWbU1SRnRzemZGL0taTnlmY3Y5?=
 =?utf-8?B?LzV2Vm1sczdoVmxJMmYyc0FUMTFWMmNPOTBWNEpTTklDV3B6OUx3K0g3alQw?=
 =?utf-8?B?OXNpdHg3T3BrVUNTU0FrS3NPakRkVldUWEdEbjNCRkpmVzVPUTJoVkVscFFV?=
 =?utf-8?B?eVd5UHNjdE5kTzNYUk1HSFVYS1l6U0FKWjRZeVNoYmZVbHJVUVliSHc1bG9p?=
 =?utf-8?B?M0puaTg3Mi9PZW9qYlU3bVZ0UWxobEEzR1E4bEQ2WG5zZS9GZG9PcmdEV3Bj?=
 =?utf-8?B?aWV1M2RQaWhRN29vbXR6S2Y2Y1RCeElnR3RFWjM1Y3NtSzVENElOK25nVWVr?=
 =?utf-8?B?NW4zaWFqa1A1WndibUxYK0JTNFBsTGZnOXpUNUhVWEVINUtMVHZpTTQwUW1F?=
 =?utf-8?B?S1JPY2ladG1IbTdTRGo1R3FncllJM1ZVYUxoNHh0cVVNTkI4WmViRURFTUUx?=
 =?utf-8?B?ZldrdG40QXJCb0J5UnFpWEpHbCtkR3JudTlXaDNtUnBiQUlCa0FvNlg4Q0dU?=
 =?utf-8?Q?/p5DstSnwHYiCXMVHXYTFx5ad?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c732355-f296-4e52-78ed-08da6aeacf5c
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 07:29:56.3930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kG3Vh1A5NbKMoNiC9YnLWfuNkGjiwaCJTnqzHupj6leQrEMKPONebrSXH6UwjN1dtcyvwSZ0nOF4plo7nPunKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5261
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18/07/2022 16:37, Xu Kuohai wrote:
> On 7/18/2022 9:52 PM, Jon Hunter wrote:
> 
> [..]
>>
>> This change appears to be causing the build to fail ...
>>
>> /tmp/cc52xO0c.s: Assembler messages:
>> /tmp/cc52xO0c.s:8: Error: operand 1 should be an integer register --
>> `mov lr,x9'
>> /tmp/cc52xO0c.s:7: Error: undefined symbol lr used as an immediate value
>> make[2]: *** [scripts/Makefile.build:250: arch/arm64/net/bpf_jit_comp.o]
>> Error 1
>> make[1]: *** [scripts/Makefile.build:525: arch/arm64/net] Error 2
>>
>> Let me know if you have any thoughts.
>>
> 
> Sorry for this failure, but I can't reproduce it.
> 
> I guess maybe your assembler doesn't recognize "lr". Could you give a
> try to replace "lr" with "x30"?
> 
>   #if IS_ENABLED(CONFIG_ARM64_BTI_KERNEL)
>   "      bti j\n" /* dummy_tramp is called via "br x10" */
>   #endif
> -"      mov x10, lr\n"
> -"      mov lr, x9\n"
> +"      mov x10, x30\n"
> +"      mov x30, x9\n"
>   "      ret x10\n"
>   "      .size dummy_tramp, .-dummy_tramp\n"
>   "      .popsection\n
> 
> Thanks.


Sorry for delay, this did not seem to land in my inbox. Anyway, yes this 
fixes the build issue for me!

Thanks!
Jon

-- 
nvpublic