Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <09fed539-909a-f274-1a73-428dc7439d69@suse.com>
Date:   Thu, 21 Jul 2022 10:00:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] USB: HCD: Fix URB giveback issue in tasklet function
Content-Language: en-US
To:     Weitao Wang <WeitaoWang-oc@zhaoxin.com>, stern@rowland.harvard.edu,
        gregkh@linuxfoundation.org, kishon@ti.com, dianders@chromium.org,
        s.shtylyov@omp.ru, mka@chromium.org, ming.lei@canonical.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     tonywwang@zhaoxin.com, weitaowang@zhaoxin.com,
        CobeChen@zhaoxin.com, TimGuo@zhaoxin.com
References: <20220721060833.4173-1-WeitaoWang-oc@zhaoxin.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220721060833.4173-1-WeitaoWang-oc@zhaoxin.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGVTR1B0c0JCV0xVQUxpWXFoZlUvUzIwRUdoeUV1Ri9LRDMySkVaS3RGcTJo?=
 =?utf-8?B?eUsra0MwaG9hV0pPdmNCd1AwcURPMG1YcXF3Z08wOTZ5dG53TUFVT2Jtbkt6?=
 =?utf-8?B?NHdjUUVodW1sVDZtWVo5ZXVzSmpOa2oxNWhIRTZlMWZOVDNFZHVZMnZTakFw?=
 =?utf-8?B?cXZTQ05UZmhTOFdyV1h6eHFpTmw5WHdVOGNqR245Mlg3d0pMcHgvT1ViNHdS?=
 =?utf-8?B?MFBKRmR6N1FVZzQ5WmJSakNrMVA3cmlxVnFsZStEYkRWZkluMHRvSWJxbE1t?=
 =?utf-8?B?MkRnT3RFa0U1TDBqYXJzeE5la2liaFRuTU1nU2IwblcyK1RSb25RYzNFbU9R?=
 =?utf-8?B?dkhnRXpKSTdnYkwrQjFWeEYrTlcybVUzUExnTFZ1NjhLelZPdk90dU5ZeGtV?=
 =?utf-8?B?Y1VoenVtYWcxSzRxTGF1WkRXQ1lhUlBpSEoyU1BEVCs4dFZhY3ZIQkhoTFRK?=
 =?utf-8?B?N1JnTVFlR0NPUlJQeWU0ZmFibzN6cm5DU1dya0FocjBCTUJ1cXZWcWJTaCtH?=
 =?utf-8?B?dW1nVUtwbFk5blYzazdHN1FXQ2c5WWtqNE0vQWwxM285Nkt5TmhUcGRQZ2Rk?=
 =?utf-8?B?Z01hRk0rdnBLaVM4YlYyMk1nVDFuUlpQbUJpWWd3SlA4MGRwMy9wQVpZK3B3?=
 =?utf-8?B?aXlzeERzVVh2TVgvU3RHNGhqRVNmU2FxSk5qc2R3RzNYUGdURG1hQTlOWUdl?=
 =?utf-8?B?OGhXTkxxVnhCVFBKeS9uWk5pM1B4R2IyZDlIYlVOUnlEaDNHaVY2MnpMUUJR?=
 =?utf-8?B?QkNLYlRnaGZ4NlJrZnowSTFXUG9ISDFjVGZFTEdueFZGMzdYbXladU5FZXZl?=
 =?utf-8?B?Wno2Vis4cVc2Ui8rRk4rVWpqb1NPVnhNdUJPVDFnNk1DMFQ2L2NzZE5BQ1l0?=
 =?utf-8?B?U1JTWGpIZFdEWUN6dGp4QzVvbktBdmQ3bU51UjhTeGMxNEJDUWtmbnZ5SC9k?=
 =?utf-8?B?RkVtUmNsc0tBRnBDQ1UzaGxFenlYY1NDM3pHNC9NcVU4cnpJSDlacmh2dGMx?=
 =?utf-8?B?c1VNWVFSc2l4SFpNemkvQTFib2JBSmVaVmtMQnVhN2tVUDhpbENzaHU5TUVP?=
 =?utf-8?B?SkpPTmVMN2g3VW1hUE9iWlloaDE1d0ZqNkdscUdyQXJnUlFYTnQ4ZVlBY3NQ?=
 =?utf-8?B?bGlkVkFUS0hFc3lMSDVuNVZLTkxDRGtSNHFzN0UrUVBiamxJNUpFUERUbmhX?=
 =?utf-8?B?MVgxcDNQN2owVUdUWk52eE5RRU1JTG1mcFFXT1cxZDBZemwxTXJxeWRkdzM0?=
 =?utf-8?B?UkU4d29iQ2d0N3p0eXF1RmFEWWR5VVhnSkRPcTN5T1FHWHUwbzhCT0I5RkNp?=
 =?utf-8?B?YnZNeC9xWkNTQjJGYjRKTlRod1dPSkN3Wk4veE4vV2F1QzR5SkVVRkJXRXpG?=
 =?utf-8?B?TnlDdnAyR0JXMEUxVUMvRGxtcTZ1aHg3K1lCK3NlcS9MVDJ4c2VXNmNDTFY2?=
 =?utf-8?B?b2U2c3M4MjRkQi9ObURmYkdRUmdScmQyNEpNUUNDMzUyM0VoK3NVcDIxakYz?=
 =?utf-8?B?RUFIRkNZOE85bmNDZmJDQTdVdkQ5ZFR6ZE9CdHF1WlA3NUpiUS9EdUE3bWRn?=
 =?utf-8?B?TS83RDFOeEV3ajRrQk9YSmd4ZUdtQk5zYlhkenBwdDZLSjRRL0xLTUsvV1lP?=
 =?utf-8?B?STFQcXVoZ2JEUGlZc1NpZVNMVDZXUFFZTXl1QXZaTlpYWUd1a25MY0FSTmF6?=
 =?utf-8?B?MXJ3MUt5UzFGeVRDcnNud0t3eXB0T3poeUQvMjRVOVJxdkJNdEw3S3g1WFpE?=
 =?utf-8?B?RWgrRm1QUzc3M0JnNGp2VTk3cGdVMDlPZEorM3pHczFDVGRjaElYM083OGVJ?=
 =?utf-8?B?Q2xubmN1bkRxNDJUZzRTSDg2QVZHYjJVMzVscU9KcTloK2JWaDJqY015dGNU?=
 =?utf-8?B?ZFNQbHlyR3Y2OGhwZE9sSEJURWF3MXJsTklFREJzaklyWUIxSnVFZ2lETCtZ?=
 =?utf-8?B?S3lwcjRXeXVSZ0xUZTQxSGsxM3JmOE0yODk1TU9zVHBxTlB6N2ZMTmZTT3oz?=
 =?utf-8?B?YzRGL01SbDdSY1hxTVVMQUdoTEUvaDNvMktiZlZ5aDdGYUE2aElGdlAyWWo3?=
 =?utf-8?B?ZmpZMHB2Q21qZXRBd1VuUVR6aEtZaWtseldBcVVCSVp6SVBBWFBlOXZSVzZR?=
 =?utf-8?B?eXY1MmlacXJsaFEvVk5GYzEwOW4zZ2xIZGcvRHgyUEZFNkhFeFVFVGdzcFNj?=
 =?utf-8?Q?Cdz99A50qtu9mmrAN7aBz+4MDOJOi5V6VdlmELK8VBq9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee4c98e-c469-44e8-89e1-08da6aef1d81
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 08:00:45.2821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OiEjCDOGVWgv2IiNuDI0/BEolK3WfyMdDB22k8QIBNsONRgoxKkglGcz61OtkOLFnHWxLu+w5owuY2x33TPOOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3713
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21.07.22 08:08, Weitao Wang wrote:
> Usb core introduce the mechanism of giveback of URB in tasklet context to
> reduce hardware interrupt handling time. On some test situation(such as
> FIO with 4KB block size), when tasklet callback function called to
> giveback URB, interrupt handler add URB node to the bh->head list also.
> If check bh->head list again after finish all URB giveback of local_list,
> then it may introduce a "dynamic balance" between giveback URB and add URB
> to bh->head list. This tasklet callback function may not exit for a long
> time, which will cause other tasklet function calls to be delayed. Some
> real-time applications(such as KB and Mouse) will see noticeable lag.
> 

Hi,

ow do you know usb_hcd_giveback_urb() will be called in time to process
isoc URBs in time, if you leave them on the list? In fact how do
you be sure it will be called at all? I can see no upper time limit
on that.

	Regards
		Oliver