Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e63cfffa-126c-d6da-207d-43db651d2d92@gmx.de>
Date:   Thu, 21 Jul 2022 10:21:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] dma-mapping:do not initialise statics to 0.
Content-Language: en-US
To:     Xin Gao <gaoxin@cdjrlc.com>
Cc:     linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220720193941.8261-1-gaoxin@cdjrlc.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220720193941.8261-1-gaoxin@cdjrlc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 7/20/22 21:39, Xin Gao wrote:
> do not initialise statics to 0.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>  arch/parisc/kernel/pci-dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
> index 160996f2198e..ba87f791323b 100644
> --- a/arch/parisc/kernel/pci-dma.c
> +++ b/arch/parisc/kernel/pci-dma.c
> @@ -36,8 +36,8 @@
>  #include <asm/tlbflush.h>	/* for purge_tlb_*() macros */
>
>  static struct proc_dir_entry * proc_gsc_root __read_mostly =3D NULL;

While at it, you could remove the "=3D NULL" as well.

Helge

> -static unsigned long pcxl_used_bytes __read_mostly =3D 0;
> -static unsigned long pcxl_used_pages __read_mostly =3D 0;
> +static unsigned long pcxl_used_bytes __read_mostly;
> +static unsigned long pcxl_used_pages __read_mostly;
>
>  extern unsigned long pcxl_dma_start; /* Start of pcxl dma mapping area =
*/
>  static DEFINE_SPINLOCK(pcxl_res_lock);