Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Michael Walle <michael@walle.cc>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "p.yadav@ti.com" <p.yadav@ti.com>,
        "richard@nod.at" <richard@nod.at>,
        "tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
        "vigneshr@ti.com" <vigneshr@ti.com>
Subject: RE: [PATCH 5/6] mtd: spi-nor: add generic flash driver
Thread-Topic: [PATCH 5/6] mtd: spi-nor: add generic flash driver
Thread-Index: AQHYnOb6STy+XODYIEqdWdLkpni6C62IlFOg
Date:   Thu, 21 Jul 2022 09:52:48 +0000
Message-ID: <OS0PR01MB5922F173C180E49273BEECB186919@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20220513133520.3945820-6-michael@walle.cc>
 <202205132220.uRTFaqNA-lkp@intel.com> (raw)
 <e6b22ad3b427770625aa56a4fe700e5c@walle.cc>
In-Reply-To: <e6b22ad3b427770625aa56a4fe700e5c@walle.cc>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AMqAJwnmXyMgdUMtHKXaaCU/BeUHwjwgK+yoApOoGyj0IyJl/SB3fiRTvpJ/?=
 =?us-ascii?Q?KH3Dsg2Q/YViMdjOJHNxHId5mL4XufuVlIe7zKlO7eyuEFtBalpBFYi104oE?=
 =?us-ascii?Q?jsQtENnRpS0XMZdejgxiqquaObGAqtbZdaptuOiCi1ZwE97DPcScC6+FCG7a?=
 =?us-ascii?Q?sSL37pl1F49oLfKyUGLHHX9dsltAHVERSXSLaofjY/0Ca78hrWQBeMOjwuh1?=
 =?us-ascii?Q?298pkj4TizT3S7AYBG6He8xkCr4Q31jXnZ5jGiCPxVaVzfMrhpzNVU6/rES6?=
 =?us-ascii?Q?aBuPp+PSALKfkAtc2wHyR0i23gMN0gSu0rn7rm7CTHDuDx3q8rtca8ib2Z05?=
 =?us-ascii?Q?duTLPUyLoK5iGejF6xYgesDUnRbX2hJxWMr3FADgfSd5PoSMK2hsA1s0m8ow?=
 =?us-ascii?Q?lSe4V/DI0xzHRHyvyE02GaydZvDa15jz96winFchSYZQmEJzUh68QekJacjN?=
 =?us-ascii?Q?0g8VO2WxuQbf6II5KwRZd08lUTRGofDL9kh76qSIIwAkZnVv/xttR95ZSH2r?=
 =?us-ascii?Q?Y+uSWU01DovHsol8RVqjOzZ+Ke7dRjtee7aZNajj1xgAYpSEzXeDaaWXAfuT?=
 =?us-ascii?Q?pL58YEkoJmgrbuWEJ2qVFOD0Zmftv4mGHDj6bXtao9wR0/R24oGkeQq93dE1?=
 =?us-ascii?Q?6wlqCl6S046cYfDcqFTc1uTZOTCNEGTvy63oqibqxh3JkLeuk1oWRxji/r7g?=
 =?us-ascii?Q?R8TU8ZT7N35gyKw/FzGki0m3Ql9HgVg9E2Bx+bPaG/CHvZHI9Xuk36127yuV?=
 =?us-ascii?Q?AvlCJAInANMohuJTKb0l+pLgnrTt+TC8t/oHsZhgkzDp+3yySFH3iVhiubHr?=
 =?us-ascii?Q?6vEIVIXCzcW64fEwjvs0T2gy2ySA3gP8e5V25BAf6bRVlQD5mYMxbfyMv4Sq?=
 =?us-ascii?Q?eT+kWNS6f/e3eXvtzGElPu1iD2QTsxPlOD4Nfcjr4N6wLZPqfNmOAykpOmKY?=
 =?us-ascii?Q?1aTs2R09beerQzBHopB7dgfHyL9fE/5ovXBn1gt45FyHcrbbF9vRIkZsIKJf?=
 =?us-ascii?Q?NYqkbdG/hNBzBNVxwVmhgitybvJue5enl6sD55CrTCVEZ0dllv+5q7k6IZNc?=
 =?us-ascii?Q?ksNrOaFou/Yo1Gzwa/RCpbd5opc5192qTnNJujQZZDMfo0pfW0SWbE14A7CG?=
 =?us-ascii?Q?OhAFgTK5tdOmFij0oDh+aEFSrNR4wJh9NlhPCsCaZRfhstsGPXkiGryAoowB?=
 =?us-ascii?Q?kTXFqASjl1BLTSCmo195PtVqxkjA2oSJVA7MTz70Vl9Cds9JPVumyL7ZRaUM?=
 =?us-ascii?Q?bCA52VWDc/KIjYLQaNc2WP1QsmdusxLVNbidY7G+lPgFe+/6vZuqyeQdc8Ee?=
 =?us-ascii?Q?DriS10i3JEqolO0M0/5b9wfR9/6HjP0xFAZ8U31sYZGYjUbhXyG9CAOn3U1w?=
 =?us-ascii?Q?LeG8U32+d6u6CYpQvCDQZGzEV/OEwtt6oBA5Zp/dVn4cL+vfnHmR/Rd0asFU?=
 =?us-ascii?Q?/5SQjoMYl/cO8wB/hORBz8YaoIa5MKqT8OUATGL1sDfkbvpKl+3LWpre5j2m?=
 =?us-ascii?Q?YUt+EcFALRfInBtK/5LJe1Zo2ALHHWkb75qJ70HFQJt0fKcolKmxnoC0VgzC?=
 =?us-ascii?Q?/NRR7IKuNfy1cyR4N+emtMrKyrwWIkbk50HqPDRczqn7dT3/ZrswhDOP9iJr?=
 =?us-ascii?Q?jA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fd559c8-dd84-48f2-55a8-08da6afec50a
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 09:52:48.5748
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qEedAuCyjVh26YeGRplGCnaJRgMeTClveSpXvKnmQMX5WS9H9CLy3k5obIMP5lUvnLdGc0nTlGMwRrUrWavF6/lkvnFz8Pe+daJE7UU4Ib0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8164
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael Walle,

> Subject: Re: [PATCH 5/6] mtd: spi-nor: add generic flash driver
>=20
> Hi,
>=20
> >> +
> >> +	/* Fallback to a generic flash described only by its SFDP data. */
> >> +	if (!info) {
> >> +		ret =3D spi_nor_check_sfdp_signature(nor);
> >> +		if (!ret)
> >> +			info =3D &spi_nor_generic_flash;
> >> +	}
> >
> > May be this can be combined as
> >
> >  	if (!info && (!spi_nor_check_sfdp_signature(nor)))
> > 		info =3D &spi_nor_generic_flash;
>=20
> While this is the behavior, I don't like (1) calling functions in the
> condition and (2) rely on the && and || semantics, i.e.
> to just call the second part if the first is true/false.

OK fine. I recently got a review comment from mainline for optimizing the n=
umber
of lines. That is the reason for suggestion.

Cheers,
biju