Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 13:47:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     alsa-devel@alsa-project.org,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami <bgoswami@quicinc.com>
Subject: Re: [PATCH] ASoC: qcom: q6dsp: Fix an off-by-one in
 q6adm_alloc_copp()
Message-ID: <20220721104731.GK2316@kadam>
References: <0fca3271649736053eb9649d87e1ca01b056be40.1658394124.git.christophe.jaillet@wanadoo.fr>
 <20220721100042.GL2338@kadam>
 <a29ea047-4935-4893-108b-f29f46971272@wanadoo.fr>
Content-Type: multipart/mixed; boundary="0ntfKIWw70PvrIHh"
Content-Disposition: inline
In-Reply-To: <a29ea047-4935-4893-108b-f29f46971272@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FG4d21e0bkwkEM8nnfmYiiffy/t6yx/hYZrrsr651rw/jtMMabmgk2Py1ZNH?=
 =?us-ascii?Q?5jkXWxs7OLSMLu/VCjQC1Nx32m7B6pnbSHEIPU6pgiFcMVWKG6YibI+St79v?=
 =?us-ascii?Q?MuC7uIfgRMhWn1SmL4RwoVudZ52eAHFqVx0OvObBTe6FcsjvE57YrNbuSrJJ?=
 =?us-ascii?Q?vkAQovfy88d+8cfnVFbUoXPUj82Ot9czdN/1o4mVowXTzgd1d5jwC4sY2bK3?=
 =?us-ascii?Q?86p3LrLUX+eJlsPhUrTythBPBcDYE2e6uaOA7QGd3Vn4g2VVbf5PhjJ9Hasm?=
 =?us-ascii?Q?J6ObMoifBMlm4z4hkLMowJZceAgTLmDDkNx0BD6h1OgvfMkPdMWSct1Fz6RS?=
 =?us-ascii?Q?cCRy852bkAwtmzjo38MAIdDyG+nEdVO6iFbMNOKBQ6uvbnIrBG0P5yOYumiG?=
 =?us-ascii?Q?pF5aOpJDpuoU4hHVGvRylLO/BCWql9JFxs0Vhw8M2VIbKrR5Xu3ZNm6+c0yf?=
 =?us-ascii?Q?uHSBXeiaIoZXqrNdZuagjngORAEYwQPbrkbN/TYW22PXVC08bGP45VhLFRt6?=
 =?us-ascii?Q?HEKSmK6cSDYC42LgC2+iuoMUFUMFEBmv1WcuPW16usGgraIJ8Lk/BIjhJEjb?=
 =?us-ascii?Q?eFYPlPZJ0bc0Y4J0qWW1T0DmIR+sLB/PLMz/CJfk/ZQPHF9cgigxsSDQ4EVv?=
 =?us-ascii?Q?aYCtA4GuRH0STnLVlP0U9hpV1Th7jLMEhEuO5CsGKCeZ/iVtty93RSd4bzY0?=
 =?us-ascii?Q?x7IlNzD7IP3qb/lOmEubtMLSuRv4dN9W2ej2oDt9MEwN8P8sdVtZ09OGJJHj?=
 =?us-ascii?Q?5066EWT+z9BmXdKBlUu4cSZ+z2Zy0H6Ia1r2ILFWriuJM1WItKN61E6FCEaJ?=
 =?us-ascii?Q?5N8/kBU2odpqp9KwNXJZLM73W0tmHGBa/xCumz3jlscXrZmwnFPcdXciyg1e?=
 =?us-ascii?Q?blSqdX2978eVlzc6GVJBnilJ+4a4zSON9Be3Sl2+2aZAb4mr+pcSk1SbDUZw?=
 =?us-ascii?Q?obuwHpq6NJ8UJcEkddgjw0+fQcm7dP4pbYGdi8R+cJ/3VXOFgCJGBC/l5NjV?=
 =?us-ascii?Q?1hl1zEBd6l2404rIOrS3mXIykCBR3gyipq7uQXUWUnSnUp139g9zeRZ4Laox?=
 =?us-ascii?Q?/RDrIBEHXZGXRC6OfyXPXdaEY5VYCm+s7x91dYtXITLkMN1x0HdRfEPFJ7nD?=
 =?us-ascii?Q?yKjvwgUC514yRBEOxUPAnR1S5UeHxz6Fu3B2w9MQ+iZrX+4Y3k+B7oPQewnu?=
 =?us-ascii?Q?JC72bUaUOpBcNctDpBzzEkXmwuBvVGJ5dKAEAXDFrW3RxtqMnPhQMH6QYV8k?=
 =?us-ascii?Q?cAiamhq76CHXeV98lk6Gq3MhSvB06MXaRUrZFYduNPNzcZIp09e4MXQvDTx3?=
 =?us-ascii?Q?tn6pqrEAkk3D4Ut9Ly+y+WfPYm+ePVvB3aeIpH9HvWcqz+eYIvUR0NNFTI+h?=
 =?us-ascii?Q?lndLn6Cs0PENi4qzSTj+iQo47KzS7Dei6aMn3kRuQRt5YB6RmXDOVn3hm7sA?=
 =?us-ascii?Q?CXXAVOjm0vjBsT/rKzr12ibwc5QObC2VP0AJTAEF1URxH6lAzLZr0th8wInT?=
 =?us-ascii?Q?j+2zqwgpH29eW3N2SnkHYKOCBUS8RxTlRn87I1HUlThN/ffKwgjgg/bl0eJr?=
 =?us-ascii?Q?c1KyMUviE1k54VHz5oc95BgcXh4glOVMtrcyW3cCxxv+uXeZvEr2f+a9+mot?=
 =?us-ascii?Q?ew=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2757c380-8fad-4695-94cc-08da6b0675f0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 10:47:52.4491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UsV7nH91RIelQjOmwjOuUYT0u8iHME09lwqOjoayBNJ6J+bQhNnjRerfpdtNR17HJPQPqHkaycsRPXQfMMbcE/VbBS9rm/6bf1WmIApf8pM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2305
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-21_14,2022-07-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207210042
X-Proofpoint-GUID: QC8RBaPBNtzmknOb7YmqHxBUw6d9A4AT
X-Proofpoint-ORIG-GUID: QC8RBaPBNtzmknOb7YmqHxBUw6d9A4AT
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--0ntfKIWw70PvrIHh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 21, 2022 at 12:30:32PM +0200, Christophe JAILLET wrote:
> You could add find_last_bit(), find_next_zero_bit_le() and
> find_next_bit_le().
> 

Thanks!

> > 
> > regards,
> > dan carpenter
> > 
> > 
> 
> A reduced version of mine was:
> 
> @@
> expression e1, e2;
> statement S;
> @@
> (
> *   e1 = find_first_bit(...);
> |
> *   e1 = find_last_bit(...);
> |
> 	[... snip ...]
> )
>     ...
>     if (e1 > e2)
>         S
> 
> 
> (and it takes only a few seconds to scan the whole kernel :) )

Nice!

I wasn't going to be before but now I have to re-write my generic
check to be even more *powerful* than before!  The new check doesn't
rely on known values for the limit, but uses comparison data instead.

(Still takes overnight to run so I might end up sorely dissappointed
and defeated tomorrow morning)

regards,
dan carpenter


--0ntfKIWw70PvrIHh
Content-Type: text/x-csrc; charset=us-ascii
Content-Disposition: attachment; filename="check_off_by_one_capped_return.c"

/*
 * Copyright (C) 2022 Oracle.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
 */

#include "smatch.h"
#include "smatch_extra.h"

static int my_id;

static void match_condition(struct expression *expr)
{
	struct expression *prev;
	int comparison;
	sval_t sval;
	char *name;

	if (expr->type != EXPR_COMPARE)
		return;
	if (expr->op != '>' && expr->op != SPECIAL_UNSIGNED_GT)
		return;

	if (!get_implied_value(expr, &sval) || sval.value != 0)
		return;

	comparison = get_comparison(expr->left, expr->right);
	if (!comparison)
		return;
	if (show_special(comparison)[1] != '=')
		return;

	prev = get_assigned_expr(expr->left);
	prev = strip_expr(prev);
	if (!prev || prev->type != EXPR_CALL)
		return;

	name = expr_to_str(prev->fn);
	sm_warning("potential off by one check '%s()'", name);
	free_string(name);
}

void check_off_by_one_capped_return(int id)
{
	my_id = id;

	add_hook(&match_condition, CONDITION_HOOK);
}

--0ntfKIWw70PvrIHh--