Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ff345fdf-4398-0275-1e1d-f87e15b31d3a@ti.com>
Date:   Thu, 21 Jul 2022 16:02:53 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: No controller seen in /sys/kernel/config/pci_ep/controllers
Content-Language: en-US
To:     Ajay Garg <ajaygargnsit@gmail.com>,
        Bjorn Helgaas <helgaas@kernel.org>
CC:     <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <CAHP4M8VuX6NrqyKQU1KS3DdTzZRQTdPK+nF0-eXXeQqhHyOypw@mail.gmail.com>
 <20220713181805.GA841376@bhelgaas>
 <CAHP4M8X67WSLMqe2qQrbODrg5oSLvR5fP4JVN+zeQafHizrOXA@mail.gmail.com>
From:   Kishon Vijay Abraham I <kishon@ti.com>
In-Reply-To: <CAHP4M8X67WSLMqe2qQrbODrg5oSLvR5fP4JVN+zeQafHizrOXA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21/07/22 15:54, Ajay Garg wrote:
> Any pointers please?
> 
> Thanks and Regards,
> Ajay
> 
> On Wed, Jul 13, 2022 at 11:48 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>>
>> [+to Kishon, endpoint maintainer, +cc LKML]
>>
>> On Wed, Jul 13, 2022 at 12:53:06PM +0530, Ajay Garg wrote:
>>> Hello everyone.
>>>
>>> The kernel has been built with :
>>>
>>> ###################################
>>> CONFIG_PCI_ENDPOINT=y
>>> CONFIG_PCI_ENDPOINT_CONFIGFS=y
>>> CONFIG_PCI_EPF_TEST=y
>>> CONFIG_PCI_ENDPOINT_TEST=y
>>> ###################################
>>>
>>>
>>> Thereafter, following are seen :
>>>
>>> ###################################
>>> $ sudo mount none /sys/kernel/config/ -t configfs
>>> mount: /sys/kernel/config: none already mounted or mount point busy.
>>>
>>> $ ls -lrth /sys/class/pci_epc/
>>> total 0
>>>
>>> $ ls -lrth /sys/kernel/config
>>> total 0
>>> drwxr-xr-x 4 root root 0 Jul 13 10:58 pci_ep
>>> drwxr-xr-x 2 root root 0 Jul 13 10:58 usb_gadget
>>>
>>> $ ls -lrth /sys/kernel/config/pci_ep/functions
>>> total 0
>>> drwxr-xr-x 2 root root 0 Jul 13 10:58 pci_epf_test
>>>
>>> $ ls -lrth /sys/kernel/config/pci_ep/controllers
>>> total 0
>>>
>>> $
>>> ###################################
>>>
>>> What is being missed?
>>>
>>> Side Queries : Is the controller that is expected to be listed, a
>>> virtual-controller (like the one provided by CONFIG_USB_DUMMY_HCD in
>>> case of USB)?

There are no virtual PCIe endpoint controllers in Linux.
>>>
>>> Or there must be a real additional controller for pci-endpoint purpose?

right, there should be an endpoint controller and the driver for it
should register with the Linux endpoint framework.
>>> If yes, then :
>>>
>>>               * I guess no listing is expected currently, as my machine has just
>>>                 one controller (as pci-host).

correct.
>>>
>>>               * Is there a way to have an additional virtual pci-controller?

Not sure what exactly your use case is. All it's going to need is the
driver to use devm_pci_epc_create() to register a endpoint controller.

You can refer existing endpoint controller drivers
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/cadence/pcie-cadence-ep.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pcie-designware-ep.c

Thanks,
Kishon