Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 13:48:41 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
cc:     Guenter Roeck <linux@roeck-us.net>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nergi Rahardi <nergi@google.com>,
        "Daniel J . Ogorchock" <djogorchock@gmail.com>
Subject: Re: [PATCH] HID: nintendo: Add missing array termination
In-Reply-To: <Ys33FIuNEsyZw8EF@google.com>
Message-ID: <nycvar.YFH.7.76.2207211348340.19850@cbobk.fhfr.pm>
References: <20220712221705.1847793-1-linux@roeck-us.net> <Ys33FIuNEsyZw8EF@google.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 12 Jul 2022, Dmitry Torokhov wrote:

> On Tue, Jul 12, 2022 at 03:17:05PM -0700, Guenter Roeck wrote:
> > joycon_dpad_inputs_jc[] is unterminated. This may result in odd warnings
> > such as
> > 
> > input: input_set_capability: invalid code 3077588140 for type 1
> > 
> > or in kernel crashes in nintendo_hid_probe(). Terminate the array to fix
> > the problem.
> > 
> > Fixes: 2af16c1f846bd ("HID: nintendo: add nintendo switch controller driver")
> > Cc: Daniel J. Ogorchock <djogorchock@gmail.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> I'd recommend tagging stable on this one.

I did so and applied, thanks.

-- 
Jiri Kosina
SUSE Labs