Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp467912imi; Thu, 21 Jul 2022 04:58:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1snlylaJTiwwW1CtAUE5S3YazZGgrUd0t9Fk8QovIGmkPaWzLP7jVwlGijYcT613CrJl1re X-Received: by 2002:aa7:94b4:0:b0:52b:b93b:95e9 with SMTP id a20-20020aa794b4000000b0052bb93b95e9mr1404922pfl.31.1658404683357; Thu, 21 Jul 2022 04:58:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658404683; cv=none; d=google.com; s=arc-20160816; b=X52Cs/QVd/x6HKtCWuXkIzKDZFlSi1+xvMwa00GvPiBkbPFrhHTV1M15IuVgMNIfR3 rlbOf0/1oxjVdwOylUDTK+VxOZEeDdkp+oa5xdjNRwv6GmkfMfyGyB16asMkVTlyR1Dz v+6CvLLpTSXtr6kYJ4uQNE00olLBRsr6t011egBkPGBOsotjNUQckVQlMEdsqU9LsTVx pG7kO+mCbi36ZCk257Z8MG9Vgso0NhwTfrda2Ksm37iMdjG4hxJD2ZGkO5KpaGk1az6q A7VXndMmTg3XKcvYYzOF69PW3hE7PweQHugSnPBTsYBxFdUu7Yfw391362a+QIJumbis 1jlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=HERq0We8j8CwHoxj+xEjyLsUyfaDI+Q0OqS7fh97oS8=; b=xiUDh6MlO16/CH8DXHdrltIPSumhs78HDBW6Te75woMTIOtZVGDirgDHYmIB4Q/n4J j8PVoXE+JJ7DzLnd2kCVKJk/x0AAq7VH3I7GBSkelFsch3eZmHq5o/C6ynYXhtl1Yy67 o8gHjTQnifBbE365Tb4Qyzv24fmRUmBj0UssVj8NoOpok9AVD1UF5n5KRajqyQ/7CjXA 2t4dNp/s4w3hzKIj+mXKbM6F93Ggh+w9PbtjiFV62/V7zHhZleca1KqhoJDQFJNaVi2a qBCJVZVc0RI8S5NZ4HVmlHH+t5mrSnNHEjhnIcKpBFSsjQp+gy2d7DFq8/SFbhg8IapO +sbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FEAJjb0M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t190-20020a6381c7000000b00419a2de79b6si1822152pgd.305.2022.07.21.04.57.48; Thu, 21 Jul 2022 04:58:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FEAJjb0M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233321AbiGULzS (ORCPT + 99 others); Thu, 21 Jul 2022 07:55:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233339AbiGULzN (ORCPT ); Thu, 21 Jul 2022 07:55:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D7CDA1B2 for ; Thu, 21 Jul 2022 04:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658404504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HERq0We8j8CwHoxj+xEjyLsUyfaDI+Q0OqS7fh97oS8=; b=FEAJjb0Mmhcg4oRrwmBIg2BpbM85fmziy/r0XW17u6vlY8wNIKgSGoCrVycQyyDHhxTrK9 QV3vreFN1RAfxC/Lz3p3cgF/ql1cYAh/M2tv/dK/I4gIZSVpll7wiDSVkuNyMxxOyhCYZ9 nabUbeQtEGmUTfL4VOy93Z2Jxaka1x8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-292-PyRpB3c-NQqwC8SzSTMV1g-1; Thu, 21 Jul 2022 07:54:59 -0400 X-MC-Unique: PyRpB3c-NQqwC8SzSTMV1g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D59BF3C0E216; Thu, 21 Jul 2022 11:54:58 +0000 (UTC) Received: from starship (unknown [10.40.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56CEF40C1288; Thu, 21 Jul 2022 11:54:55 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 10/11] KVM: x86: SVM: use smram structs From: Maxim Levitsky To: Sean Christopherson Cc: kvm@vger.kernel.org, x86@kernel.org, Kees Cook , Dave Hansen , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Borislav Petkov , Joerg Roedel , Ingo Molnar , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson Date: Thu, 21 Jul 2022 14:54:54 +0300 In-Reply-To: References: <20220621150902.46126-1-mlevitsk@redhat.com> <20220621150902.46126-11-mlevitsk@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-07-21 at 00:39 +0000, Sean Christopherson wrote: > On Tue, Jun 21, 2022, Maxim Levitsky wrote: > > + if (!guest_cpuid_has(vcpu, X86_FEATURE_SVM)) > > I think you want X86_FEATURE_LM, not X86_FEATURE_SVM. > Yes, sorry about that! Thanks! Best regards, Maxim Levitsky