Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: RE: [PATCH net-next v3 20/47] net: fman: Store initialization
 function in match data
Thread-Topic: [PATCH net-next v3 20/47] net: fman: Store initialization
 function in match data
Thread-Index: AQHYmJcTwEc1y483MUKTEndPJEkOG62IzQUg
Date:   Thu, 21 Jul 2022 12:51:21 +0000
Message-ID: <VI1PR04MB580745EF94973A1468C9FE80F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-21-sean.anderson@seco.com>
In-Reply-To: <20220715215954.1449214-21-sean.anderson@seco.com>
Accept-Language: en-GB, ro-RO, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Eue7Va2am3EUYXrMuMVgpqeQNfqUXn3jwi8rZRyT8dkoNqKhYFPJ4rPx2mJh?=
 =?us-ascii?Q?WfMQSI6Eo4mU5V7X9OS3R8DjrnMi4hcmeHXcUZgK0LRCECtIvEne1I9cR3Iq?=
 =?us-ascii?Q?SFhuDAVOOEAPHl/r1oZEZcXQtuuumidf9dpLyMO+do48mRBi5seBryDlQAc1?=
 =?us-ascii?Q?YZnWqFFKoKOSPNSEZqpbCtwkNIvdNbPhWgSX8fIqMb23lmjrQnaIx5BV6pfA?=
 =?us-ascii?Q?hzs3D3M/xhuehg7fXN7N+0yFVqI/5yVsLTcMif/cEEWK7TwBpCEMDWtDTee7?=
 =?us-ascii?Q?hkjtvjYpqRIqEw3AePb3RYtXFirqoZDb9AxeazfrPgPj4TU1xHDyypTaXW3R?=
 =?us-ascii?Q?qti2zsRBQqshidvxCAvkrLOGpH2wMEUWhNiWpcaNQ7BkLQGmmcJqW9ZmTw5m?=
 =?us-ascii?Q?+mJysVAPDMFG63FSNAGLn/Cpf3lFQAMhQOj1vpTranecoXHmPoY8XuwcEzOe?=
 =?us-ascii?Q?QQp/aE5H3W/hHhzWzTE52Mu66pG+MeGO7CLE8kgAd4DUXwgpuU31jD/3pOvM?=
 =?us-ascii?Q?xPLy09fRncX2sDgRKiPAGf3jOipPtPhs5KBzruiKea7rUEHPF9waF9m7AtnQ?=
 =?us-ascii?Q?MoCLTx2Svi4qUyEYQuo0V7XwSDVTJdRYGM+DB/J+t/Bx3LA7/WVX9fx+ZfFi?=
 =?us-ascii?Q?KR3oSdKobZpMSRj7UGaWD+VdPd5Shkkh31u70Zcpqyb9zMad/6teSGnxVA+0?=
 =?us-ascii?Q?ylRSTeNZ+83iKJg4S9tOHyg/qhI3vRcMMB4GUl7FI71Fip7Q047otZo63q9W?=
 =?us-ascii?Q?XWZF7VeIOxIrsJ1lmpnk1/Z84gYkYM99ztkm09B5ipCdGOtCXs3ePqCmM0pR?=
 =?us-ascii?Q?9BLF0JIwJc+iM845zlZP6AdFJY8IttsxMpOu+8zwgZyCMpq8q24BYUqODSCZ?=
 =?us-ascii?Q?qrBG1TqgGHABjqLfZyEB6Ztrkm9ZH1pRPbm9LNVpF99It+xFJkTFOHeguJ27?=
 =?us-ascii?Q?QQ9z7szvuhYLfx7D2KGr08+EBJRN+a2pRZ8xlMk3+3objOJTPnaZDqwFX6VL?=
 =?us-ascii?Q?3f5TMnJ6P9kY/9mCrdDACaJZhGjGNCGFb7m1SjcVstSv47IGKIqia47xApet?=
 =?us-ascii?Q?/mUT6msk4gN7tcKEi5W3+M0e+c/PuTAs4sUL8NDvdkjtnu9VI1bcmbpi3sPJ?=
 =?us-ascii?Q?73HyZdmO/KGDNeBsVRy/CnN0BbXwofdzzP2xvI6CedrACnZg/B20tB+Hc3fn?=
 =?us-ascii?Q?tcSEGBRHDovrZtXl2rcNswFGQ3DvecvJRG34T7J7L5/zuoWw0Lw3wnu/+hq2?=
 =?us-ascii?Q?EAa3f28riV/g5H1zBK37+nYPj9pVNU85PjcJZIinTKV3xIALT+uY+UU5OWIZ?=
 =?us-ascii?Q?dVxjUjOrTQJtHBz9d5cqB5LuH8DFQ84m67ATb0AAdrv1h9WR7ZrV3RRCwTj5?=
 =?us-ascii?Q?n34JvE6XcmYFBI6Oyi5Yv4ImQlnZ7nMmEOO0b/mmW+wemqJyAgZYA4KHBQ8T?=
 =?us-ascii?Q?Onl/e2M2o1bJBPizZ76Zvenn7+pUjKKFfZml4/zc2K35GqW2pxdS8NvqwIfL?=
 =?us-ascii?Q?0QQmkBcaJ6c72HOMsVpR6uCCxn/AlUCqotiZ+C5jasZaQyM3o8Zt4ZInMiif?=
 =?us-ascii?Q?WgdoUQgKc95FeyldIebvujsAmoxeBh4fcydbRWUv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5807.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57ec4c25-589e-4180-0273-08da6b17b692
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 12:51:21.7319
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NvTKkI9fQVqVt/LzGEY5pDFa1/QRmsozX80Dj9NH0yZt7YhhI9EgJehD1MbkvJqoBHrPSxoDXqvVlUFInbbV1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4623
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Saturday, July 16, 2022 0:59
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
> netdev@vger.kernel.org
> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
> <sean.anderson@seco.com>
> Subject: [PATCH net-next v3 20/47] net: fman: Store initialization functi=
on in
> match data
>=20
> Instead of re-matching the compatible string in order to determine the
> init function, just store it in the match data. This also move the settin=
g
> of the rest of the functions into init as well.=20

This last sentence can be rephrased to be clearer. Maybe something like:
The separate setup functions aren't needed anymore. Merge their content
into init as well.

> To ensure everything
> compiles correctly, we move them to the bottom of the file.
>=20
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

Acked-by: Camelia Groza <camelia.groza@nxp.com>