Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 15:01:28 +0200
From:   Jiri Pirko <jiri@nvidia.com>
To:     Vikas Gupta <vikas.gupta@broadcom.com>
Cc:     kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        dsahern@kernel.org, stephen@networkplumber.org,
        edumazet@google.com, pabeni@redhat.com, ast@kernel.org,
        leon@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net,
        michael.chan@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next v4 1/3] devlink: introduce framework for
 selftests
Message-ID: <YtlOKP4i3AG0gz+B@nanopsycho>
References: <20220718062032.22426-1-vikas.gupta@broadcom.com>
 <20220721072121.43648-1-vikas.gupta@broadcom.com>
 <20220721072121.43648-2-vikas.gupta@broadcom.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220721072121.43648-2-vikas.gupta@broadcom.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p8QYRn35n+Pbczztk80JtVfmjfiqShCl0A6CUkNHZrSDlOeiPQi912gyWwDk?=
 =?us-ascii?Q?WNdQINpXtvk0CxUx3rRSM3vDXQ1hHuLtr/eXsTMveZAbsdHAqKxBCKMzkF70?=
 =?us-ascii?Q?5awHSDR3GvqQqNTOvY7MXevEMspBozEh6OS1VThQAAVB0+49nr1XHr7bs7p/?=
 =?us-ascii?Q?1f6SF6kYuSCIyOuwhTk4GJljx2y7PK7rZ3YB+WsAJMqSpxTUj0LwxUZrvxmM?=
 =?us-ascii?Q?iY3ENsa43rtL7efkbI4egeYTZ/YbjfhyQeem2WaVnF8yYQ6tU3FpBKmnrH3J?=
 =?us-ascii?Q?75GsBMWVZmbBpl+8p6/1eJSmcElVwRu2s2S+dL/8TumyZ4Ms/16nGmHBuUFb?=
 =?us-ascii?Q?sRd0yfilRfwQYDfBIMZtnR0NRlgP2mhpLtaHn351owBJwH8aMuZMg8ccJ3n1?=
 =?us-ascii?Q?b0rCaVw9cCSHjm8wuH0c5BJQ0XWriT5kktPuzAtQsOeow/jT5gAJnKNArEDO?=
 =?us-ascii?Q?Yl8hKI08exdSZHQBTiYXwF6301E150APV7DQCypKxB2ZCs601se44f2sZ6MK?=
 =?us-ascii?Q?8VxX/zb3VWglW9T52g+2cDGzctrHx6JbTPHCFaaR2OVqrOvpkLrMWjqO0iZ0?=
 =?us-ascii?Q?NtJkUYAURy32O7kdFXbuD+wAAnufWkKmnIjIMrQtV3F+TvrOgAnPpC7lW6qI?=
 =?us-ascii?Q?0TNkdVVUH8EbEoVVKlZDQ7I0+9N7VRLzafz3BOpWGUorILnb4FfNcVieA02p?=
 =?us-ascii?Q?PIPbd2sq9FhvmtYBQD8gD6Y9V+w7L+LaOJBzwr+Ccruo53UhIPPBtD1YgcR5?=
 =?us-ascii?Q?UYKfZVVkTmkxhskz18u/fJ76ZioRWI8f849c8+dHkJxDfVzswsTUgXGX4nEI?=
 =?us-ascii?Q?1lhrv1NctmcLqnAQWlz9Ardkolg2Hpngz2pfv6ONQ2GGhOUFPVWD/SpYSM8p?=
 =?us-ascii?Q?Zbdf+ntf0ONBElIs5RyJBu0AvC8QEKlbR4oU6pJKxEXkgrIHipNWD3+mt34+?=
 =?us-ascii?Q?w8yfYRYcIc2RZtWLOtFz5lPE165FUCoTnOodVUk8MzMtWdfq+vOUzsR3CDqH?=
 =?us-ascii?Q?+p/P6IXPuvQaQLWwWmayIkOqDyMahsoqBCFvwaVSSIkLs5gQe8BxtqM3Msvu?=
 =?us-ascii?Q?X5GclBDt5VNRIKx+2hXjCji5jjS6kPeP+5lyyTiM1UF+BTk3bivjMteLHn92?=
 =?us-ascii?Q?qZPlmH+EWhU8mb17J3+tEJ4cUFZiS4Ue7b+kZWzGPJjCAogSrOF/jr3itEaG?=
 =?us-ascii?Q?1mPlMLCT+9tThWJnBUtDGopOfVXvYAlf9knI/ajAciwef3zFhPAnRRurMXb7?=
 =?us-ascii?Q?k4YwRnIKLLgPGbmePnyx75OHHftDeSQbalysk5TG8/0wgRUWhyawYSCcNFGg?=
 =?us-ascii?Q?KiDFrgebk9dDB52VEyWzdRSMg8P+r7F9FOhVya9//aaGrPxqyKL7kcgBClWw?=
 =?us-ascii?Q?TQLAgj29VTuaD0ocRkgUh5KQPMUG5sxoH4u6aj4KYFLpGe+pRVFI+jaWtjRe?=
 =?us-ascii?Q?itnSiA2IgZua2JVZFNJu46AkLI+PY2BBN2aSdWSyeqym4CCvGEfcFX9j0x/A?=
 =?us-ascii?Q?bSY6+hKAt78/KyeRn7OWsy5k9epGCkf9YA5Es9MoTSepxpcJ9mvN6hfDKLpZ?=
 =?us-ascii?Q?u7aCpR38FGO3XcVBuD1TkmDrUAlnfqsZ7aZ4fCdi?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2bdc6b-3b6f-4109-5275-08da6b19230a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5979.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 13:01:33.3517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gy8EsSXX0exOZr9JaRS8tQ3eEOPD6dqPqKeQcMgXALYa588ZYxDxz9LEnqHs7+wF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5832
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thu, Jul 21, 2022 at 09:21:19AM CEST, vikas.gupta@broadcom.com wrote:

[...]

>+	/**
>+	 * selftest_run() - Runs a selftest
>+	 * @devlink: Devlink instance
>+	 * @test_id: test index
>+	 * @extack: extack for reporting error messages
>+	 *
>+	 * Return: Result of the test
>+	 */
>+	u8 (*selftest_run)(struct devlink *devlink, int test_id,

It should return enum. Make sure you changed the variable type you store
the test status in.


>+			   struct netlink_ext_ack *extack);
> };

[...]