Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: RE: [PATCH net-next v3 33/47] net: fman: Clean up error handling
Thread-Topic: [PATCH net-next v3 33/47] net: fman: Clean up error handling
Thread-Index: AQHYmJcMtrfSypnu4kK41rncT5KaHK2I1DBA
Date:   Thu, 21 Jul 2022 13:06:43 +0000
Message-ID: <VI1PR04MB5807209C2DCA220E794C0DCCF2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-34-sean.anderson@seco.com>
In-Reply-To: <20220715215954.1449214-34-sean.anderson@seco.com>
Accept-Language: en-GB, ro-RO, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GOZLLldCL6M/wAZI57xQGDjZjDEvgVXL/DYLRMdDd8kNFTEeUAxUeKJIMiaQ?=
 =?us-ascii?Q?7LvZELr2X0jRYQn5St3PYe1TAE/dF0A8pbC4U7uUCoj9oR1WaUqcsbMaFKlH?=
 =?us-ascii?Q?IeubSlGuQ4lCgP2kDe4YRGqGLPNRbGRZ1nmL1aD+RosK6dKwAG5qsH8xfTPd?=
 =?us-ascii?Q?K9USWBjMHlRREOrB3pfx/CBtTKqiVn+NnMvujtdId1f0SlQe9i8ovZeHmETs?=
 =?us-ascii?Q?cCGLqQda6Te3TRD+S+oORFGu17m3Axc7+hnZiEOrcpdo+9IANMmeEnRy4m57?=
 =?us-ascii?Q?mAnJydItlAQV+qCuoj2lQHkreGcz6OWfqrr3c62IaeDKwJSzJY+4XR//05Uv?=
 =?us-ascii?Q?MImwIJ+LU7aDitIRkzSlmi9I2QJupJZ9PnSykQhzxGt0kBW2z8LURgR2uggK?=
 =?us-ascii?Q?dHzyCW8gg4bOZnu8NMQ7Gt6N2i/CtcgMcTH1WjCL69i2cc3kjB/DjDut19yX?=
 =?us-ascii?Q?X2LscSfVSbzC/8RG6gu2ciY3iCFLWQomrDs2/CJMVZelF8wwmH5PmwO7dcxJ?=
 =?us-ascii?Q?jeAVVM0tE/kp9HsFlDs73biJE7inlJRUOkMAzUxGG8feYECGBOIITh3wOt98?=
 =?us-ascii?Q?zqPTBZlFaYC5b6B9s73Mxre3brRuMn5EkVOWB4554goj8+kKCDJAg/afvaLU?=
 =?us-ascii?Q?ilLUn1vk9vh5AAn61bGUARFYw7bClX99OG/JkmYoBPnFMz3PIAY808b8TiLY?=
 =?us-ascii?Q?r0pouLF7i4RC734fpJJiXZYIlUxONjsFXNMXn7ZftPvOKe5LTU07G5G5AlEE?=
 =?us-ascii?Q?OXN+fYdVifkpXCkZHRmTRxEa4OhrX79bBDjA8900DVA7B0INXdIiqrYpQewk?=
 =?us-ascii?Q?/x1s4k+Bfpv7hLoiKGkEvpzkNf5LGL+e+yz9TwAd+FefZFxITsKQ4fEAyL75?=
 =?us-ascii?Q?jSy5NTtcRI3ahCJjsnbr3qtfyRuiFlHfjqEC958Geygay3RiP5js5hgcEnt5?=
 =?us-ascii?Q?9lgC6KV4mjSg02SuID02UnBHWe92gPrNjATw3o0UB7VHTKbUNGJ0rhcPT5am?=
 =?us-ascii?Q?QvRKAPObf17Cgb6YAGwjPnk9l7XISVzAEe75x9FRPyE2EfXMt6FFl0Wa/n1I?=
 =?us-ascii?Q?qkizR+zIYIU4rJhCbAV7/BXD5JmmIedYUfr5BR2XuZuQbfu+V5H+bq9jnoe4?=
 =?us-ascii?Q?6KgQQgti0foFqrW+2Vs7fkevgJD9iN6D75F2x+kPljkD4n/JpNu1YIjfaYRc?=
 =?us-ascii?Q?tYyKA6t9eOFNSp6beiqbmyVtsr/5mLW7hrvCRdi5DFRqEYUXD2n7Q00C0H78?=
 =?us-ascii?Q?D2MFxyFB+q7lO+72G/WE54hkHSS+TKxqVH+mcVBU7/dtgtEpkn4tMn9QnaoQ?=
 =?us-ascii?Q?6O8RFT55SD+Amib7l/eOVnfMpUoaECYa1fRRDI0xuwXtAsXCbU+cfSZESfMI?=
 =?us-ascii?Q?q1tGKfOH07pBWnL28dX2WwBTJZPUzYOkW80pT2nZUPvFnZ+YNdujskMWuIGx?=
 =?us-ascii?Q?0bWAXbt4/BXY4hB0SIDhMTqReWdCKNXaNKKhKDnyhmhQ8vbTviixTs8ehwRa?=
 =?us-ascii?Q?iArB0y8CrdZwBi+/yuXkT+nn0c/M4GbOtti+lQqrF8VlIK5hEVdwNpswKdfj?=
 =?us-ascii?Q?ubk6uhpSYwT03kRIjQe7PfwBJbxN7F2g/1j/2C6M?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5807.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fe42380-0da6-421b-5c46-08da6b19dbe9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 13:06:43.3736
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3cLT0UfPV5rd8Q3WQYm100nG6BIE5epemz8LLzQyCcccILYG6+rUsZZc4M2BHGzxoI+FU/xei4cdBrnAEXQ67w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2656
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
> netdev@vger.kernel.org
> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
> <sean.anderson@seco.com>
> Subject: [PATCH net-next v3 33/47] net: fman: Clean up error handling
>=20
> This removes the _return label, since something like
>=20
> 	err =3D -EFOO;
> 	goto _return;
>=20
> can be replaced by the briefer
>=20
> 	return -EFOO;
>=20
> Additionally, this skips going to _return_of_node_put when dev_node has
> already been put (preventing a double put).
>=20
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

Acked-by: Camelia Groza <camelia.groza@nxp.com>