Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: RE: [PATCH net-next v3 35/47] net: dpaa: Use mac_dev variable in
 dpaa_netdev_init
Thread-Topic: [PATCH net-next v3 35/47] net: dpaa: Use mac_dev variable in
 dpaa_netdev_init
Thread-Index: AQHYmJcb9FPszthP+E2JU9KVFqcVmq2I1Mcg
Date:   Thu, 21 Jul 2022 13:15:07 +0000
Message-ID: <VI1PR04MB5807DD62C1A2E733CC7CC129F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-36-sean.anderson@seco.com>
In-Reply-To: <20220715215954.1449214-36-sean.anderson@seco.com>
Accept-Language: en-GB, ro-RO, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/mppQfPK2u93gUT1tVfb3B/t7DmpD1qQOF26zg6U7tmFQW3VGBUqFh7ws/Wy?=
 =?us-ascii?Q?+RgsuyF642ze8JeO5Y+k+PDcVJ0XSfHI3CFuuDZWESNtb5zS19rxKUZ2IiAd?=
 =?us-ascii?Q?/pNh78BtsaxYn34i3u/Bncv7oHKcmvkX2oTo/AbPLarpJN9z+5IacnS1boI7?=
 =?us-ascii?Q?KbXtni/WQH+BPeaTpTpYcf4kpwAZ64+Nboco2TzQdQzyZJkXu5y4feIPzeI8?=
 =?us-ascii?Q?U2XLOh+E8B/KjowWwO5CuNJyA/fnTlZHA+da3+k4OW3gLf16P/72CufBONbv?=
 =?us-ascii?Q?Avo1aAP3PSBckrurYhUgH1xLuNQe/GoJbAylZT1iW0r1cCYTuEynr0xZkWvt?=
 =?us-ascii?Q?r7tLdDCK7K1uCK49PzP/afrGDW0oGHapeYj6SyYvgRi3/gIni2MlP6ifJY1u?=
 =?us-ascii?Q?r73PxRoE2B5Txm9lrDePfbMS7xZKD8oSEAetnFzP9zKNblZGGICO01B3lQSl?=
 =?us-ascii?Q?+kHPzDUUmEAFEcMg3+EZ+5yknsFqzeyV+qWKbBWf2EEm/3NvMc/dZNArkNSR?=
 =?us-ascii?Q?l7kpcWuC0YH6wMOU9s7Cf3ysPRoubdy3fBPoiTRWrA9MuFaIuTs2fen4pvia?=
 =?us-ascii?Q?gv0dGlaS6rkhtnnNEcJ8+SLLKO8/YhI1SKm/FvcMJ2y1V+zOjTvtZrSgeM2G?=
 =?us-ascii?Q?+rfOhDOd/Bv1yDJopAAgtJ4ZmjELs6DDKKoPsosJXlqTuTO65h+qpg5DsZhp?=
 =?us-ascii?Q?x6E1nB5b2llldatq17CoF2Zc5o8iINLgRJFmJ0gGhqyd6vlRrz4Zg+8EvLWA?=
 =?us-ascii?Q?SBfjHHbHTpyKSw36kzVjVDb5ajEQncOLR1qVpf/X8QJztNdRpo1vwA9wuAmc?=
 =?us-ascii?Q?I6bF5zwehGoaizkVctx40CEFJKtb1rCLxScW0DKb0z8MRJ58KlFYwZEZ8fhu?=
 =?us-ascii?Q?0dvPabRYbC3qW0Z1JT+5l4dQiYLJD1ea++TTXZ//doWtVZhciWLr70T0dNOI?=
 =?us-ascii?Q?cdoklbihkx4wevSfwo14nywgvMDlFr2yp5XLByPOnhmF2Br1r9Zse0fEdtsb?=
 =?us-ascii?Q?ngRjFfPmH4RhpiflHb1Zb46fByE8h3bhqR/7P6mBldQ7es+s0MKNaw4UaNCv?=
 =?us-ascii?Q?1SP96YdrePwZyRn95H3sTsfvMtbRJQwvNLnZ4TWOfoaP/4H3vzjbOg29khYt?=
 =?us-ascii?Q?hrqEypVE6MG1VFgWevrVbWJ8/0ySPwcZgEGEdSLFJUQf6gvXs3eRzrBoe3JF?=
 =?us-ascii?Q?HYuvGeEEOCScfaKL1aG9ko4VTG5g2lbaLnvv8rpDUWRLM6HdtpNNRdqWfDtC?=
 =?us-ascii?Q?EzOU5OWXZwk07o75wFzRSksIu4wRa8hOgjTls42WBCCgpFSzwTXoIqgEPUDg?=
 =?us-ascii?Q?BddorvnspXzvx/7L2pQjyWY6blhYa+xyQ0G9tUe0hOsXJnzGdoZdZd2xIQKL?=
 =?us-ascii?Q?B6dPQGyHpn+oTN3MkrJKRp9ceDoAP8cyOJVDQPlQ9cl/EfEhR2blJDNl8PjK?=
 =?us-ascii?Q?m4MZ4SfSTlL3l+vtsC813NUD/IsW/5IBqr8up9+w/6r7wBPAqICHTwWV25QY?=
 =?us-ascii?Q?vjrMUVUfTyllXI9wM6rYflkwiEC8/l2opn4gWtXCZQ+jpZUXczkEA/QXtZIf?=
 =?us-ascii?Q?IBnh6CIOEA+81op3sW6w1+21xlMwE6EyE+P9CDDU?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5807.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22cbe5fe-1032-4b4b-47e9-08da6b1b0870
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 13:15:07.5742
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ykR7WCmLFrZGuGCpa+uwoCLrZRkncPirhuMz7poIamU2IMcYzbZljpQdwqhDNytNZkEyzUIOqHJCjFcVwyIrLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6191
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
> netdev@vger.kernel.org
> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
> <sean.anderson@seco.com>
> Subject: [PATCH net-next v3 35/47] net: dpaa: Use mac_dev variable in
> dpaa_netdev_init
>=20
> There are several references to mac_dev in dpaa_netdev_init. Make things =
a
> bit more concise by adding a local variable for it.
>=20
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
>=20
> (no changes since v1)
>=20
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index d378247a6d0c..377e5513a414 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -203,6 +203,7 @@ static int dpaa_netdev_init(struct net_device
> *net_dev,
>  {
>  	struct dpaa_priv *priv =3D netdev_priv(net_dev);
>  	struct device *dev =3D net_dev->dev.parent;
> +	struct mac_device *mac_dev =3D priv->mac_dev;
>  	struct dpaa_percpu_priv *percpu_priv;
>  	const u8 *mac_addr;
>  	int i, err;
> @@ -216,10 +217,10 @@ static int dpaa_netdev_init(struct net_device
> *net_dev,
>  	}
>=20
>  	net_dev->netdev_ops =3D dpaa_ops;
> -	mac_addr =3D priv->mac_dev->addr;
> +	mac_addr =3D mac_dev->addr;
>=20
> -	net_dev->mem_start =3D (unsigned long)priv->mac_dev->vaddr;
> -	net_dev->mem_end =3D (unsigned long)priv->mac_dev->vaddr_end;
> +	net_dev->mem_start =3D (unsigned long)mac_dev->vaddr;
> +	net_dev->mem_end =3D (unsigned long)mac_dev->vaddr_end;
>=20
>  	net_dev->min_mtu =3D ETH_MIN_MTU;
>  	net_dev->max_mtu =3D dpaa_get_max_mtu();
> @@ -246,7 +247,7 @@ static int dpaa_netdev_init(struct net_device
> *net_dev,
>  		eth_hw_addr_set(net_dev, mac_addr);
>  	} else {
>  		eth_hw_addr_random(net_dev);
> -		err =3D priv->mac_dev->change_addr(priv->mac_dev-
> >fman_mac,
> +		err =3D priv->mac_dev->change_addr(mac_dev->fman_mac,
>  			(const enet_addr_t *)net_dev->dev_addr);

You can replace priv->mac_dev->change_addr with mac_dev->change_addr as wel=
l.

>  		if (err) {
>  			dev_err(dev, "Failed to set random MAC address\n");
> --
> 2.35.1.1320.gc452695387.dirty