Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Leo Li <leoyang.li@nxp.com>,
        Sean Anderson <sean.anderson@seco.com>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH net-next v3 38/47] net: dpaa: Adjust queue depth on rate
 change
Thread-Topic: [PATCH net-next v3 38/47] net: dpaa: Adjust queue depth on rate
 change
Thread-Index: AQHYmJbEBzDFq0faUUu0+f0xTCzeF62I148g
Date:   Thu, 21 Jul 2022 13:18:49 +0000
Message-ID: <VI1PR04MB5807AE37477A9E7669D8A10BF2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-39-sean.anderson@seco.com>
In-Reply-To: <20220715215954.1449214-39-sean.anderson@seco.com>
Accept-Language: en-GB, ro-RO, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rnAGFPbgMmkrllTwxKjYAz9tyOos+YJWWrL67zakA3Vsr6TVFT7PFJridRJc?=
 =?us-ascii?Q?ch0bmBBVLA6kkUqQmGjdlFlAajFI2ZiQq+xh8WbZVVeyE0XyTLBTHaiGV1Si?=
 =?us-ascii?Q?BnxSPTd/s2wYfBYSuhG52K0O+3NEwsjq/2x4LdYOzPQRd0SVLS2MHxWEhwn6?=
 =?us-ascii?Q?AA4BUkCFWKsP+GFHiZBQFQamKRMoJaRDPBEM0KjaRmdLixmAm1PgimBqOPuf?=
 =?us-ascii?Q?dtZbIqM7M1KL6FOmOI0BR80p3gyvehFwXtpDPsJYoiHLB/eoc01riwVX3rrR?=
 =?us-ascii?Q?WmNvCpcyr1XPUVMiKK4pbRsRKbsofbW0T6Grf/R5NNZekMdcXI9aMUi32o2O?=
 =?us-ascii?Q?s7kwDKwsT+FexY5qEjZxGIblt+ProR5tBgh+wmJ6snlYstnO5ZaTInQ84WD9?=
 =?us-ascii?Q?tm4oAP2hTHsmGyVaSb+oJWcZOH+uH1M+7Ho9nQ7dE8IRQr3Tb4+USLZGF+Lj?=
 =?us-ascii?Q?kP3n5UolfYqDRl0ScIL20nd7IBR9Y4nZigBXG3c3fzD9kFqZecJVu6sfg+bA?=
 =?us-ascii?Q?S5NMnfDbZ+W+P4NmZTHU+uWim0WjFDZTCdGZOewZb2URTQ2emKaOBS/nzalo?=
 =?us-ascii?Q?NJvb19oVM5AaDo4IrEzQpwpZXXJcsX8E9sQ6qdo719Tf6t/2QzJwb2UQtdOk?=
 =?us-ascii?Q?R13Ys1OpH3ODY5cnyRXorYRNZguIQHobnSkKwutoLl5lQH8YRxxkwTR9btvp?=
 =?us-ascii?Q?kDme5CDEfBGlV8KZewkmu6WuKcjakNNTQy7efWLPOrkbNixuEIwA+0ParTKc?=
 =?us-ascii?Q?cucGt6lXAn9rFvC3OrpC5+HKbSRcWUy/T3tZ7+K0v/M2C00afxPwYiSe3nEI?=
 =?us-ascii?Q?wYTFjhWW4HGAYAbFuqkjvZeWyWaEakrX9AI29FQ/idsguEWvw/H+Arl4CC0q?=
 =?us-ascii?Q?0NoaoyDyiSYUucLwo2/7xJsPstL9rmzuuKZcTHLXS/mb9VGpXylAWDn/rOHY?=
 =?us-ascii?Q?yTrl0swbf6V7WVxrpxqFnUEQzQfYIyrvbdDZ1H2FFJmH+TXmsjbGWtI2mARi?=
 =?us-ascii?Q?L8bj1Z2jWbVqpSwvps7HW8qvy/tZ/u1hHDqsN0PhNHqho5S+K19ED9G12KPe?=
 =?us-ascii?Q?Vs4zAhLef5haanCyVrepGEhbkR3or4CTAclcd7WPtdFqsmT+nN1N8RSve1gO?=
 =?us-ascii?Q?nvVR+ZPujaK+WkKV0vmpH78Mu67CWjCwmW7dz2Jk/eAOpF3s74sBcXKnrC9J?=
 =?us-ascii?Q?gHYLYqVZB4I6oQcrLs/BAjdrmnQzM/FGf+HgsL1O3h0BG9IGy6ahSAerGsba?=
 =?us-ascii?Q?QdzqlSCeYMHa1fuxvBqWwMVzswPxS3SrX+Gr/tSWi4KJg6OSqSdyBqQmjfCT?=
 =?us-ascii?Q?2sbypOqvbRPIy7njU2iSZ947klMyAkMa9687LuANDcjsA/j8SVUlnFnQM/un?=
 =?us-ascii?Q?CzQVTdcZLsxDudAkf9WwteSeVBEe/Cqd7n8JZg7v2fvERWirB4OEpn8vGCOt?=
 =?us-ascii?Q?+/nMEHdw9LAE1BwW2IM7M9LCxjH42KhW9fTkuPf0Onh2SzDEwkFXpvq00H//?=
 =?us-ascii?Q?AherZsqOs3GduC1JgeXiEkIzuGuXRiEwJZwyvESQ3XSq3e3cmviVe6VjDqg0?=
 =?us-ascii?Q?Dxoukeg3hAZ1YrIye3WtBp0ti36pXIhF09U3yByo?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5807.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52c19ca2-d31f-4c84-4bd3-08da6b1b8cc5
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 13:18:49.6063
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nl4hmfyjImK/SnOMjjlzq0cevq/pQs9w44q3AD4KCraBH+zB/lQ+6j8oJF4KwP9CDujfJk8/74fTjnXuyZA4ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2856
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Linuxppc-dev <linuxppc-dev-
> bounces+camelia.groza=3Dnxp.com@lists.ozlabs.org> On Behalf Of Sean
> Anderson
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
> netdev@vger.kernel.org
> Cc: Leo Li <leoyang.li@nxp.com>; Sean Anderson
> <sean.anderson@seco.com>; Russell King <linux@armlinux.org.uk>; linux-
> kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>; Paolo
> Abeni <pabeni@redhat.com>; linuxppc-dev@lists.ozlabs.org; linux-arm-
> kernel@lists.infradead.org
> Subject: [PATCH net-next v3 38/47] net: dpaa: Adjust queue depth on rate
> change
>=20
> Instead of setting the queue depth once during probe, adjust it on the
> fly whenever we configure the link. This is a bit unusal, since usually
> the DPAA driver calls into the FMAN driver, but here we do the opposite.
> We need to add a netdev to struct mac_device for this, but it will soon
> live in the phylink config.
>=20
> I haven't tested this extensively, but it doesn't seem to break
> anything. We could possibly optimize this a bit by keeping track of the
> last rate, but for now we just update every time. 10GEC probably doesn't
> need to call into this at all, but I've added it for consistency.
>=20
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

Acked-by: Camelia Groza <camelia.groza@nxp.com>