Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: RE: [PATCH net-next v3 29/47] net: fman: Map the base address once
Thread-Topic: [PATCH net-next v3 29/47] net: fman: Map the base address once
Thread-Index: AQHYmJcNhh8WReUf00m8grOHHLnSX62I008Q
Date:   Thu, 21 Jul 2022 13:04:37 +0000
Message-ID: <VI1PR04MB580763F33F7EFB0265DB1C40F2919@VI1PR04MB5807.eurprd04.prod.outlook.com>
References: <20220715215954.1449214-1-sean.anderson@seco.com>
 <20220715215954.1449214-30-sean.anderson@seco.com>
In-Reply-To: <20220715215954.1449214-30-sean.anderson@seco.com>
Accept-Language: en-GB, ro-RO, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7scF2+P3hzuzzUsaK12idXciG+tyeKdn3X1St+og6BRwRA7y4qvtDaH8q40S?=
 =?us-ascii?Q?Dr379scxlyDxFXFg4C8jcr/NB90s9fR7hY8RYWW4Kj+Ga2s6LAPwdsLGKK91?=
 =?us-ascii?Q?Kd3cmc7gYnQFX5IsoARWQpuZwsWnayC42y3PguhvWgMKc6OAaXGltI1vj50D?=
 =?us-ascii?Q?EpKlb7BcHKhOVW6sX4gvOVOH/sr0J60SdMaxq0QAIlO22UG4H6eb66TA9df0?=
 =?us-ascii?Q?yDvpoWdVS34nNmqqowvT9ELNjWT1ON5Ww3UEaOuLEAM74g/UeDfNFQgn2M0A?=
 =?us-ascii?Q?CpDNMCeTdH/LsitKLG0VqmkI8Np0eooHbt0BVI9XQzcbzfbg0oX+sBKZ1s7i?=
 =?us-ascii?Q?YV6LI2C44U9FT0L52e67QSnptzNB9CPriLDgLp6d+7CasSFf2qZEXWYsFuhQ?=
 =?us-ascii?Q?5TUJXUZWITNJEbOgQtnefBYdGXnx5a6L/zqhVJyzEPrQHwBLDmWbz2gu8LvZ?=
 =?us-ascii?Q?YOgvTRVp5a8KeQiQMPtBhm00lJ+u7lO5eg6Lg5iGX8HPDskMotmgvwY/f37x?=
 =?us-ascii?Q?sF9nC/dhZgO1SiziUmLiAbWMBmkQ2V8+1HzbULRZwhCq1fkXkwyXxN1YcPCA?=
 =?us-ascii?Q?tP4G8ALdQE/KnxamazcGyvP4JVJftjxXzClZ4aE/YsQKQ9v/PO4bFscOQCFJ?=
 =?us-ascii?Q?pMCUP5IifTHmWpusQJkLj0Zk4uB4J9sH7bsPsx/QrnUxiawJXLsOXc0W9a6F?=
 =?us-ascii?Q?Ls8LttJOLtfO66qFyrQP5emE4QY4sh0B6jIuk2wmH5IN8/M02+t27R5Inz/E?=
 =?us-ascii?Q?4oOvBgmZQ4GcNLDEcu5lVN84RZ6UqSYJy4xuWL6N5ly5kJBIHPd0xoM9wmFO?=
 =?us-ascii?Q?ZIh8nGaoDBwHY8AOiCDLHiqNleZr01Qs5I37KtsR1509htK25atNA1qwxeam?=
 =?us-ascii?Q?HEbn2E2Irchx24aPN1ygWEZU6APm5+EwzUthg4XXYM0KV0jtCCBX1MgC+zfg?=
 =?us-ascii?Q?443EA1qd2XP83waZGDIPSbX+h1QB7Vs8DV8Bv+OO0+qBIT9Z0XGf9E9vlDwK?=
 =?us-ascii?Q?Bzdmt+/TOq55Nt9MlSzjDcsCjMiuGMdZJVJzRkGPYAZ2Ts5s7lS2LBGkI8WO?=
 =?us-ascii?Q?sbZutB1SBT0UfPOjJAPKljh6wE7EFU6rpORT08rbnp1zPz6tA/9VN6PU72GZ?=
 =?us-ascii?Q?mvxt0eUxnZgwHeQM62kojuKyFUqWeze8CoeeyEl1VviaYCAZ1ZYvAahI1VP2?=
 =?us-ascii?Q?dOyz0H9I46ZAHJZ3kdpMzs4haLLYbpN2TZZofUAkOKMHLz+fFtSQTCNc/0CB?=
 =?us-ascii?Q?M+M86pvefNFDoO2WAciz9x5imhaEMMfKWUzWZEhWE8IhicZEeweJGECv2AeH?=
 =?us-ascii?Q?FYAK1+/5eRZTRZTCIKmVHIPW3hB6npOjB4IywYJP+0vdvKVvEJ2z0B/UmvGg?=
 =?us-ascii?Q?9IVaqYCbbeq4C3LLcPndlyBLgvuPafRCvE6mwAUXOeDxDxA6c1SaHOt1lTWF?=
 =?us-ascii?Q?DcdgNYp1NArmchoRP2uMOOJMxqSEcwLR2HCECqDMWlZLJX55QolT9Gw/1EU/?=
 =?us-ascii?Q?sthqwiKcnqCohVejfgRkInnKJoWZusRZR+I48soinuPRyqUrs5IJPKceurR2?=
 =?us-ascii?Q?htTAUcPqAR36JKVzCw/Ktq4DDJkOIcixCw4iPE8A?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5807.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8758259d-bb22-4f98-1f4a-08da6b19909c
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 13:04:37.0539
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3cZmexQbx1P0kusaulqhmqTagBpgergc6kCrbWsTBb/6+4VlksMU05HweF4e+N56xKgtaoZsYOZ7I0BHV1Lu+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2560
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; Madalin Bucur <madalin.bucur@nxp.com>;
> netdev@vger.kernel.org
> Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
> <edumazet@google.com>; linux-arm-kernel@lists.infradead.org; Russell
> King <linux@armlinux.org.uk>; linux-kernel@vger.kernel.org; Sean Anderson
> <sean.anderson@seco.com>
> Subject: [PATCH net-next v3 29/47] net: fman: Map the base address once
>=20
> We don't need to remap the base address from the resource twice (once in
> mac_probe() and again in set_fman_mac_params()). We still need the
> resource to get the end address, but we can use a single function call
> to get both at once.
>=20
> While we're at it, use platform_get_mem_or_io and
> devm_request_resource
> to map the resource. I think this is the more "correct" way to do things
> here, since we use the pdev resource, instead of creating a new one.
> It's still a bit tricy, since we need to ensure that the resource is a

*tricky* typo

> child of the fman region when it gets requested.
>=20
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

Acked-by: Camelia Groza <camelia.groza@nxp.com>