Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp586405imi; Thu, 21 Jul 2022 07:07:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tD1D0sgnAB3WqHme48HUnJL5jr7Y7YM/NziGmIRlMRD12TJh4RJtnE9/otMKnR1JXGzw/M X-Received: by 2002:a17:906:9b86:b0:6fe:d37f:b29d with SMTP id dd6-20020a1709069b8600b006fed37fb29dmr40996120ejc.327.1658412477716; Thu, 21 Jul 2022 07:07:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658412477; cv=none; d=google.com; s=arc-20160816; b=P4yLDq18H4TIWbe6b4EHu8IOnOdueizb0gk8HwPN2HuznGG/n0vz7ncTt5Kfvz6FF7 s9i3JW362e2BP3oA4N0AVnyVAH8DzrSPFcKjIrhzccN+h4o3V324IZaMAQlO8/PKUJaM iHgGaYZMGj0wwpQCrpaDJXF8DHyFubDSqiNzSjHr+0fBcNJhaxusykEsEZonVETE0h64 edSwbnTwXqNIBv3rBEXk4WXb6gC7CpR5Zu0M4zbo3A4/sk3ZiTHwDOZgrI77M0wi4qdl 864YgQpVExjvZkxlB+TX3/n/4IxcMu6ifYXgipg8LjBSVEY9rxpb3AC7n0EHFsCor/Ax Ooow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=dvQMYkKmqmqqc4VCUTJzR9+SlJpivrjaeB7DHmCLQrw=; b=Q6sObx/pf3f2/BQkJyg7WKz5eSh77wNv0fnlYcx07+2Zx+VF1rlOjDspW2DejGnqd4 rXS46OcSyGeRmK5g6+WV3L1r7e9QxmO/sWHmGe9r7x3sT0N2xZgu1PXtdGlkIKWn8Y6a b60hr0s6my/342I6cH07xJdy+xR/6iGN4SmThBSL9IYCSXhLjMgbhpxIsA4vnx+CIiCE 8mQiuFN2BKxIbY0BUlKkVSWU0SJa9p0OLfedoku9/hy4KyVh/K56oI4QF0Qw4CZGicwc 6jUSBrcTjryFG7RUgQZfmYrOSFycCYxHdYjDDTiuP19ra1lBHDKdZFcgutQpvexPLTrS GRQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=Q1+WX7NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf42-20020a1709077f2a00b00722668dbcacsi3121063ejc.575.2022.07.21.07.07.32; Thu, 21 Jul 2022 07:07:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=Q1+WX7NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234175AbiGUNUg (ORCPT + 99 others); Thu, 21 Jul 2022 09:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233686AbiGUNUb (ORCPT ); Thu, 21 Jul 2022 09:20:31 -0400 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDFE16585; Thu, 21 Jul 2022 06:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dvQMYkKmqmqqc4VCUTJzR9+SlJpivrjaeB7DHmCLQrw=; b=Q1+WX7NPoQzh6yiUZFQ0Ek4L5Q oXH2OmXCRrxRbE85Oi6Wq2PTmx29N2j3HDT6/Xm2pOWm4imLd4Npy0vQ/CpfJc4OqouQx4jVCY7ut CCvUU4wc3ndzWek9kufUeAg70npaFEOeR2jPjDxzAos5yTc3y7Ni4EGLfm3tdfaWDslybxoLxX7hz mFJPp4qDIAw4knNXpHYjBube1pYG73dPqWeHBQVIZBJ8Sn52tnE5RQjVR9Illm8eritC4URLV3lcU jWaCaNEU8V38HykYQ/BwzKqbKcN9aywfP4PoiFsgknm5Hg4sxvGzw8IfBrP2pQEvMPFDJPBCYWYhC cQDURkeA==; Received: from 200-100-212-117.dial-up.telesp.net.br ([200.100.212.117] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1oEW6F-001UJf-1Z; Thu, 21 Jul 2022 15:20:19 +0200 Message-ID: <76b6f764-23a9-ed0b-df3d-b9194c4acc1d@igalia.com> Date: Thu, 21 Jul 2022 10:19:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 07/13] parisc: Replace regular spinlock with spin_trylock on panic path Content-Language: en-US To: Jeroen Roovers , Helge Deller Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, linux-parisc@vger.kernel.org, "James E.J. Bottomley" References: <20220719195325.402745-1-gpiccoli@igalia.com> <20220719195325.402745-8-gpiccoli@igalia.com> <20220720034300.6d2905b8@wim.jer> From: "Guilherme G. Piccoli" In-Reply-To: <20220720034300.6d2905b8@wim.jer> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/07/2022 22:43, Jeroen Roovers wrote: > Hi Guilherme, > [...] >> + * >> + * The _panic version relies in spin_trylock to prevent deadlock >> + * on panic path. > > in => on > Hi Jer, thanks for the suggestion! Helge, do you think you could fix it when applying, if there's no other issue in the patch? Thanks, Guilherme