Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3761ef37-85fc-de81-b211-39eaf3fe2362@gnuweeb.org>
Date:   Thu, 21 Jul 2022 20:08:19 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: Linux 5.19-rc7 liburing test `poll-mshot-overflow.t` and
 `read-write.t` fail
Content-Language: en-US
To:     Dylan Yudaken <dylany@fb.com>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        io-uring Mailing List <io-uring@vger.kernel.org>,
        GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <2709ed98-6459-70ea-50d4-f24b7278fb24@gnuweeb.org>
 <3489ef4e810b822d6fdb0948ef7fdaeb5547eeba.camel@fb.com>
 <beae1b3b-eec3-1afb-cdf9-999a1d161db4@gnuweeb.org>
 <e3987a2f55d154a7b217d86d805719043957db60.camel@fb.com>
From:   Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <e3987a2f55d154a7b217d86d805719043957db60.camel@fb.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/21/22 7:05 PM, Dylan Yudaken wrote:
> It seems to be a problem with blocking reads, buffer select and READV.
> My guess is that ext4/xfs are not blocking.
> 
> in b66e65f41426 ("io_uring: never call io_buffer_select() for a buffer
> re-select"), this line was added in __io_iov_buffer_select
> 
> -       iov[0].iov_len = len;
> +       req->rw.len = iov[0].iov_len = len;
> 
> Basically stashing the buffer length in rw.len. The problem is that the
> next time around that breaks at
> 
>          if (req->rw.len != 1)
>                  return -EINVAL;
> 
> 
> The below fixes it as an example, but it's not great. Maybe someone can
> figure out a better patch? Otherwise I can try tomorrow:

It's 8:05 PM from my end. I'll try to play with your patch after dinner
while waiting for others say something.

-- 
Ammar Faizi