Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 14:59:52 +0200
From:   Jiri Pirko <jiri@nvidia.com>
To:     Vikas Gupta <vikas.gupta@broadcom.com>
Cc:     kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        dsahern@kernel.org, stephen@networkplumber.org,
        edumazet@google.com, pabeni@redhat.com, ast@kernel.org,
        leon@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net,
        michael.chan@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next v4 3/3] bnxt_en: implement callbacks for devlink
 selftests
Message-ID: <YtlNyC9t3KsveqQH@nanopsycho>
References: <20220718062032.22426-1-vikas.gupta@broadcom.com>
 <20220721072121.43648-1-vikas.gupta@broadcom.com>
 <20220721072121.43648-4-vikas.gupta@broadcom.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220721072121.43648-4-vikas.gupta@broadcom.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pbijtLb2W0T7EShb4j5M0lbEf3CMRrtZffx6eFyigf/U2bwE47fk4V8M5qvz?=
 =?us-ascii?Q?i1Newrqrhdr4ligeu9ls2OoKctse+NLb45w8PD2tYmjLuhJ4x7pWQaJMci2T?=
 =?us-ascii?Q?qFto6XpY/SDmUpVSl39jYtECeB9BIhoyzehikIBZ2Vmd+6ygvwJd4DYKeYx+?=
 =?us-ascii?Q?WWsk7IiIk4lsKP+teVDkhb3CUb0PzPglwNljbYcny6lofsZhjtUEErEmKJBF?=
 =?us-ascii?Q?DHbxguvhgu9hijuW/uP4g0ViznzUnkNIjxo2lSgpLOtJpkqFvyBydOYuis2T?=
 =?us-ascii?Q?Fri/j8ScNMD/RclYC3DQeKzlLH6Yj8maoedVZicjlK6i/vEmTzW/RcXjZRMU?=
 =?us-ascii?Q?tIZFksLmHIIKyB3ZTsMT/5O0rXkGtFydp6IP+M5QEVjNizuk4u87Xc9YwnhK?=
 =?us-ascii?Q?T9xJvjS3tkL6mZY/VnCzsfBr/AxW3tttJ3idPM+1IRLXlEEiAhetZ437UAt1?=
 =?us-ascii?Q?Yj24T6xzfu4sbjX2lTAMDL6UKHiA68AbH0g7ZRpLmqGo69eKlJ6TwMSJhi2J?=
 =?us-ascii?Q?/l0MtRSDXgnNXM3j6CQzyxvs8a3RfdoWhLZLJvS6jjU4rhcHP4TJe6qDg6KJ?=
 =?us-ascii?Q?kpIHt0GzMG8zWCeYmJBmNT03b8hQW2l3wsQH+yfW2HSjcBjD1LSvCYcy4aru?=
 =?us-ascii?Q?ublp+PcuQzMxi4deXBXZ89yXYkIaJ64HUEmmh+wNXBWiaWitbUe/jwX9xsGU?=
 =?us-ascii?Q?FegaGI46/K5qvhtNq2LVOR4Lzv23/7ouW9dLgnNt5zxOZ21kqzIHeB2QSdcO?=
 =?us-ascii?Q?Pht1/CTko1X2LggRnekmDprEaHD2FFnGI2Y/7iZmQOQQALGZCIX8JjC9adV5?=
 =?us-ascii?Q?ShAXmkhjhd4CYfTP+oJYjrCdKVoJ67SilLQRg9sLzukpGyxqVTwsEF7vDzDH?=
 =?us-ascii?Q?ooVk19ZNcFObv0d5dOk7cM8yfKmiQ32mIpCCYYE7SEiPwGoWkovs+owpR7vX?=
 =?us-ascii?Q?oXr9Ea7Mx/EZ04xqI1znYULKV9PqfMBbEOs0UoaRImrrApwGMTqDulUMJ4if?=
 =?us-ascii?Q?wCzL8SYjN33yrXn6paInmi/qn6DLW83VmnvrOjsRlVptwUrjp/Sx1N6HVBJS?=
 =?us-ascii?Q?Dk4HCyzFNEiwrRkV4Y9B10kWFI6IN92FHs313wn2qdsKQIHyLM2oowz+hTNH?=
 =?us-ascii?Q?/MpiPvz/qwwsLm1+i1vTC6gOJ5xnHN2D1u17U6std5U3dOAINvp1Dx1F5avY?=
 =?us-ascii?Q?A4AFCju+ZqsXE9cH0Lgeqc7k68K1jKUbhnXWTEqqv2v007ecYbo12Eqdmz88?=
 =?us-ascii?Q?q3B+okOVoyCoUUVgQo0DkiCeEHOdxWPJOkbe9/70M7/Kow2Fta1NRTSGzlZg?=
 =?us-ascii?Q?Kb3aH/OQf3cnQdbTqZ3XH1AJy5gauwgC8tQLZ7BpakQ4JQ3HVHo0iSMVWNfV?=
 =?us-ascii?Q?bVo3DINGDCVTPbPA6UryF3wvAM6Pv/xhk6niWw2ahsE6hDAKEF5iAze4VesF?=
 =?us-ascii?Q?9ftHsGkSIZPuQVSBYhrDlMYCHtyqCDHkeO0WHf+NBH/1NkT1ITw+dG49gR/v?=
 =?us-ascii?Q?ST0V0uC4XbhcY8lWF4ECHsj57ak3az9iAe/2+39hqCNOTXOcD0lGyggKZQH+?=
 =?us-ascii?Q?hCRmA9f/0OqNcyotsn8Su0S9BOXA+ZmkHoQ3mOBK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fea03313-6d2c-48a3-19ba-08da6b18e976
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5979.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 12:59:56.7345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: geCrUsdoOOrKJWDn+EGl5l+UmrQCRwOyxA+WhZZjuvYOjtwY+9PxvPdvoIBdMm0n
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5415
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thu, Jul 21, 2022 at 09:21:21AM CEST, vikas.gupta@broadcom.com wrote:
>Add callbacks
>=============
>.selftest_check: returns true for flash selftest.
>.selftest_run: runs a flash selftest.
>
>Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
>Reviewed-by: Michael Chan <michael.chan@broadcom.com>
>Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
>---
> .../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
>diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>index 6b3d4f4c2a75..927cf368d856 100644
>--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>@@ -20,6 +20,8 @@
> #include "bnxt_ulp.h"
> #include "bnxt_ptp.h"
> #include "bnxt_coredump.h"
>+#include "bnxt_nvm_defs.h"
>+#include "bnxt_ethtool.h"
> 
> static void __bnxt_fw_recover(struct bnxt *bp)
> {
>@@ -610,6 +612,62 @@ static int bnxt_dl_reload_up(struct devlink *dl, enum devlink_reload_action acti
> 	return rc;
> }
> 
>+static bool bnxt_nvm_test(struct bnxt *bp, struct netlink_ext_ack *extack)
>+{
>+	u32 datalen;
>+	u16 index;
>+	u8 *buf;
>+
>+	if (bnxt_find_nvram_item(bp->dev, BNX_DIR_TYPE_VPD,
>+				 BNX_DIR_ORDINAL_FIRST, BNX_DIR_EXT_NONE,
>+				 &index, NULL, &datalen) || !datalen) {
>+		NL_SET_ERR_MSG_MOD(extack, "nvm test vpd entry error");
>+		return false;
>+	}
>+
>+	buf = kzalloc(datalen, GFP_KERNEL);
>+	if (!buf) {
>+		NL_SET_ERR_MSG_MOD(extack, "insufficient memory for nvm test");
>+		return false;
>+	}
>+
>+	if (bnxt_get_nvram_item(bp->dev, index, 0, datalen, buf)) {
>+		NL_SET_ERR_MSG_MOD(extack, "nvm test vpd read error");
>+		goto err;
>+	}
>+
>+	if (bnxt_flash_nvram(bp->dev, BNX_DIR_TYPE_VPD, BNX_DIR_ORDINAL_FIRST,
>+			     BNX_DIR_EXT_NONE, 0, 0, buf, datalen)) {
>+		NL_SET_ERR_MSG_MOD(extack, "nvm test vpd write error");
>+		goto err;
>+	}
>+
>+	return true;
>+
>+err:
>+	kfree(buf);
>+	return false;
>+}
>+
>+static bool bnxt_dl_selftest_check(struct devlink *dl, int test_id,
>+				   struct netlink_ext_ack *extack)
>+{
>+	return (test_id == DEVLINK_SELFTEST_ATTR_FLASH);

Return is not a function, avoid "()"


>+}
>+
>+static u8 bnxt_dl_selftest_run(struct devlink *dl, int test_id,
>+			       struct netlink_ext_ack *extack)
>+{
>+	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
>+
>+	if (test_id == DEVLINK_SELFTEST_ATTR_FLASH) {
>+		return (bnxt_nvm_test(bp, extack) ? DEVLINK_SELFTEST_PASS :
>+						    DEVLINK_SELFTEST_FAIL);

Return is not a function, avoid "()"

>+	}

No need for "{}", it's a simple statement. I'm pretty sure checkpatch
would warn you, did you run it?


>+
>+	return DEVLINK_SELFTEST_SKIP;
>+}
>+
> static const struct devlink_ops bnxt_dl_ops = {
> #ifdef CONFIG_BNXT_SRIOV
> 	.eswitch_mode_set = bnxt_dl_eswitch_mode_set,
>@@ -622,6 +680,8 @@ static const struct devlink_ops bnxt_dl_ops = {
> 	.reload_limits	  = BIT(DEVLINK_RELOAD_LIMIT_NO_RESET),
> 	.reload_down	  = bnxt_dl_reload_down,
> 	.reload_up	  = bnxt_dl_reload_up,
>+	.selftest_check	  = bnxt_dl_selftest_check,
>+	.selftest_run	  = bnxt_dl_selftest_run,
> };
> 
> static const struct devlink_ops bnxt_vf_dl_ops;
>-- 
>2.31.1
>