Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b0f7dadc-fa40-c192-9c37-c8150c0d6929@linaro.org>
Date:   Thu, 21 Jul 2022 15:49:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
Content-Language: en-US
To:     Peng Fan <peng.fan@nxp.com>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>
Cc:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "marex@denx.de" <marex@denx.de>,
        "paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>,
        "aford173@gmail.com" <aford173@gmail.com>,
        "Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>,
        "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>
References: <20220719055054.3855979-1-peng.fan@oss.nxp.com>
 <20220719055054.3855979-4-peng.fan@oss.nxp.com>
 <27ab24ec-61c7-cafb-6665-a16c58808649@linaro.org>
 <DU0PR04MB941796A54DC4932E5A58F4B0888F9@DU0PR04MB9417.eurprd04.prod.outlook.com>
 <9c1735bf-3f29-4bf1-f7cf-f9e211c505ac@linaro.org>
 <DU0PR04MB94172A78F8E9E74FC842F22B88919@DU0PR04MB9417.eurprd04.prod.outlook.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <DU0PR04MB94172A78F8E9E74FC842F22B88919@DU0PR04MB9417.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/07/2022 12:38, Peng Fan wrote:
>> Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
>>
>> On 19/07/2022 11:58, Peng Fan wrote:
>>>>> +        interconnects:
>>>>> +          items:
>>>>> +            - description: G1 decoder interconnect
>>>>> +            - description: G2 decoder interconnect
>>>>> +            - description: VC8000E encoder interconnect
>>>>> +
>>>>> +        interconnect-names:
>>>>> +          items:
>>>>> +            - const: g1
>>>>> +            - const: g2
>>>>> +            - const: vc8000e
>>>>
>>>> Include interconnects+names in list of all properties and disallow
>>>> them for other variants.
>>>
>>> I not understand well about
>>> " Include interconnects+names in list of all properties ", could you
>>> please explain a bit more?
>>>
>>> And there is already an "if" to check whether the compatible contains
>>> " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect valid for
>>> i.MX8MP, so it is not valid to other variants.
>>
>> Defining properties in some if: clause is not really readable and
>> maintainable. The properties should be defined in top-level properties:.
> 
> Maybe I should also include i.MX8MM interconnect and make it
> a separate patch, then i.MX8MP/i.MX8MM just use their own
> names just like other properities. In final, as below:
> 
> Tow patch:
>   1. Add interconnect property for i.MX8MM VPU BLK CTRL
>   2. Add i.MX8MP VPU BLK CTRL dt bindings
> 
> In top-level:
> + interconnects:
> +    maxItems: 3
>  
> +   interconnect-names:
> +      maxItems: 3
> 
> For i.MX8MM
> +        interconnects:
> +          items:
> +            - description: G1 decoder interconnect
> +            - description: G2 decoder interconnect
> +            - description: H1 encoder interconnect
> +
> +        interconnect-names:
> +          items:
> +            - const: g1
> +            - const: g2
> +            - const: h1
> 
> For i.MX8MP:
> +        interconnects:
> +          items:
> +            - description: G1 decoder interconnect
> +            - description: G2 decoder interconnect
> +            - description: VC8000E encoder interconnect
> +
> +        interconnect-names:
> +          items:
> +            - const: g1
> +            - const: g2
> +            - const: vc8000e
> 
> How do you think?

I don't understand what is the question here to me. Shall I tell you
what to do or not to do with iMX 8MM? I don't know. I am not a
maintainer of that SoC.


Best regards,
Krzysztof