Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Jul 2022 07:16:30 -0700
From:   Richard Cochran <richardcochran@gmail.com>
To:     Divya.Koppera@microchip.com
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
        Madhuri.Sripada@microchip.com
Subject: Re: [PATCH v2 net] net: phy: micrel: Fix warn: passing zero to
 PTR_ERR
Message-ID: <Ytlfvqns1Qp4/UWA@hoboy.vegasvil.org>
References: <20220719120052.26681-1-Divya.Koppera@microchip.com>
 <Yta4BFfr+OkUmOhl@hoboy.vegasvil.org>
 <CO1PR11MB47715323651FBC994C4C918FE28E9@CO1PR11MB4771.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CO1PR11MB47715323651FBC994C4C918FE28E9@CO1PR11MB4771.namprd11.prod.outlook.com>
Precedence: bulk

On Wed, Jul 20, 2022 at 04:32:55AM +0000, Divya.Koppera@microchip.com wrote:

> static int lan8814_ptp_probe_once(struct phy_device *phydev)
> {
>         struct lan8814_shared_priv *shared = phydev->shared->priv;
> 
>         if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
>             !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
>                 return 0;

It is weird to use macros here, but not before calling ptp_clock_register.
Make it consistent by checking shared->ptp_clock instead.
That is also better form.

Thanks,
Richard