Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "Simek, Michal" <michal.simek@amd.com>,
        "m.tretter@pengutronix.de" <m.tretter@pengutronix.de>
CC:     "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "git (AMD-Xilinx)" <git@amd.com>,
        Shravya Kumbham <shravyak@xlnx.xilinx.com>,
        "Katakam, Harini" <harini.katakam@amd.com>
Subject: RE: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the
 coverity warning
Thread-Topic: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the
 coverity warning
Thread-Index: AQHYb0LkOX4+245pnEK0Y6LTVu67+a2JO/jQ
Date:   Thu, 21 Jul 2022 14:23:12 +0000
Message-ID: <MN0PR12MB59533B9E84A41900892E13D7B7919@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <1653378553-28548-1-git-send-email-radhey.shyam.pandey@amd.com>
In-Reply-To: <1653378553-28548-1-git-send-email-radhey.shyam.pandey@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Xu13HOJTQNxKJbU5tvGFW9Aw+mxEKfif8BCskatY6dm8b6aSyFLcKftN48JK?=
 =?us-ascii?Q?OLl8T1ombaU5YHiz8Oy1Q2ChuDO8I8Y2UiJ2JlBhpTzuOlmR2xD7ka2j8Ziy?=
 =?us-ascii?Q?oWa6IagbzFhEUa9YYuCN+kwAHroOM6tt6iJtNjulTyFw7PBlZ1joQYHFxnC8?=
 =?us-ascii?Q?gylOeuLjsTPCjwESa2kLHbwog0J7gO6JivmnJaazPOG86Z13QOgxwAIERhPm?=
 =?us-ascii?Q?MZqOAp9JCZkiR0EtPR3yLHrkgg83QOQd9hRzQRV4sKwjqLyjS14k5bJcza6Q?=
 =?us-ascii?Q?NUmLzG8oaYUs9JudJ4d17YAyxwNJUX+wPcq6nGDMSlKEc2mRVz8OM1+WXglf?=
 =?us-ascii?Q?PlMUDCAY0t9DIY9ejcNwvZaq5V8267M8KqjMt7V9sMQNktBNW0PKRvo4Di0P?=
 =?us-ascii?Q?NyTqP22BYhAkSctb8W00fXza38v6Ffwrp4uC5GRGbB+Mur2HpV25lvKXT8Zl?=
 =?us-ascii?Q?wTTYjMAaDfAAFAh3DZBQYCaCLTg8S5JSJhJhdQK2oI0Izth7FiBuXELXruTy?=
 =?us-ascii?Q?TpHjlNmyn6oXBTTajgfSVSlSV+Pw11Zp5ID3uDFGXPYgKnozsxRLUBDnii/X?=
 =?us-ascii?Q?h83JQvwNrWeTkqL8cp5nzMaC4smHE0EBUeqpkY1QLJUREq5E//+pz6HZejkt?=
 =?us-ascii?Q?0pQh9Ner/ndF5CYsNhEt6BM1kXhMP99BXsTADgzTynLrJcC6Fg2yElJ2N4m0?=
 =?us-ascii?Q?dkH+YegFZVTnJBVi1kb8pRVt3AsvMrH4K50N4+KUp04mlTvCPJUSXSeSHH+v?=
 =?us-ascii?Q?4o1iHJpCPQZBcu53XpT7L97f+A7My02Wb5/LSuyxB/P9lrowASRZrkhio81k?=
 =?us-ascii?Q?/mUARYrRMpsVa99GL9YtBw3fIvaNBIARxmB8s1ZF0sc6ZpDfmLRexePEoMNj?=
 =?us-ascii?Q?mNnlQOnZGOYp89ZkplQMcBQyB7fM8zzsUnff8uo99vjGQiGptUInTc4GsUzN?=
 =?us-ascii?Q?52kc63RkF5cGN7tpdOiNTUdh8sQCf8ReEPzOf38RUD/g+CV62+NR2bCsjH4M?=
 =?us-ascii?Q?KDTYSnBn0djgkCb+2FcVqA94pvf4f/n9drtTEukgZ+s7Z+XIi2Bi0UXDLis2?=
 =?us-ascii?Q?E+xsnYnuC26DsocGDCEFMQJRTqiO6bDQJa1ukHNRhh+PC/C9mPr8hf0Nesnu?=
 =?us-ascii?Q?4LHTSZvETSWvlX8hJG5B4mmHLNTZ0wUk5l1afwkkkqrr4jkKiYLWm4A8TYIw?=
 =?us-ascii?Q?A6nEo8AI8i3Fzca+96dxyrVxA4t9ZuA84LFvq9e7EOJEwt9OzABwpGEJXs//?=
 =?us-ascii?Q?vR5KpjW0VIgtaSUrK4E39Z3Wz4jwgt2jMF3xZJVwSyMkplmoybgTQN7jN+FY?=
 =?us-ascii?Q?2xe+HKIPAkxMXcxO+ILpcfbdWMpwywO6YwcGHVKnOA8TngxIxuw7FmIp7L4D?=
 =?us-ascii?Q?8mvfth7v2dMOG+LDh9OywLJErcRVtbR6H4nJcliRRH+IKehQvakYNxrpFrfX?=
 =?us-ascii?Q?LipEDuUxadQJRfWTAgJtToxjPqw3kLNBCUlyTY+0Iojh6sF/dgM5DJvHS1ft?=
 =?us-ascii?Q?5fhG1NFkCR71hsulbZDhk/vLqIFP6tbjBSDYymIkw+jLPkyfHByCfGGzyjHq?=
 =?us-ascii?Q?AnmgfrVUbu1EUTG10/8WwyrEnQ8PxMrXXqkb+jXkZT2KunTB5D1xIZ+xtcju?=
 =?us-ascii?Q?oVRMSkcfTONDMHBZOrdf4c8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15abf2b6-24cb-48f4-5e14-08da6b248b69
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 14:23:12.7967
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qoz0NZY0AYOCuZDC6FH2kCiNvikqA0BF2YD3NxF73gvJNk/2EPBjCn2ZbVf6jdWC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5848
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Sent: Tuesday, May 24, 2022 1:19 PM
> To: vkoul@kernel.org; Michal Simek <michals@xilinx.com>;
> m.tretter@pengutronix.de
> Cc: dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org;
> git@amd.com; Shravya Kumbham <shravyak@xlnx.xilinx.com>; Harini
> Katakam <harinik@xilinx.com>; Radhey Shyam Pandey
> <radhey.shyam.pandey@amd.com>
> Subject: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the
> coverity warning
>=20
> From: Shravya Kumbham <shravya.kumbham@xilinx.com>
>=20
> Typecast the flags variable with (enum dma_ctrl_flags) in
> zynqmp_dma_prep_memcpy function to fix the coverity warning.
>=20
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> NOTE- This patch was sent to dmaengine mailing list[1] and
> there was a suggestion from Michael Tretter to change the
> signature of the dmaengine_prep_dma_memcpy() engine to accept
> "enum dma_ctrl_flags flags" instead of "unsigned long flags".
>=20
> All device_prep_dma_* API variants have ulong flags argument.
> So this is a wider question if we want to change these APIs?
> Also there are existing users of these public APIs.
>=20
> [1]: https://lore.kernel.org/linux-arm-kernel/20210914082817.22311-2-
> harini.katakam@xilinx.com/t/#m1d1bc959f500b04fa1470caa31239a95c73fd
> 45d
> ---
>  drivers/dma/xilinx/zynqmp_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c
> b/drivers/dma/xilinx/zynqmp_dma.c
> index dc299ab36818..3f4ee3954384 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -849,7 +849,7 @@ static struct dma_async_tx_descriptor
> *zynqmp_dma_prep_memcpy(
>=20
>  	zynqmp_dma_desc_config_eod(chan, desc);
>  	async_tx_ack(&first->async_tx);
> -	first->async_tx.flags =3D flags;
> +	first->async_tx.flags =3D (enum dma_ctrl_flags)flags;
>  	return &first->async_tx;
>  }
>=20
> --
Ping! for review.